Re: [PATCH] scsi: break from queue depth adjusting loops when device found

2014-07-27 Thread Hannes Reinecke
On 07/26/2014 06:17 PM, Christoph Hellwig wrote: On Sat, Jul 26, 2014 at 11:14:35AM -0500, Stephen Cameron wrote: Hmm, I forgot that that patch was in there, I wasn't trying to keep pushing it along. From the previous discussion, I got the impression I was simply wrong, and that this patch wasn

Re: [PATCH] scsi: break from queue depth adjusting loops when device found

2014-07-26 Thread Christoph Hellwig
On Sat, Jul 26, 2014 at 11:14:35AM -0500, Stephen Cameron wrote: > Hmm, I forgot that that patch was in there, I wasn't trying to keep pushing > it along. From the previous discussion, I got the impression I was simply > wrong, and that this patch wasn't needed, so I had meant to drop it, I just >

Re: [PATCH] scsi: break from queue depth adjusting loops when device found

2014-07-26 Thread Christoph Hellwig
I just saw this patch showing up again in the hpsa series, so let's get the discussiong going on how to proceed again: I think we can't simply apply the current version as it breaks the intended semantics in the FC drivers that expect an array with target-wide ressources. So if we want to go ahea

Re: [PATCH] scsi: break from queue depth adjusting loops when device found

2014-07-06 Thread Christoph Hellwig
On Fri, Jul 04, 2014 at 07:21:52PM +, Elliott, Robert (Server Storage) wrote: > Perhaps the SCSI midlayer should keep track of both > SCSI target port and logical unit queue depths, parse > the status qualifier if present, and let the host > template advise on the policy to assume if the > sta

RE: [PATCH] scsi: break from queue depth adjusting loops when device found

2014-07-04 Thread Elliott, Robert (Server Storage)
rnel.org; Vasu Dev; Mike > Christie > Subject: Re: [PATCH] scsi: break from queue depth adjusting loops when device > found > > On 07/03/2014 07:11 PM, Christoph Hellwig wrote: > > On Thu, Jul 03, 2014 at 10:05:57AM -0500, Stephen M. Cameron wrote: > >> From: Stephen

Re: [PATCH] scsi: break from queue depth adjusting loops when device found

2014-07-04 Thread Douglas Gilbert
On 14-07-03 01:21 PM, Mike Christie wrote: On 07/03/2014 12:11 PM, Christoph Hellwig wrote: On Thu, Jul 03, 2014 at 10:05:57AM -0500, Stephen M. Cameron wrote: From: Stephen M. Cameron Don't loop through all the devices even after finding the one we're looking for The comments in the code s

Re: [PATCH] scsi: break from queue depth adjusting loops when device found

2014-07-04 Thread Hannes Reinecke
On 07/03/2014 07:11 PM, Christoph Hellwig wrote: On Thu, Jul 03, 2014 at 10:05:57AM -0500, Stephen M. Cameron wrote: From: Stephen M. Cameron Don't loop through all the devices even after finding the one we're looking for The comments in the code seem to indicate that we want to modify the q

Re: [PATCH] scsi: break from queue depth adjusting loops when device found

2014-07-03 Thread Mike Christie
On 07/03/2014 12:11 PM, Christoph Hellwig wrote: > On Thu, Jul 03, 2014 at 10:05:57AM -0500, Stephen M. Cameron wrote: >> From: Stephen M. Cameron >> >> Don't loop through all the devices even after >> finding the one we're looking for > > The comments in the code seem to indicate that we want to

Re: [PATCH] scsi: break from queue depth adjusting loops when device found

2014-07-03 Thread Christoph Hellwig
On Thu, Jul 03, 2014 at 10:05:57AM -0500, Stephen M. Cameron wrote: > From: Stephen M. Cameron > > Don't loop through all the devices even after > finding the one we're looking for The comments in the code seem to indicate that we want to modify the queue depth for all LUNs on a given target. C

Re: [PATCH] scsi: break from queue depth adjusting loops when device found

2014-07-03 Thread Douglas Gilbert
On 14-07-03 11:05 AM, Stephen M. Cameron wrote: From: Stephen M. Cameron Don't loop through all the devices even after finding the one we're looking for Signed-off-by: Stephen M. Cameron Reviewed-by: Robert Elliott With my scsi_debug testing on Christoph's core-for-3.17 tree I can simulate

[PATCH] scsi: break from queue depth adjusting loops when device found

2014-07-03 Thread Stephen M. Cameron
From: Stephen M. Cameron Don't loop through all the devices even after finding the one we're looking for Signed-off-by: Stephen M. Cameron Reviewed-by: Robert Elliott --- drivers/scsi/scsi_error.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/scsi_erro