Re: [PATCH] scsi: Fixup fixed sense generation

2015-08-13 Thread Hannes Reinecke
On 08/11/2015 08:49 AM, Sagi Grimberg wrote: > >> -put_unaligned_be64(info, &buf[3]); >> +/* >> + * Fixed format sense reserves only 32 bits for the >> + * 'information' field >> + */ >> +put_unaligned_be32((u32)info, &buf[3]); >> } >> } >>

Re: [PATCH] scsi: Fixup fixed sense generation

2015-08-10 Thread Sagi Grimberg
- put_unaligned_be64(info, &buf[3]); + /* +* Fixed format sense reserves only 32 bits for the +* 'information' field +*/ + put_unaligned_be32((u32)info, &buf[3]); } } EXPORT_SYMBOL(scsi_set_sens

Re: [PATCH] scsi: Fixup fixed sense generation

2015-07-31 Thread Bart Van Assche
On 07/31/15 06:05, Hannes Reinecke wrote: Fixed sense reserves only 32 bits for the 'information' field, so we need to restrict the 'information' value to avoid sense data corruption. Also the sense key is only 4 bits. Signed-off-by: Hannes Reinecke --- drivers/scsi/scsi_error.c | 10 +++-

[PATCH] scsi: Fixup fixed sense generation

2015-07-31 Thread Hannes Reinecke
Fixed sense reserves only 32 bits for the 'information' field, so we need to restrict the 'information' value to avoid sense data corruption. Also the sense key is only 4 bits. Signed-off-by: Hannes Reinecke --- drivers/scsi/scsi_error.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deleti