Re: [PATCH] scsi: Fix sense information setting in fixed sized format

2015-07-11 Thread Sagi Grimberg
This looks correct to me, Reviewed-by: Christoph Hellwig But: this will truncate > 32bit sector numbers. Maybe we need to enable descriptor format sense data for large enough LUs. That should be easy enough now that the sense data is constructed using scsi helpers. Let me prepare a patch

Re: [PATCH] scsi: Fix sense information setting in fixed sized format

2015-07-11 Thread Christoph Hellwig
On Wed, Jul 08, 2015 at 06:00:03PM +0300, Sagi Grimberg wrote: > In fixed size sense format the information field is a four byte > field. This looks correct to me, Reviewed-by: Christoph Hellwig But: this will truncate > 32bit sector numbers. Maybe we need to enable descriptor format sense dat

Re: [PATCH] scsi: Fix sense information setting in fixed sized format

2015-07-09 Thread Martin K. Petersen
> "Sagi" == Sagi Grimberg writes: Sagi> In fixed size sense format the information field is a four byte Sagi> field. Correct. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in th

Re: [PATCH] scsi: Fix sense information setting in fixed sized format

2015-07-09 Thread Bart Van Assche
On 07/08/15 08:00, Sagi Grimberg wrote: In fixed size sense format the information field is a four byte field. Signed-off-by: Sagi Grimberg --- drivers/scsi/scsi_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/scsi_common.c b/drivers/scsi/scsi_common

[PATCH] scsi: Fix sense information setting in fixed sized format

2015-07-08 Thread Sagi Grimberg
In fixed size sense format the information field is a four byte field. Signed-off-by: Sagi Grimberg --- drivers/scsi/scsi_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/scsi_common.c b/drivers/scsi/scsi_common.c index 41432c1..8cfb7ee 100644 --- a/drive