Re: [PATCH] scsi: Double completion on retry

2013-05-02 Thread Hannes Reinecke
On 05/02/2013 10:31 AM, Hannes Reinecke wrote: > When blk_end_request() returns 'false' in scsi_end_request the > request is invalid after blk_end_request_all(). So we must not > return the then stale request pointer. Doing so will result > in a potential double completion. > And we should be calli

[PATCH] scsi: Double completion on retry

2013-05-02 Thread Hannes Reinecke
When blk_end_request() returns 'false' in scsi_end_request the request is invalid after blk_end_request_all(). So we must not return the then stale request pointer. Doing so will result in a potential double completion. And we should be calling scsi_release_buffers() before blk_end_request_all().