Re: [PATCH] qla4xxx: switch to pci_alloc_irq_vectors

Hi Nilesh, > > try_msi: > > /* Trying MSI */ > >-ret = pci_enable_msi(ha->pdev); > >+ret = pci_alloc_irq_vectors(ha->pdev, 1, 1, PCI_IRQ_MSI); > > if (!ret) { > > Since pci_alloc_irq_vectors returns a negative error code upon error, > This should be if (ret). Fixes, thanks. > Si

Re: [PATCH] qla4xxx: switch to pci_alloc_irq_vectors

Please see comments inline. Thanks, Nilesh On 18/11/16, 12:45 PM, "Christoph Hellwig" wrote: >And simplify the MSI-X logic in general - just request the two >vectors directly instead of going through an indirection table. > >Signed-off-by: Christoph Hellwig >--- > drivers/scsi/qla4xxx/ql4_def.

Re: [PATCH] qla4xxx: switch to pci_alloc_irq_vectors

> "Nilesh" == Javali, Nilesh writes: Nilesh> We would test this internally and then ACK within a week. Sounds good. Thanks! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vge

Re: [PATCH] qla4xxx: switch to pci_alloc_irq_vectors

Hi Martin, We would test this internally and then ACK within a week. Thanks, Nilesh On 29/11/16, 10:15 PM, "Martin K. Petersen" wrote: >> "Christoph" == Christoph Hellwig writes: > >Christoph> And simplify the MSI-X logic in general - just request the >Christoph> two vectors directly inst

Re: [PATCH] qla4xxx: switch to pci_alloc_irq_vectors

> "Christoph" == Christoph Hellwig writes: Christoph> And simplify the MSI-X logic in general - just request the Christoph> two vectors directly instead of going through an indirection Christoph> table. Vikas: Please review! -- Martin K. Petersen Oracle Linux Engineering -- To unsubsc

[PATCH] qla4xxx: switch to pci_alloc_irq_vectors

And simplify the MSI-X logic in general - just request the two vectors directly instead of going through an indirection table. Signed-off-by: Christoph Hellwig --- drivers/scsi/qla4xxx/ql4_def.h | 18 + drivers/scsi/qla4xxx/ql4_glbl.h | 1 - drivers/scsi/qla4xxx/ql4_isr.c | 25 +--