Re: [PATCH] qla4xxx: Return -ENOMEM on memory allocation failure

2014-07-07 Thread Vikas Chaudhary
>>> From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- >>>> ow...@vger.kernel.org] On Behalf Of Himangi Saraogi >>>> Sent: Friday, 04 July, 2014 1:28 PM >>>> To: Vikas Chaudhary; iscsi-dri...@qlogic.com; James E.J. Bottomley; >>>>linux- >>>&g

Re: [PATCH] qla4xxx: Return -ENOMEM on memory allocation failure

2014-07-07 Thread Mike Christie
Behalf Of Himangi Saraogi >>> Sent: Friday, 04 July, 2014 1:28 PM >>> To: Vikas Chaudhary; iscsi-dri...@qlogic.com; James E.J. Bottomley; linux- >>> s...@vger.kernel.org; linux-ker...@vger.kernel.org >>> Cc: julia.law...@lip6.fr >>> Subject: [PATCH] ql

RE: [PATCH] qla4xxx: Return -ENOMEM on memory allocation failure

2014-07-04 Thread Julia Lawall
rg] On Behalf Of Himangi Saraogi > > > Sent: Friday, 04 July, 2014 1:28 PM > > > To: Vikas Chaudhary; iscsi-dri...@qlogic.com; James E.J. Bottomley; linux- > > > s...@vger.kernel.org; linux-ker...@vger.kernel.org > > > Cc: julia.law...@lip6.fr > > > Subje

RE: [PATCH] qla4xxx: Return -ENOMEM on memory allocation failure

2014-07-04 Thread Julia Lawall
> To: Vikas Chaudhary; iscsi-dri...@qlogic.com; James E.J. Bottomley; linux- > > s...@vger.kernel.org; linux-ker...@vger.kernel.org > > Cc: julia.law...@lip6.fr > > Subject: [PATCH] qla4xxx: Return -ENOMEM on memory allocation failure > > > > In this code, 0 is ret

RE: [PATCH] qla4xxx: Return -ENOMEM on memory allocation failure

2014-07-04 Thread Elliott, Robert (Server Storage)
nel.org; linux-ker...@vger.kernel.org > Cc: julia.law...@lip6.fr > Subject: [PATCH] qla4xxx: Return -ENOMEM on memory allocation failure > > In this code, 0 is returned on memory allocation failure, even though > other failures return -ENOMEM or other similar values. > > A simpli

[PATCH] qla4xxx: Return -ENOMEM on memory allocation failure

2014-07-04 Thread Himangi Saraogi
In this code, 0 is returned on memory allocation failure, even though other failures return -ENOMEM or other similar values. A simplified version of the Coccinelle semantic match that finds this problem is as follows: // @@ expression ret; expression x,e1,e2,e3; identifier alloc; @@ ret = 0 ...