Re: [PATCH] qla2xxx: avoid maybe_uninitialized warning

2016-03-20 Thread Tomas Henzl
On 16.3.2016 16:03, Tomas Henzl wrote: > On 15.3.2016 22:40, Arnd Bergmann wrote: >> The qlt_check_reserve_free_req() function produces an incorrect warning >> when CONFIG_PROFILE_ANNOTATED_BRANCHES is set: >> >> drivers/scsi/qla2xxx/qla_target.c: In function 'qlt_check_reserve_free_req': >> driver

Re: [PATCH] qla2xxx: avoid maybe_uninitialized warning

2016-03-19 Thread Ewan D. Milne
On Wed, 2016-03-16 at 16:03 +0100, Tomas Henzl wrote: > On 15.3.2016 22:40, Arnd Bergmann wrote: > > The qlt_check_reserve_free_req() function produces an incorrect warning > > when CONFIG_PROFILE_ANNOTATED_BRANCHES is set: > > > > drivers/scsi/qla2xxx/qla_target.c: In function 'qlt_check_reserve_f

Re: [PATCH] qla2xxx: avoid maybe_uninitialized warning

2016-03-19 Thread Himanshu Madhani
On 3/16/16, 5:59 AM, "Arnd Bergmann" wrote: >On Tuesday 15 March 2016 14:49:14 James Bottomley wrote: >> On Tue, 2016-03-15 at 22:40 +0100, Arnd Bergmann wrote: >> > >> > This slightly rearranges the code to move the second if() block >> > into the first one, to avoid the warning while retaini

Re: [PATCH] qla2xxx: avoid maybe_uninitialized warning

2016-03-19 Thread Martin K. Petersen
> "Arnd" == Arnd Bergmann writes: Arnd> The qlt_check_reserve_free_req() function produces an incorrect Arnd> warning when CONFIG_PROFILE_ANNOTATED_BRANCHES is set: Applied to 4.6/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the lin

Re: [PATCH] qla2xxx: avoid maybe_uninitialized warning

2016-03-19 Thread Tomas Henzl
On 15.3.2016 22:40, Arnd Bergmann wrote: > The qlt_check_reserve_free_req() function produces an incorrect warning > when CONFIG_PROFILE_ANNOTATED_BRANCHES is set: > > drivers/scsi/qla2xxx/qla_target.c: In function 'qlt_check_reserve_free_req': > drivers/scsi/qla2xxx/qla_target.c:1887:3: error: 'cn

Re: [PATCH] qla2xxx: avoid maybe_uninitialized warning

2016-03-19 Thread Arnd Bergmann
On Tuesday 15 March 2016 14:49:14 James Bottomley wrote: > On Tue, 2016-03-15 at 22:40 +0100, Arnd Bergmann wrote: > > > > This slightly rearranges the code to move the second if() block > > into the first one, to avoid the warning while retaining the > > behavior of the code. > > I thought our u

Re: [PATCH] qla2xxx: avoid maybe_uninitialized warning

2016-03-18 Thread James Bottomley
On Wed, 2016-03-16 at 14:05 +, Himanshu Madhani wrote: > > On 3/16/16, 5:59 AM, "Arnd Bergmann" wrote: > > > On Tuesday 15 March 2016 14:49:14 James Bottomley wrote: > > > On Tue, 2016-03-15 at 22:40 +0100, Arnd Bergmann wrote: > > > > > > > > This slightly rearranges the code to move the s

Re: [PATCH] qla2xxx: avoid maybe_uninitialized warning

2016-03-15 Thread James Bottomley
On Tue, 2016-03-15 at 22:40 +0100, Arnd Bergmann wrote: > The qlt_check_reserve_free_req() function produces an incorrect > warning when CONFIG_PROFILE_ANNOTATED_BRANCHES is set: > > drivers/scsi/qla2xxx/qla_target.c: In function > 'qlt_check_reserve_free_req': > drivers/scsi/qla2xxx/qla_target.c

[PATCH] qla2xxx: avoid maybe_uninitialized warning

2016-03-15 Thread Arnd Bergmann
The qlt_check_reserve_free_req() function produces an incorrect warning when CONFIG_PROFILE_ANNOTATED_BRANCHES is set: drivers/scsi/qla2xxx/qla_target.c: In function 'qlt_check_reserve_free_req': drivers/scsi/qla2xxx/qla_target.c:1887:3: error: 'cnt_in' may be used uninitialized in this function