Re: [PATCH] qla2xxx: Avoid double completion of abort command

2018-04-09 Thread Martin K. Petersen
Himanshu, >> qla2x00_tmf_sp_done() now deletes the timer that will run >> qla2x00_tmf_iocb_timeout(), but doesn't check whether the timer >> already expired. Check the return value from del_timer() to avoid >> calling complete() a second time. > Looks good. > > Acked-by: Himanshu Madhani Appl

Re: [PATCH] qla2xxx: Avoid double completion of abort command

2018-03-29 Thread Madhani, Himanshu
Hi Ben, > On Mar 20, 2018, at 2:05 PM, Ben Hutchings > wrote: > > qla2x00_tmf_sp_done() now deletes the timer that will run > qla2x00_tmf_iocb_timeout(), but doesn't check whether the timer > already expired. Check the return value from del_timer() to avoid > calling complete() a second time.

[PATCH] qla2xxx: Avoid double completion of abort command

2018-03-20 Thread Ben Hutchings
qla2x00_tmf_sp_done() now deletes the timer that will run qla2x00_tmf_iocb_timeout(), but doesn't check whether the timer already expired. Check the return value from del_timer() to avoid calling complete() a second time. Fixes: 4440e46d5db7 ("[SCSI] qla2xxx: Add IOCB Abort command asynchronous .