RE: [PATCH] mpt fusion: add sysfs attributes to display IOC parameters

2007-07-17 Thread Moore, Eric
On Tuesday, July 17, 2007 3:09 AM, Prakash, Sathya wrote: > Reposting as this patch is not visible in the list yet. > > Resubmitting with the following change suggested by Brian King: > The driver version from scsi_host attribute is redundant as > it is already > available in sysfs: /sys/module

Re: [PATCH] mpt fusion: add sysfs attributes to display IOC parameters

2007-07-17 Thread Prakash, Sathya
Reposting as this patch is not visible in the list yet. Resubmitting with the following change suggested by Brian King: The driver version from scsi_host attribute is redundant as it is already available in sysfs: /sys/module/mptscsih/version. So it is removed from the patch --- New sysfs scsi_

RE: [PATCH] mpt fusion: add sysfs attributes to display IOC parameters

2007-07-13 Thread Moore, Eric
On Thursday, July 12, 2007 10:11 PM, Prakash, Sathya wrote: > > Resubmitting with the following change suggested by Brian King: > The driver version from scsi_host attribute is redundant as > it is already > available in sysfs: /sys/module/mptscsih/version. > So it is removed from the patch

RE: [PATCH] mpt fusion: add sysfs attributes to display IOC parameters

2007-07-12 Thread Moore, Eric
On Thursday, July 12, 2007 8:12 AM, Brian King wrote: > This should be removed from the patch. This information is already > available in sysfs: /sys/module/mptscsih/version > He is correct, the version is there in /sys/module/mptsas/version as well. Please repost the patch with this removed.

Re: [PATCH] mpt fusion: add sysfs attributes to display IOC parameters

2007-07-12 Thread Brian King
Prakash, Sathya wrote: > +static ssize_t > +mptscsih_version_driver_show(struct class_device *cdev, char *buf) > +{ > + return snprintf(buf, PAGE_SIZE, "%s\n", MPT_LINUX_VERSION_COMMON); > +} > +static CLASS_DEVICE_ATTR(version_driver, S_IRUGO, > mptscsih_version_driver_show, NULL); This shou

[PATCH] mpt fusion: add sysfs attributes to display IOC parameters

2007-07-12 Thread Prakash, Sathya
Resubmitting with the changes suggested by Brian King : New sysfs scsi_host attributes are added to provide information about Firmware version, BIOS version, Driver version, MPI version and other product related information signed-off-by: Sathya Prakash <[EMAIL PROTECTED]> --- diff -Naurp b/dri

RE: [PATCH]mpt fusion: add sysfs attributes to display IOC parameters

2007-07-03 Thread Patrick_Boyd
>diff -Naurp b/drivers/message/fusion/mptbase.h a/drivers/message/fusion/mptbase.h >--- b/drivers/message/fusion/mptbase.h 2007-07-02 16:20:46.0 +0530 >+++ a/drivers/message/fusion/mptbase.h 2007-07-03 18:13:28.0 +0530 >@@ -78,6 +78,10 @@ > #define MPT_LINUX_VERSION_COMMON "3.0

Re: [PATCH]mpt fusion: add sysfs attributes to display IOC parameters

2007-07-03 Thread Brian King
Prakash, Sathya wrote: > +static void > +mpt_get_manufacturing_pg_0(MPT_ADAPTER *ioc) > +{ > + > + memcpy(ioc->board_name, pbuf->BoardName, 16); > + memcpy(ioc->board_assembly, pbuf->BoardAssembly, 16); > + memcpy(ioc->board_tracer, pbuf->BoardTracerNumber, 16); Are these guaranteed

[PATCH]mpt fusion: add sysfs attributes to display IOC parameters

2007-07-03 Thread Prakash, Sathya
New sysfs scsi_host attributes are added to provide information about, Firmware version, BIOS version, Driver version, MPI version and other product related information. Signed-off-by: Sathya Prakash <[EMAIL PROTECTED]> --- diff -Naurp b/drivers/message/fusion/mptbase.c a/drivers/message/fusio