Re: [PATCH] lpfc: fixup crash in lpfc_els_unsol_buffer()

2018-10-15 Thread Martin K. Petersen
Ewan, >> +if (!elsiocb->context1) >> +goto dropit; >> + >> if ((cmd & ELS_CMD_MASK) == ELS_CMD_RSCN) { >> cmd &= ELS_CMD_MASK; >> } > > Well, that's fine. But if lpfc_nlp_get() can return NULL, because the > ndlp structure could be going away, perhaps we s

Re: [PATCH] lpfc: fixup crash in lpfc_els_unsol_buffer()

2018-10-09 Thread Ewan D. Milne
On Tue, 2018-10-09 at 08:30 +0200, Hannes Reinecke wrote: > lpfc_nlp_get() in lpfc_els_unsol_buffer() is not running under a > lock, so there is a chance that it might actually fail. But as we > never check the return value we'll get a crash in lpfc_nlp_put() > later on trying to free an invalid bu

Re: [PATCH] lpfc: fixup crash in lpfc_els_unsol_buffer()

2018-10-08 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG N

[PATCH] lpfc: fixup crash in lpfc_els_unsol_buffer()

2018-10-08 Thread Hannes Reinecke
lpfc_nlp_get() in lpfc_els_unsol_buffer() is not running under a lock, so there is a chance that it might actually fail. But as we never check the return value we'll get a crash in lpfc_nlp_put() later on trying to free an invalid buffer. Signed-off-by: Hannes Reinecke --- drivers/scsi/lpfc/lpfc