Re: [PATCH] lpfc: fix oops/BUG in lpfc_sli_ringtxcmpl_put()

2016-11-25 Thread Martin K. Petersen
> "Mauricio" == Mauricio Faria de Oliveira > writes: Mauricio> The BUG_ON() recently introduced in lpfc_sli_ringtxcmpl_put() Mauricio> is hit in the lpfc_els_abort() > lpfc_sli_issue_abort_iotag() Mauricio> > lpfc_sli_abort_iotag_issue() function path [similar names], Mauricio> due to 'p

Re: [PATCH] lpfc: fix oops/BUG in lpfc_sli_ringtxcmpl_put()

2016-11-23 Thread Mauricio Faria de Oliveira
On 11/23/2016 12:12 PM, Johannes Thumshirn wrote: Looks good and sorry for the bug, Reviewed-by: Johannes Thumshirn Thanks for the quick review. Not a problem! This problem turned out to be a good learning exercise. :) -- Mauricio Faria de Oliveira IBM Linux Technology Center -- To unsubscr

Re: [PATCH] lpfc: fix oops/BUG in lpfc_sli_ringtxcmpl_put()

2016-11-23 Thread Johannes Thumshirn
On Wed, Nov 23, 2016 at 10:33:19AM -0200, Mauricio Faria de Oliveira wrote: > The BUG_ON() recently introduced in lpfc_sli_ringtxcmpl_put() > is hit in the lpfc_els_abort() > lpfc_sli_issue_abort_iotag() > > lpfc_sli_abort_iotag_issue() function path [similar names], > due to 'piocb->vport == NULL

Re: [PATCH] lpfc: fix oops/BUG in lpfc_sli_ringtxcmpl_put()

2016-11-23 Thread Mauricio Faria de Oliveira
Due credit; an oversight. On 11/23/2016 10:33 AM, Mauricio Faria de Oliveira wrote: Reported-by: Harsha Thyagaraja Cc: sta...@vger.kernel.org # v4.8 Fixes: 22466da5b4b7 ("lpfc: Fix possible NULL pointer dereference") Signed-off-by: Mauricio Faria de Oliveira -- Mauricio Faria de Oliveira

[PATCH] lpfc: fix oops/BUG in lpfc_sli_ringtxcmpl_put()

2016-11-23 Thread Mauricio Faria de Oliveira
The BUG_ON() recently introduced in lpfc_sli_ringtxcmpl_put() is hit in the lpfc_els_abort() > lpfc_sli_issue_abort_iotag() > lpfc_sli_abort_iotag_issue() function path [similar names], due to 'piocb->vport == NULL': BUG_ON(!piocb || !piocb->vport); This happens because lpfc_sli_abort_io