Re: [PATCH] lpfc: Don't return internal MBXERR_ERROR code from probe function

On Wed, Sep 06, 2017 at 10:47:38AM +0200, Stefano Brivio wrote: > The original submission is archived at > https://marc.info/?l=linux-scsi&m=150392554622786&w=2. Before I cause > any confusion... do you want me to re-submit this with the same > subject? As v2 with a comment? [PATCH RESEND] should

Re: [PATCH] lpfc: Don't return internal MBXERR_ERROR code from probe function

On Wed, 6 Sep 2017 10:42:35 +0200 Johannes Thumshirn wrote: > On Wed, Sep 06, 2017 at 10:32:22AM +0200, Stefano Brivio wrote: > > > > I didn't get feedback about this patch. Is there any issue with the > > submission? > > > > I think it actually fixes a quite critical issue, if initialization >

Re: [PATCH] lpfc: Don't return internal MBXERR_ERROR code from probe function

On Wed, Sep 06, 2017 at 10:32:22AM +0200, Stefano Brivio wrote: > > I didn't get feedback about this patch. Is there any issue with the > submission? > > I think it actually fixes a quite critical issue, if initialization > fails we have crashes on reboot like the one reported below [1], and > sh

Re: [PATCH] lpfc: Don't return internal MBXERR_ERROR code from probe function

Hi, On Mon, 28 Aug 2017 15:05:23 +0200 Stefano Brivio wrote: > Internal error codes happen to be positive, thus the PCI driver > core won't treat them as failure, but we do. This would cause a > crash later on as lpfc_pci_remove_one() is called (e.g. as > shutdown function). > > Fixes: 6d368e53

[PATCH] lpfc: Don't return internal MBXERR_ERROR code from probe function

Internal error codes happen to be positive, thus the PCI driver core won't treat them as failure, but we do. This would cause a crash later on as lpfc_pci_remove_one() is called (e.g. as shutdown function). Fixes: 6d368e532168 ("[SCSI] lpfc 8.3.24: Add resource extent support") Signed-off-by: Stef