Re: [PATCH] libsas: fix lockdep issue with ATA

2007-07-18 Thread Jens Axboe
On Tue, Jul 17 2007, James Bottomley wrote: > On Tue, 2007-07-17 at 09:12 -0500, James Bottomley wrote: > > > process context, no need to save flags here either. > > > > OK, you caught me ... I was just doing the fastest thing I could to get > > lockdep to shut up. By the way, it dumps about 120K

Re: [PATCH] libsas: fix lockdep issue with ATA

2007-07-17 Thread James Bottomley
On Tue, 2007-07-17 at 09:12 -0500, James Bottomley wrote: > > process context, no need to save flags here either. > > OK, you caught me ... I was just doing the fastest thing I could to get > lockdep to shut up. By the way, it dumps about 120KB of logs so it's > fun to get an actual trace of this

Re: [PATCH] libsas: fix lockdep issue with ATA

2007-07-17 Thread James Bottomley
On Tue, 2007-07-17 at 13:29 +0200, Jens Axboe wrote: > On Mon, Jul 16 2007, James Bottomley wrote: > > lockdep noticed that with ATA support the port->dev_list_lock was > > entangled at irq context, so it now needs to become IRQ safe > > > > --- > > This applies against the aic94xx-sas-2.6 tree >

Re: [PATCH] libsas: fix lockdep issue with ATA

2007-07-17 Thread Jens Axboe
On Mon, Jul 16 2007, James Bottomley wrote: > lockdep noticed that with ATA support the port->dev_list_lock was > entangled at irq context, so it now needs to become IRQ safe > > --- > This applies against the aic94xx-sas-2.6 tree > > James > > diff --git a/drivers/scsi/libsas/sas_discover.c >

[PATCH] libsas: fix lockdep issue with ATA

2007-07-16 Thread James Bottomley
lockdep noticed that with ATA support the port->dev_list_lock was entangled at irq context, so it now needs to become IRQ safe --- This applies against the aic94xx-sas-2.6 tree James diff --git a/drivers/scsi/libsas/sas_discover.c b/drivers/scsi/libsas/sas_discover.c index a18c0f6..ce3385c 1006