Re: [PATCH] libsas: Don't issue commands to devices that have been hot-removed.

2008-02-25 Thread Jeff Garzik
(digging through old email) Darrick J. Wong wrote: On Tue, Dec 04, 2007 at 05:48:33PM -0500, Jeff Garzik wrote: As an aside, issues like this really really imply a need to move libsas away from the old libata EH stuff (like brking did with ipr, in patches). Hm... does the new libata EH hand

Re: [PATCH] libsas: Don't issue commands to devices that have been hot-removed.

2007-12-06 Thread Brian King
Darrick J. Wong wrote: > In general, I agree that sas-ata should adopt the new EH. > Unfortunately, I believe the old way of sas-ata configuring ATA ports is > somehow not compatible with the new EH stuff and causes a crash during > the device probe with my patch to move sas-ata to the new EH. If

Re: [PATCH] libsas: Don't issue commands to devices that have been hot-removed.

2007-12-04 Thread Jeff Garzik
Darrick J. Wong wrote: On Tue, Dec 04, 2007 at 05:48:33PM -0500, Jeff Garzik wrote: As an aside, issues like this really really imply a need to move libsas away from the old libata EH stuff (like brking did with ipr, in patches). Hm... does the new libata EH handle the case of "device was unp

Re: [PATCH] libsas: Don't issue commands to devices that have been hot-removed.

2007-12-04 Thread Darrick J. Wong
On Tue, Dec 04, 2007 at 05:48:33PM -0500, Jeff Garzik wrote: > As an aside, issues like this really really imply a need to move libsas > away from the old libata EH stuff (like brking did with ipr, in patches). Hm... does the new libata EH handle the case of "device was unplugged, don't bother t

Re: [PATCH] libsas: Don't issue commands to devices that have been hot-removed.

2007-12-04 Thread Jeff Garzik
Darrick J. Wong wrote: Hrm... does this patch help? You'll get a bunch of ATA/SAS disk errors printed to the screen if you yank the disk, but at least libsas won't get stuck waiting for the cache-flush commands to time out. --- sd will get hung up issuing commands to flush write cache if a SAS d

[PATCH] libsas: Don't issue commands to devices that have been hot-removed.

2007-12-04 Thread Darrick J. Wong
Hrm... does this patch help? You'll get a bunch of ATA/SAS disk errors printed to the screen if you yank the disk, but at least libsas won't get stuck waiting for the cache-flush commands to time out. --- sd will get hung up issuing commands to flush write cache if a SAS device is unplugged withou