Re: [PATCH] libata-scsi: fix D_SENSE bit relection in control mode page

2016-07-12 Thread Tejun Heo
On Wed, Jul 13, 2016 at 01:45:21AM +0800, Tom Yan wrote: > Btw, why is the MODE SELECT function called ata_mselect_control() > while the MODE SENSE function is called ata_msense_ctl_mode()? > Shouldn't we make their names consistent? Sure, please go ahead. Thanks. -- tejun -- To unsubscribe fro

Re: [PATCH] libata-scsi: fix D_SENSE bit relection in control mode page

2016-07-12 Thread Tom Yan
Btw, why is the MODE SELECT function called ata_mselect_control() while the MODE SENSE function is called ata_msense_ctl_mode()? Shouldn't we make their names consistent? On 13 July 2016 at 01:35, wrote: > From: Tom Yan > > The bit should always be set to 1 when the requested version of > page

[PATCH] libata-scsi: fix D_SENSE bit relection in control mode page

2016-07-12 Thread tom . ty89
From: Tom Yan The bit should always be set to 1 when the requested version of page is "changeable" because we've made it so in ata_mselect_control(). Also, it should always be set to 1 if ATA_DFLAG_D_SENSE is set (when the requested version of page is "current" or "default"). Signed-off-by: Tom