Re: [PATCH] git scsi misc include fix

2007-10-15 Thread Paul Jackson
James wrote: > In that case, the correct fix > is actually to move the scatterlist include from scsi_error.c (where the > scatterlist was originally used locally) into scsi_eh.h, like this. I suspect you're correct, yes. -- I won't rest till it's the best ...

Re: [PATCH] git scsi misc include fix

2007-10-15 Thread James Bottomley
On Mon, 2007-10-15 at 17:08 -0700, Paul Jackson wrote: > James wrote: > > The requirement for struct scatterlist is the same > > before and after the gid scsi-misc patch. > > Not so. The git-scsi-misc.patch in 2.6.23-mm1 clearly adds the line: > > struct scatterlist sense_sgl; > > as part

Re: [PATCH] git scsi misc include fix

2007-10-15 Thread Paul Jackson
James wrote: > The requirement for struct scatterlist is the same > before and after the gid scsi-misc patch. Not so. The git-scsi-misc.patch in 2.6.23-mm1 clearly adds the line: struct scatterlist sense_sgl; as part of the added struct scsi_eh_save in scsi/scsi_eh.h. This bit me while I

Re: [PATCH] git scsi misc include fix

2007-10-15 Thread Andrew Morton
On Mon, 15 Oct 2007 19:35:30 -0400 James Bottomley <[EMAIL PROTECTED]> wrote: > On Sat, 2007-10-13 at 22:35 -0700, Paul Jackson wrote: > > From: Paul Jackson <[EMAIL PROTECTED]> > > > > The added line in scsi_eh.h: > > struct scatterlist sense_sgl; > > fails to compile, with the error: > >

Re: [PATCH] git scsi misc include fix

2007-10-15 Thread James Bottomley
On Sat, 2007-10-13 at 22:35 -0700, Paul Jackson wrote: > From: Paul Jackson <[EMAIL PROTECTED]> > > The added line in scsi_eh.h: > struct scatterlist sense_sgl; > fails to compile, with the error: > field 'sense_sgl' has incomplete type > unless scatterlist.h happens to be included > s