Re: [PATCH] gdth: convert to PCI hotplug API

2008-02-15 Thread Matthew Wilcox
On Fri, Feb 15, 2008 at 10:44:52AM -0500, Jeff Garzik wrote: > I kept those array for one reason: you need it to preserve the existing > in-driver PCI device sort. Just get rid of it. I got rid of it for sym2 during 2.5 and very few people have complained. -- Intel are signing my paycheques .

Re: [PATCH] gdth: convert to PCI hotplug API

2008-02-15 Thread Jeff Garzik
James Bottomley wrote: diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c index c825239..1b53e92 100644 --- a/drivers/scsi/gdth.c +++ b/drivers/scsi/gdth.c @@ -595,85 +595,107 @@ static int __init gdth_search_isa(ulong32 bios_adr) #endif /* CONFIG_ISA */ #ifdef CONFIG_PCI -static void gd

Re: [PATCH] gdth: convert to PCI hotplug API

2008-02-15 Thread Jan Engelhardt
On Feb 13 2008 13:07, Boaz Harrosh wrote: >+static struct pci_device_id gdthtable[] __devinitdata = { >+ { PCI_VDEVICE(VORTEX, PCI_ANY_ID) }, >+ { PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_SRC) }, >+ { PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_SRC_XSCALE) }, >+ { } /* terminate l

Re: [PATCH] gdth: convert to PCI hotplug API

2008-02-14 Thread Jeff Garzik
Comments noted for my next round of revisions (its a low priority, so definitely not this week). Good spotting, thanks! Jeff - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kern

Re: [PATCH] gdth: convert to PCI hotplug API

2008-02-14 Thread Jeff Garzik
Boaz Harrosh wrote: do you intend this to be pushed into 2.6.25-rcx or this is already for 2.6.26? Should we put this in -mm tree for testing? Not intended for 2.6.25. I just wanted to get this "in process" somewhere, and keep this issue moving. I would definitely prefer to have this teste

Re: [PATCH] gdth: convert to PCI hotplug API

2008-02-14 Thread James Bottomley
On Tue, 2008-02-12 at 18:49 -0500, Jeff Garzik wrote: > Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> Nice work, thanks. This is PCI only I take it. ISA and EISA look like they'll be a tad more troublesome, so PCI only is fine. > --- > drivers/scsi/gdth.c | 143 > +++

Re: [PATCH] gdth: convert to PCI hotplug API

2008-02-13 Thread Boaz Harrosh
ate: Wed, 13 Feb 2008 13:01:16 +0200 Subject: [PATCH] gdth: convert to PCI hotplug API Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]> --- drivers/scsi/gdth.c | 143 ++ 1 files changed,

Re: [PATCH] gdth: convert to PCI hotplug API

2008-02-13 Thread Jiri Slaby
On 02/13/2008 12:49 AM, Jeff Garzik wrote: Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> --- drivers/scsi/gdth.c | 143 +++- 1 file changed, 86 insertions(+), 57 deletions(-) 06196f50915da97bb897495863f9f084d785c1e4 diff --git a/drivers/scsi/gdt

[PATCH] gdth: convert to PCI hotplug API

2008-02-12 Thread Jeff Garzik
Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> --- drivers/scsi/gdth.c | 143 +++- 1 file changed, 86 insertions(+), 57 deletions(-) 06196f50915da97bb897495863f9f084d785c1e4 diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c index c825239..1b5