Re: [PATCH] fixup "qla2xxx: Optimize NPIV tear down process"

2019-10-02 Thread Bart Van Assche
On 10/2/19 8:25 AM, Martin Wilck wrote: > On Wed, 2019-10-02 at 08:17 -0700, Bart Van Assche wrote: >> >> Both loops check the loop termination condition twice. Has it been >> considered to write these loops such that the loop termination >> condition >> is only tested once, e.g. using the followin

Re: [PATCH] fixup "qla2xxx: Optimize NPIV tear down process"

2019-10-02 Thread Martin Wilck
On Wed, 2019-10-02 at 08:17 -0700, Bart Van Assche wrote: > > Both loops check the loop termination condition twice. Has it been > considered to write these loops such that the loop termination > condition > is only tested once, e.g. using the following pattern? > > for (i = 0; i < 10; i++) >

Re: [PATCH] fixup "qla2xxx: Optimize NPIV tear down process"

2019-10-02 Thread Bart Van Assche
On 10/2/19 7:35 AM, Martin Wilck wrote: > From: Martin Wilck > > Hello Martin, > > this patch fixes two issues in patch 02/14 in Himanshu's latest > qla2xxx series ("qla2xxx: Bug fixes for the driver") from > Sept. 12th, which you applied onto 5.4/scsi-fixes already. > See https://marc.info/?l=l

[PATCH] fixup "qla2xxx: Optimize NPIV tear down process"

2019-10-02 Thread Martin Wilck
From: Martin Wilck Hello Martin, this patch fixes two issues in patch 02/14 in Himanshu's latest qla2xxx series ("qla2xxx: Bug fixes for the driver") from Sept. 12th, which you applied onto 5.4/scsi-fixes already. See https://marc.info/?l=linux-scsi&m=156951704106671&w=2 I'm assuming that Himan