Re: [PATCH] fill in scsi_host_template module owner

2007-05-07 Thread Mike Christie
Olaf Kirch wrote: > I recently ran into an oops that happens because you > can shut down all of iSCSI even though you still have > iSCSI targets mounted. It turned out that iscsi's > scsi_host_template missed a THIS_MODULE, so > reference counting wasn't done properly. Brief > inspection showed tha

Re: [PATCH] fill in scsi_host_template module owner

2007-05-02 Thread Christoph Hellwig
[please don't remove me from the To: or Cc: line, please - I tend to read personal email much faster than list traffic, and it's the normal policy for most kernel development lists these days] On Wed, May 02, 2007 at 10:07:43AM +0200, Olaf Kirch wrote: > On Monday 30 April 2007 18:02, Christoph He

Re: [PATCH] fill in scsi_host_template module owner

2007-05-02 Thread Olaf Kirch
On Monday 30 April 2007 18:02, Christoph Hellwig wrote: > - a driver should handle hot unplugs proper, even if THIS_MODULE >is set this can happen if the hardware just goes away. In the case of the iscsi bug I looked at, it wasn't so much the hardware going away, it was the rmmod that was kin

Re: [PATCH] fill in scsi_host_template module owner

2007-04-30 Thread Christoph Hellwig
On Mon, Apr 30, 2007 at 04:53:55PM +0200, Olaf Kirch wrote: > I recently ran into an oops that happens because you > can shut down all of iSCSI even though you still have > iSCSI targets mounted. It turned out that iscsi's > scsi_host_template missed a THIS_MODULE, so > reference counting wasn't do

[PATCH] fill in scsi_host_template module owner

2007-04-30 Thread Olaf Kirch
I recently ran into an oops that happens because you can shut down all of iSCSI even though you still have iSCSI targets mounted. It turned out that iscsi's scsi_host_template missed a THIS_MODULE, so reference counting wasn't done properly. Brief inspection showed that this seems to be a rather wi