Re: [PATCH] block/null_blk: Fix completion processing from LIFO to FIFO

2014-02-06 Thread Jens Axboe
On Thu, Feb 06 2014, Christoph Hellwig wrote: > On Thu, Feb 06, 2014 at 06:33:17PM +0200, Shlomo Pongratz wrote: > > The completion queue is implemented using lockless list. > > > > The llist_add is adds the events to the list head which is a push operation. > > The processing of the completion el

Re: [PATCH] block/null_blk: Fix completion processing from LIFO to FIFO

2014-02-06 Thread Christoph Hellwig
On Thu, Feb 06, 2014 at 06:33:17PM +0200, Shlomo Pongratz wrote: > The completion queue is implemented using lockless list. > > The llist_add is adds the events to the list head which is a push operation. > The processing of the completion elements is done by disconnecting all the > pushed element

[PATCH] block/null_blk: Fix completion processing from LIFO to FIFO

2014-02-06 Thread Shlomo Pongratz
The completion queue is implemented using lockless list. The llist_add is adds the events to the list head which is a push operation. The processing of the completion elements is done by disconnecting all the pushed elements and iterating over the disconnected list. The problem is that the process