Re: [PATCH] blk request timeout minor fixes...

2007-12-05 Thread malahal
Jens Axboe [EMAIL PROTECTED] wrote: > ->timeout isn't used very much, so should not be too much work to > console the two. > > If you see any specific obstacles, do list them! I believe it is used in blk_add_timer() which may be called: 1) First time sending the command to LLDs No problem. It

Re: [PATCH] blk request timeout minor fixes...

2007-12-05 Thread Jens Axboe
On Wed, Dec 05 2007, [EMAIL PROTECTED] wrote: > Jens Axboe [EMAIL PROTECTED] wrote: > > > This one fixes the 4-byte hole. Thank you very much. > > > > That's all fine, but now we have two fields doing essentially the same > > thing. Care to cleanup the ->timeout usage so we can get by with using >

Re: [PATCH] blk request timeout minor fixes...

2007-12-05 Thread malahal
Jens Axboe [EMAIL PROTECTED] wrote: > > This one fixes the 4-byte hole. Thank you very much. > > That's all fine, but now we have two fields doing essentially the same > thing. Care to cleanup the ->timeout usage so we can get by with using > just that field? I added another field because I could

Re: [PATCH] blk request timeout minor fixes...

2007-12-04 Thread Jens Axboe
On Mon, Dec 03 2007, [EMAIL PROTECTED] wrote: > Matthew Wilcox [EMAIL PROTECTED] wrote: > > On Sun, Dec 02, 2007 at 05:53:30PM -0800, [EMAIL PROTECTED] wrote: > > Can I suggest running 'pahole' over this when compiled on 64-bit? > > You've just introduced a 4-byte hole. > > This one fixes the 4-by

Re: [PATCH] blk request timeout minor fixes...

2007-12-03 Thread malahal
Matthew Wilcox [EMAIL PROTECTED] wrote: > On Sun, Dec 02, 2007 at 05:53:30PM -0800, [EMAIL PROTECTED] wrote: > Can I suggest running 'pahole' over this when compiled on 64-bit? > You've just introduced a 4-byte hole. This one fixes the 4-byte hole. Thank you very much. diff --git a/block/ll_rw_b

Re: [PATCH] blk request timeout minor fixes...

2007-12-02 Thread Matthew Wilcox
On Sun, Dec 02, 2007 at 05:53:30PM -0800, [EMAIL PROTECTED] wrote: > diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h > index 917fe86..e495d61 100644 > --- a/include/linux/blkdev.h > +++ b/include/linux/blkdev.h > @@ -295,7 +295,8 @@ struct request { > void *data; > void *se

[PATCH] blk request timeout minor fixes...

2007-12-02 Thread malahal
Adds deadline field to preserve the timeout on retries. Calculates next timeout for mod_timer correctly and uses an extra symbol, next_set, as zero could be a valid 'next' value. Based off of timeout branch from Jens git repo. Signed-off-by: Malahal Naineni <[EMAIL PROTECTED]> diff --git a/block