Re: [PATCH] aic79xx: fix misuse of static variables

2014-04-14 Thread Mathias Krause
On 30 March 2014 15:30, Mathias Krause wrote: > The format strings for various printk()s make use of a temporary > variable that is declared 'static'. This is probably not intended, > so fix those. > > Found in the PaX patch, written by the PaX Team. > > Cc: PaX Team > Cc: Hannes Reinecke > Cc:

Re: [PATCH] aic79xx: fix misuse of static variables

2014-04-01 Thread Mathias Krause
On 1 April 2014 16:10, James Bottomley wrote: > On Sun, 2014-03-30 at 15:30 +0200, Mathias Krause wrote: >> The format strings for various printk()s make use of a temporary >> variable that is declared 'static'. This is probably not intended, >> so fix those. > > Actually, it was intended. It was

Re: [PATCH] aic79xx: fix misuse of static variables

2014-04-01 Thread James Bottomley
On Sun, 2014-03-30 at 15:30 +0200, Mathias Krause wrote: > The format strings for various printk()s make use of a temporary > variable that is declared 'static'. This is probably not intended, > so fix those. Actually, it was intended. It was to work around an assignment to const gcc bug: some ve

Re: [PATCH] aic79xx: fix misuse of static variables

2014-03-30 Thread Hannes Reinecke
On 03/30/2014 03:30 PM, Mathias Krause wrote: > The format strings for various printk()s make use of a temporary > variable that is declared 'static'. This is probably not intended, > so fix those. > > Found in the PaX patch, written by the PaX Team. > > Cc: PaX Team > Cc: Hannes Reinecke > Cc:

[PATCH] aic79xx: fix misuse of static variables

2014-03-30 Thread Mathias Krause
The format strings for various printk()s make use of a temporary variable that is declared 'static'. This is probably not intended, so fix those. Found in the PaX patch, written by the PaX Team. Cc: PaX Team Cc: Hannes Reinecke Cc: "James E.J. Bottomley" Signed-off-by: Mathias Krause --- Rem