Re: [PATCH] Use a more selective error recovery strategy based on device capabilities

2013-02-15 Thread Jeremy Linton
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2/14/2013 5:42 PM, Elliott, Robert (Server Storage) wrote: > Each logical unit is independent and is allowed to be different. I was actually just thinking about the target reset and IT reset flags. Two flags which affect the I_T not the I_

Re: [PATCH] Use a more selective error recovery strategy based on device capabilities

2013-02-14 Thread Hannes Reinecke
On 02/14/2013 09:57 PM, Jeremy Linton wrote: On 2/13/2013 8:43 PM, Michael Christie wrote: For the case where report supported TMFs is not supported can we just have the >> LLD return some new return code from the eh callback when it gets FUNCTION_REJECTED. >> scsi-ml would then clear the eh_*_

RE: [PATCH] Use a more selective error recovery strategy based on device capabilities

2013-02-14 Thread Elliott, Robert (Server Storage)
; Subject: Re: [PATCH] Use a more selective error recovery strategy based on > device capabilities > > On 2/13/2013 8:43 PM, Michael Christie wrote: > > For the case where report supported TMFs is not supported can we just have > the LLD return some new return code from the eh ca

Re: [PATCH] Use a more selective error recovery strategy based on device capabilities

2013-02-14 Thread Jeremy Linton
On 2/13/2013 8:43 PM, Michael Christie wrote: > For the case where report supported TMFs is not supported can we just have > the LLD return some new return code from the eh callback when it gets > FUNCTION_REJECTED. scsi-ml would then clear the eh_*_ok bit, so at least it > would not be called a

Re: [PATCH] Use a more selective error recovery strategy based on device capabilities

2013-02-13 Thread Michael Christie
On Feb 13, 2013, at 9:46 AM, Jeremy Linton wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 2/13/2013 7:06 AM, Hannes Reinecke wrote: > >> But unfortunately it failed the reality check; of my zoo of storage arrays >> only NetApp OnTap 8.X and HP P2000 supports the REPORT SUPPORT

Re: [PATCH] Use a more selective error recovery strategy based on device capabilities

2013-02-13 Thread Jeremy Linton
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2/13/2013 7:06 AM, Hannes Reinecke wrote: > But unfortunately it failed the reality check; of my zoo of storage arrays > only NetApp OnTap 8.X and HP P2000 supports the REPORT SUPPORTED TASK > MANAGEMENT FUNCTIONS command. None of the others (HP EV

Re: [PATCH] Use a more selective error recovery strategy based on device capabilities

2013-02-13 Thread Hannes Reinecke
On 02/12/2013 07:19 PM, Jeremy Linton wrote: Ideally, Linux should not be sending task management commands to devices that don't support the given task mgmt operation. This patch uses the REPORT SUPPORTED TASK MGMT FUNCTIONS command to enable or disable error recovery paths for a given device. F

Re: [PATCH] Use a more selective error recovery strategy based on device capabilities

2013-02-12 Thread Jeremy Linton
On 2/12/2013 2:57 PM, Elliott, Robert (Server Storage) wrote: > Ideally the device driver for the SCSI initiator port would report those > attributes, and higher level code would combine them with support > information from the device server (REPORT SUPPORTED TMF command, REPORT > SUPPORTED OPCODES

RE: [PATCH] Use a more selective error recovery strategy based on device capabilities

2013-02-12 Thread Elliott, Robert (Server Storage)
esday, 12 February, 2013 12:20 PM > To: Linux Scsi > Subject: [PATCH] Use a more selective error recovery strategy based on device > capabilities > > Ideally, Linux should not be sending task management commands to devices > that > don't support the given task mgmt operat

[PATCH] Use a more selective error recovery strategy based on device capabilities

2013-02-12 Thread Jeremy Linton
Ideally, Linux should not be sending task management commands to devices that don't support the given task mgmt operation. This patch uses the REPORT SUPPORTED TASK MGMT FUNCTIONS command to enable or disable error recovery paths for a given device. For older devices, we make an educated guess abo