Re: [PATCH] SCSI core: Fix WRITE SAME handling

2017-01-26 Thread h...@lst.de
On Wed, Jan 25, 2017 at 10:44:41PM +, Bart Van Assche wrote: > On Wed, 2017-01-25 at 11:37 +0100, Christoph Hellwig wrote: > > > Fixes: f80de881d8df ("sd: remove __data_len hack for WRITE SAME") > > > > I think the better fix is to simply revert this commit. > > Hello Christoph, > > Do you m

Re: [PATCH] SCSI core: Fix WRITE SAME handling

2017-01-25 Thread Bart Van Assche
On Wed, 2017-01-25 at 11:37 +0100, Christoph Hellwig wrote: > > Fixes: f80de881d8df ("sd: remove __data_len hack for WRITE SAME") > > I think the better fix is to simply revert this commit. Hello Christoph, Do you mean reverting commit f80de881d8df only for kernel release v4.10 or also for futur

Re: [PATCH] SCSI core: Fix WRITE SAME handling

2017-01-25 Thread Christoph Hellwig
Hi Bart, thanks for the report. > Fixes: f80de881d8df ("sd: remove __data_len hack for WRITE SAME") I think the better fix is to simply revert this commit. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordom

[PATCH] SCSI core: Fix WRITE SAME handling

2017-01-24 Thread Bart Van Assche
This patch avoids that sending a WRITE SAME command to the iSCSI initiator triggers the following: BUG: unable to handle kernel NULL pointer dereference at 0014 TARGET_CORE[iSCSI]: Expected Transfer Length: 260096 does not match SCSI CDB Length: 512 for SAM Opcode: 0x41 IP: iscsi_tcp_