Re: [PATCH] SCSI: remove DRIVER_ATTR() usage

2017-07-24 Thread Martin K. Petersen
Greg, > It's better to use the DRIVER_ATTR_RW() and DRIVER_ATTR_RO() macros to > explicitly show that this is a read/write or read/only sysfs file. So > convert the remaining SCSI drivers that use the old style to use the > newer macros. Applied to 4.14/scsi-queue. Thank you! -- Martin K. Pet

Re: [PATCH] SCSI: remove DRIVER_ATTR() usage

2017-07-19 Thread Bart Van Assche
On Wed, 2017-07-19 at 14:50 +0200, Greg KH wrote: > From: Greg Kroah-Hartman > > It's better to use the DRIVER_ATTR_RW() and DRIVER_ATTR_RO() macros to > explicitly show that this is a read/write or read/only sysfs file. So > convert the remaining SCSI drivers that use the old style to use the >

[PATCH] SCSI: remove DRIVER_ATTR() usage

2017-07-19 Thread Greg KH
From: Greg Kroah-Hartman It's better to use the DRIVER_ATTR_RW() and DRIVER_ATTR_RO() macros to explicitly show that this is a read/write or read/only sysfs file. So convert the remaining SCSI drivers that use the old style to use the newer macros. Bonus is that this removes some checkpatch.pl