Re: [PATCH] SCSI: Make error printing more user friendly

2007-02-19 Thread Martin K. Petersen
> "James" == James Bottomley <[EMAIL PROTECTED]> writes: James> I think we should be going through dev_printk as the primary, James> particularly as doing this would make the output of sdev_printk James> different from scmd_printk. How about Fine with me except we're now back to having incon

Re: [PATCH] SCSI: Make error printing more user friendly

2007-02-16 Thread James Bottomley
I think all of this is OK except this piece On Fri, 2007-02-09 at 03:03 -0500, Martin K. Petersen wrote: > #define scmd_printk(prefix, scmd, fmt, a...) \ > + (&(scmd)->request->rq_disk) ? \ > +printk(prefix "%s: " fmt, (char *) > &(scmd)->request->rq_disk->disk_name, ##a) :

[PATCH] SCSI: Make error printing more user friendly

2007-02-09 Thread Martin K. Petersen
This patch makes SCSI error printing more user friendly by: 1. Replacing the (currently unused) functions scsi_print_hostbyte() and scsi_print_driverbyte() with scsi_print_result() 2. Replacing the dreaded "SCSI error: return code" in scsi_io_completion with a call to scsi_print_result()