On Fri, 2005-09-09 at 16:22 +0200, Christoph Hellwig wrote:
> I think this submission is ready for 2.6.14, but additional comments are
> of course very welcome.
Actually, you missed a prototype change for the class functions.
James
diff --git a/drivers/scsi/scsi_transport_sas.c
b/drivers/scsi/s
On Fri, Sep 09, 2005 at 09:35:36AM -0500, James Bottomley wrote:
> On Fri, 2005-09-09 at 16:22 +0200, Christoph Hellwig wrote:
> > In addition to the basic SCSI core objects this transport class introduces
> > two additional intermediate objects: The SAS PHY as represented by struct
> > sas_phy de
On Fri, 2005-09-09 at 16:22 +0200, Christoph Hellwig wrote:
> In addition to the basic SCSI core objects this transport class introduces
> two additional intermediate objects: The SAS PHY as represented by struct
> sas_phy defines an "outgoing" PHY on a SAS HBA or Expander, and the SAS
> remote PH
The SAS transport class contains common code to deal with SAS HBAs, an
aproximated representation of SAS topologies in the driver model,
and various sysfs attributes to expose these topologies and managment
interfaces to userspace.
In addition to the basic SCSI core objects this transport class in
James Smart wrote:
I'll point out, but not delve into - that you've avoided the target
id bindings again, thus forcing the lldd's/adapters to maintain tables
of port#/SASaddr to target id (if they care, and I believe enterprise
storage will care!). I can understand if you're going to eventually
> > So this is odd... grandparent ? why pass in port # (you should
> > know the object already)? why is channel skipping over / not
> > associated with the local port ?
>
> I didn't really want to need the drivers to keep around arrays
> or lists of sas_port objects.
They're going to have to if
On Tue, Sep 06, 2005 at 09:40:43AM -0400, [EMAIL PROTECTED] wrote:
> > + parent = sas_port_lookup(grandparent, port);
> > + if (!parent)
> > + return NULL;
>
> So this is odd... grandparent ? why pass in port # (you should
> know the object already)? why is channel skipping over /
> +/**
> + * sas_rport_alloc -- allocates and initialize a SAS
> remote port structure
> + * @grandparent: Parent device of the parent SAS port
> + * @port:Port number of the parent SAS port
> + * @channel: SCSI Core channel number
> + * @id: SCSI Co
New version of the SAS transport class. This now introduces the concept
of remote ports as suggested by James Smart. Also ports can be layer
ontop of remote ports in addition to scsi hosts to support extenders,
although that functionality is rather theoretical as I didn't manage to
update the Fus
9 matches
Mail list logo
