Re: [PATCH] Revert "scsi-mq: Always unprepare before requeuing a request"

2017-08-18 Thread Michael Ellerman
Bart Van Assche writes: > On Wed, 2017-08-16 at 22:51 -0400, Martin K. Petersen wrote: >> > When I checked earlier today the ipr patch was not yet in linux-next >> >> That's weird. They were both committed two weeks ago. >> >> They appear to be in there now, though: >> >> https://git.kernel.or

Re: [PATCH] Revert "scsi-mq: Always unprepare before requeuing a request"

2017-08-17 Thread Martin K. Petersen
Brian, > They are separate issues. The ipr fix that is now upstream is for a > locking issue in ipr. The boot hang issue is a separate issue. I can > reproduce the boot hang on a system with my ipr patch. I've confirmed > it goes away when reverting Bart's patch but it makes no sense as of > yet

Re: [PATCH] Revert "scsi-mq: Always unprepare before requeuing a request"

2017-08-17 Thread Brian King
On 08/17/2017 11:45 AM, Martin K. Petersen wrote: > > Bart, > >> I think this means that the ipr fix went upstream before it ended up in >> linux-next. > > OK. > > Brian: Please make sure you test with your ipr change in place as well > as Bart's patch. And then report back. They are separate

Re: [PATCH] Revert "scsi-mq: Always unprepare before requeuing a request"

2017-08-17 Thread Martin K. Petersen
Bart, > I think this means that the ipr fix went upstream before it ended up in > linux-next. OK. Brian: Please make sure you test with your ipr change in place as well as Bart's patch. And then report back. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] Revert "scsi-mq: Always unprepare before requeuing a request"

2017-08-17 Thread Bart Van Assche
On Wed, 2017-08-16 at 22:51 -0400, Martin K. Petersen wrote: > > When I checked earlier today the ipr patch was not yet in linux-next > > That's weird. They were both committed two weeks ago. > > They appear to be in there now, though: > > https://git.kernel.org/pub/scm/linux/kernel/git/next/lin

Re: [PATCH] Revert "scsi-mq: Always unprepare before requeuing a request"

2017-08-16 Thread Martin K. Petersen
Bart, > When I checked earlier today the ipr patch was not yet in linux-next That's weird. They were both committed two weeks ago. They appear to be in there now, though: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/drivers/scsi?ofs=50 -- Martin K. Petersen Or

Re: [PATCH] Revert "scsi-mq: Always unprepare before requeuing a request"

2017-08-16 Thread Bart Van Assche
On Wed, 2017-08-16 at 22:00 -0400, Martin K. Petersen wrote: > Bart, > > > I'm 99% sure there is nothing wrong with my patch but that my patch > > uncovered a bug in the ipr driver (drivers/scsi/ipr). See also > > "WARNING: CPU: 15 PID: 0 at block/blk-mq.c: > > __blk_mq_run_hw_queue+0x1d8/0x1f

Re: [PATCH] Revert "scsi-mq: Always unprepare before requeuing a request"

2017-08-16 Thread Martin K. Petersen
Bart, > I'm 99% sure there is nothing wrong with my patch but that my patch > uncovered a bug in the ipr driver (drivers/scsi/ipr). See also > "WARNING: CPU: 15 PID: 0 at block/blk-mq.c: > __blk_mq_run_hw_queue+0x1d8/0x1f0F" > (https://marc.info/?l=linux-block&m=150290686719644). But I alrea

Re: [PATCH] Revert "scsi-mq: Always unprepare before requeuing a request"

2017-08-16 Thread Bart Van Assche
On Wed, 2017-08-16 at 20:52 -0400, Martin K. Petersen wrote: > Damien, > > > Actually, we can keep that commit as it makes the sq case cleaner > > anyway. But we need something else to prevent deadlock in the mq > > case... > > OK, put it back. > > Please send a lockout patch. We can always zap

Re: [PATCH] Revert "scsi-mq: Always unprepare before requeuing a request"

2017-08-16 Thread Martin K. Petersen
Damien, > Actually, we can keep that commit as it makes the sq case cleaner > anyway. But we need something else to prevent deadlock in the mq > case... OK, put it back. Please send a lockout patch. We can always zap it if we find out what went wrong with Bart's patch and queue a "real" fix. -

Re: [PATCH] Revert "scsi-mq: Always unprepare before requeuing a request"

2017-08-16 Thread Damien Le Moal
Martin, On 8/17/17 09:41, Damien Le Moal wrote: > Martin, > > On 8/17/17 09:11, Martin K. Petersen wrote: >> >> Bart, >> >>> For an unknown reason this patch causes the boot process to hang on >>> PowerPC systems: >> >> OK, dropped it from fixes for now. >> >> Thanks! > > It means that commit 70

Re: [PATCH] Revert "scsi-mq: Always unprepare before requeuing a request"

2017-08-16 Thread Martin K. Petersen
Damien, > It means that commit 70e42fd02c46e2aa9ab07b766d418637e3a51de7 "scsi: > sd_zbc: Write unlock zone from sd_uninit_cmnd()" will need to be > reverted too as it will not solve the potential deadlock anymore. Bart's > patch was needed for it to work. OK, also dropped. > (2) may actually be

Re: [PATCH] Revert "scsi-mq: Always unprepare before requeuing a request"

2017-08-16 Thread Damien Le Moal
Martin, On 8/17/17 09:11, Martin K. Petersen wrote: > > Bart, > >> For an unknown reason this patch causes the boot process to hang on >> PowerPC systems: > > OK, dropped it from fixes for now. > > Thanks! It means that commit 70e42fd02c46e2aa9ab07b766d418637e3a51de7 "scsi: sd_zbc: Write unlo

Re: [PATCH] Revert "scsi-mq: Always unprepare before requeuing a request"

2017-08-16 Thread Martin K. Petersen
Bart, > For an unknown reason this patch causes the boot process to hang on > PowerPC systems: OK, dropped it from fixes for now. Thanks! -- Martin K. Petersen Oracle Linux Engineering

[PATCH] Revert "scsi-mq: Always unprepare before requeuing a request"

2017-08-16 Thread Bart Van Assche
For an unknown reason this patch causes the boot process to hang on PowerPC systems: sd 0:2:0:0: [sda] 272646144 512-byte logical blocks: (140 GB/130 GiB) sd 0:2:0:0: [sda] 4096-byte physical blocks sd 0:2:0:0: [sda] Write Protect is off INFO: task swapper/5:1 blocked for more than 120 seconds.