Re: [PATCH] Fix selection of command serial numbers and pids

2005-03-06 Thread Matthew Wilcox
On Thu, Mar 03, 2005 at 10:31:19AM +0200, James Bottomley wrote: > On Sun, 2005-02-06 at 20:51 +0100, Andi Kleen wrote: > > This patch fixes one of Christroph's fixme comments in the SCSI midlayer. > > Could you reroll this against scsi-misc-2.6, please? I get mainly > rejections when I try to ap

Re: [PATCH] Fix selection of command serial numbers and pids

2005-03-06 Thread James Bottomley
On Sun, 2005-02-06 at 20:51 +0100, Andi Kleen wrote: > This patch fixes one of Christroph's fixme comments in the SCSI midlayer. Could you reroll this against scsi-misc-2.6, please? I get mainly rejections when I try to apply it. Thanks, James - To unsubscribe from this list: send the line "u

Re: [PATCH] Fix selection of command serial numbers and pids

2005-02-06 Thread Matthew Wilcox
On Sun, Feb 06, 2005 at 08:41:23PM +0100, Andi Kleen wrote: > This patch fixes one of Christroph's fixme comments in the SCSI midlayer. If we're going to start fixing problems that Christoph noted, this one seems obvious to me: The static device_request_lock doesn't protect anything; remove it.

Re: [PATCH] Fix selection of command serial numbers and pids

2005-02-06 Thread Andi Kleen
[...] Willy pointed out a bogus hunk in the original patch that should not have been there. Retransmit with that removed. Also mark scsi_cmnd_serial inline. This patch fixes one of Christroph's fixme comments in the SCSI midlayer. The selection of the serial number and pid for commands was don

[PATCH] Fix selection of command serial numbers and pids

2005-02-06 Thread Andi Kleen
This patch fixes one of Christroph's fixme comments in the SCSI midlayer. The selection of the serial number and pid for commands was done by a global variable and not SMP safe. The race was not very serious because it was only used for error handling, but it's still better to fix it. I audited