Re: [PATCH] Fix for hang of Ordered task in TCM

2016-05-23 Thread Nicholas A. Bellinger
Hi Bryant, On Mon, 2016-05-23 at 19:17 -0400, Bryant G Ly wrote: > Quoting "Nicholas A. Bellinger" : > > > > > > So AFAICT for delayed commands, the above patch ends up skipping these > > three checks subsequently when doing __target_execute_cmd() directly > > from target_restart_delayed_cmds(),

Re: [PATCH] Fix for hang of Ordered task in TCM

2016-05-23 Thread Nicholas A. Bellinger
On Wed, 2016-05-18 at 14:35 -0500, Michael Cyr wrote: > On 5/18/16 12:53 AM, Nicholas A. Bellinger wrote: > > Hi Michael, > > > > On Fri, 2016-05-13 at 17:15 -0500, Michael Cyr wrote: > >> If a command with a Simple task attribute is failed due to a Unit > >> Attention, then a subsequent command wi

Re: [PATCH] Fix for hang of Ordered task in TCM

2016-05-23 Thread Bryant G Ly
Quoting "Nicholas A. Bellinger" : So AFAICT for delayed commands, the above patch ends up skipping these three checks subsequently when doing __target_execute_cmd() directly from target_restart_delayed_cmds(), no..? After pondering this some more, what about moving these checks into __target

Re: [PATCH] Fix for hang of Ordered task in TCM

2016-05-18 Thread Michael Cyr
On 5/18/16 12:53 AM, Nicholas A. Bellinger wrote: Hi Michael, On Fri, 2016-05-13 at 17:15 -0500, Michael Cyr wrote: If a command with a Simple task attribute is failed due to a Unit Attention, then a subsequent command with an Ordered task attribute will hang forever. The reason for this is t

Re: [PATCH] Fix for hang of Ordered task in TCM

2016-05-17 Thread Nicholas A. Bellinger
Hi Michael, On Fri, 2016-05-13 at 17:15 -0500, Michael Cyr wrote: > If a command with a Simple task attribute is failed due to a Unit > Attention, then a subsequent command with an Ordered task attribute will > hang forever. The reason for this is that the Unit Attention status is > checked for i

[PATCH] Fix for hang of Ordered task in TCM

2016-05-13 Thread Michael Cyr
If a command with a Simple task attribute is failed due to a Unit Attention, then a subsequent command with an Ordered task attribute will hang forever. The reason for this is that the Unit Attention status is checked for in target_setup_cmd_from_cdb, before the call to target_execute_cmd, which c