Re: [PATCH] Add compat_ioctl to scsi host structure

2005-01-19 Thread Andi Kleen
On Wed, Jan 19, 2005 at 07:55:01AM -0800, James Bottomley wrote: > On Wed, 2005-01-19 at 00:27 +0100, Andi Kleen wrote: > > On Tue, Jan 18, 2005 at 07:35:36AM -0800, James Bottomley wrote: > > > Shouldn't this also be surrounded by #ifdef CONFIG_COMPAT (on the > > > grounds that you never fill it i

Re: [PATCH] Add compat_ioctl to scsi host structure

2005-01-19 Thread James Bottomley
On Wed, 2005-01-19 at 00:27 +0100, Andi Kleen wrote: > On Tue, Jan 18, 2005 at 07:35:36AM -0800, James Bottomley wrote: > > Shouldn't this also be surrounded by #ifdef CONFIG_COMPAT (on the > > grounds that you never fill it in unless CONFIG_COMPAT is defined)? > > At least the standard file_opera

Re: [PATCH] Add compat_ioctl to scsi host structure

2005-01-18 Thread Andi Kleen
On Tue, Jan 18, 2005 at 07:35:36AM -0800, James Bottomley wrote: > On Tue, 2005-01-18 at 12:03 +0100, Andi Kleen wrote: > > Add a call vector for 32bit compat ioctls to the SCSI host > > structure. This is needed for some followon patches. > > > > Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> > >

Re: [PATCH] Add compat_ioctl to scsi host structure

2005-01-18 Thread James Bottomley
On Tue, 2005-01-18 at 12:03 +0100, Andi Kleen wrote: > Add a call vector for 32bit compat ioctls to the SCSI host > structure. This is needed for some followon patches. > > Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> Shouldn't this also be surrounded by #ifdef CONFIG_COMPAT (on the grounds that

[PATCH] Add compat_ioctl to scsi host structure

2005-01-18 Thread Andi Kleen
Add a call vector for 32bit compat ioctls to the SCSI host structure. This is needed for some followon patches. Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> diff -u linux-2.6.11-rc1-bk4/include/scsi/scsi_host.h-o linux-2.6.11-rc1-bk4/include/scsi/scsi_host.h --- linux-2.6.11-rc1-bk4/include/sc