Re: [PATCH] Add compat_ioctl to SG

2005-01-18 Thread Andi Kleen
On Tue, Jan 18, 2005 at 09:35:53PM +1000, Douglas Gilbert wrote: > Andi Kleen wrote: > > >@@ -1343,6 +1366,9 @@ > > .write = sg_write, > > .poll = sg_poll, > > .ioctl = sg_ioctl, > >+#ifdef CONFIG_COMPAT > >+.ioctl = sg_compat_ioctl, > >+#endif > > Andi, > Two initializations of "

Re: [PATCH] Add compat_ioctl to SG

2005-01-18 Thread Douglas Gilbert
Andi Kleen wrote: @@ -1343,6 +1366,9 @@ .write = sg_write, .poll = sg_poll, .ioctl = sg_ioctl, +#ifdef CONFIG_COMPAT + .ioctl = sg_compat_ioctl, +#endif Andi, Two initializations of ".ioctl" looks wrongs. Comparing with the patch to sd should that be: + .compat

[PATCH] Add compat_ioctl to SG

2005-01-18 Thread Andi Kleen
Add compat_ioctl forwarder to SG. Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> diff -u linux-2.6.11-rc1-bk4/drivers/scsi/sg.c-o linux-2.6.11-rc1-bk4/drivers/scsi/sg.c --- linux-2.6.11-rc1-bk4/drivers/scsi/sg.c-o2005-01-04 12:13:07.0 +0100 +++ linux-2.6.11-rc1-bk4/drivers/scsi/sg.c