Re: [PATCH] - export scsilun_to_int

2007-02-01 Thread Jeff Garzik
Eric Moore wrote: On Wednesday, January 31, 2007 6:52 PM, James Bottomley wrote: what's wrong with memcmp(lun1->scsi_lun, lun2->scsi_lun, 8) rather than introducing a wrapper? The compiler can even optimise memcmp for a fixed size nicely. James Changed to using memcmp. This replaces the

RE: [PATCH] - export scsilun_to_int

2007-02-01 Thread Eric Moore
On Wednesday, January 31, 2007 6:52 PM, James Bottomley wrote: > > what's wrong with > > memcmp(lun1->scsi_lun, lun2->scsi_lun, 8) > > rather than introducing a wrapper? The compiler can even optimise > memcmp for a fixed size nicely. > > James > Changed to using memcmp. This replaces the p

Re: [PATCH] - export scsilun_to_int

2007-02-01 Thread Jeff Garzik
James Bottomley wrote: On Wed, 2007-01-31 at 15:54 -0700, Eric Moore wrote: static int +mptscsih_cmp_scsilun(struct scsi_lun * lun1, struct scsi_lun * lun2) +{ + int i; + + for (i = 0; i < 8 ; i++) + if (lun1->scsi_lun[i] != lun2->scsi_lun[i]) + re

RE: [PATCH] - export scsilun_to_int

2007-01-31 Thread James Bottomley
On Wed, 2007-01-31 at 15:54 -0700, Eric Moore wrote: > static int > +mptscsih_cmp_scsilun(struct scsi_lun * lun1, struct scsi_lun * lun2) > +{ > + int i; > + > + for (i = 0; i < 8 ; i++) > + if (lun1->scsi_lun[i] != lun2->scsi_lun[i]) > + return 1; >

RE: [PATCH] - export scsilun_to_int

2007-01-31 Thread Eric Moore
On Wednesday, January 31, 2007 1:49 PM, James Bottomley wrote: > Yes, I missed that. However, the mf (SCSIIORequest_t) comes back with > the 8 byte luns, couldn't you just run vdevice->lun through > int_to_scsilun and compare on that? > > I'm really reluctant to export the lun to int lossy transf

RE: [PATCH] - export scsilun_to_int

2007-01-31 Thread James Bottomley
On Wed, 2007-01-31 at 12:44 -0700, Moore, Eric wrote: > On Wednesday, January 31, 2007 10:02 AM, James Bottomley wrote: > > This is wrong. the "int" represents our internal coding of the 8 byte > > extended LUN (currently it's a lossy transform that only allows up to > > two level LUNs, so one da

RE: [PATCH] - export scsilun_to_int

2007-01-31 Thread Moore, Eric
On Wednesday, January 31, 2007 10:02 AM, James Bottomley wrote: > This is wrong. the "int" represents our internal coding of the 8 byte > extended LUN (currently it's a lossy transform that only allows up to > two level LUNs, so one day this will definitely change). No driver > should be using t

Re: [PATCH] - export scsilun_to_int

2007-01-31 Thread James Bottomley
On Mon, 2007-01-29 at 09:40 -0700, Eric Moore wrote: > export symbol to be used in 1st fusion patch > > Signed-off-by: Eric Moore <[EMAIL PROTECTED]> This is wrong. the "int" represents our internal coding of the 8 byte extended LUN (currently it's a lossy transform that only allows up to two le

[PATCH] - export scsilun_to_int

2007-01-29 Thread Eric Moore
export symbol to be used in 1st fusion patch Signed-off-by: Eric Moore <[EMAIL PROTECTED]> diff -uarpN b/drivers/scsi/scsi_scan.c a/drivers/scsi/scsi_scan.c --- b/drivers/scsi/scsi_scan.c 2007-01-24 19:19:28.0 -0700 +++ a/drivers/scsi/scsi_scan.c 2007-01-28 12:42:12.0 -0700 @@ -