Re: [PATCH] [SCSI] sym53c8xx: fix setflag user command to control disconnects

2007-11-08 Thread Christoph Hellwig
On Thu, Nov 08, 2007 at 01:11:01PM -0500, Tony Battersby wrote: > HBA is inside an embedded device sold by my company, and customers can > attach their own SCSI devices to it. There is one type of SCSI device > that we support which doesn't work with disconnect privilege enabled, so > my code runn

Re: [PATCH] [SCSI] sym53c8xx: fix setflag user command to control disconnects

2007-11-08 Thread Tony Battersby
James Bottomley wrote: > On Wed, 2007-11-07 at 15:37 -0500, Tony Battersby wrote: > >> This patch fixes the sym53c8xx "setflag" user command to control >> disconnect privilege, which has been broken for a long time. >> > > The first observation is that the sym specific setflags interface i

Re: [PATCH] [SCSI] sym53c8xx: fix setflag user command to control disconnects

2007-11-08 Thread James Bottomley
On Wed, 2007-11-07 at 15:37 -0500, Tony Battersby wrote: > This patch fixes the sym53c8xx "setflag" user command to control > disconnect privilege, which has been broken for a long time. The first observation is that the sym specific setflags interface is being replaced by the parallel transport

[PATCH] [SCSI] sym53c8xx: fix setflag user command to control disconnects

2007-11-07 Thread Tony Battersby
This patch fixes the sym53c8xx "setflag" user command to control disconnect privilege, which has been broken for a long time. Signed-off-by: Tony Battersby <[EMAIL PROTECTED]> --- NOTE regarding the following change: can_disconnect = (cp->tag != NO_TAG) || - (lp && (lp->cur