Re: [PATCH][SCSI]: Save some bytes in struct scsi_target

2006-12-12 Thread Arnaldo Carvalho de Melo
On Mon, Dec 11, 2006 at 08:52:22PM -0700, Matthew Wilcox wrote: > On Tue, Dec 12, 2006 at 01:17:18AM -0200, Arnaldo Carvalho de Melo wrote: > > }; /* size: 368, cachelines: 12 */ > > }; /* size: 364, cachelines: 12 */ > > Saving space is always good ;-) > > > - unsigned intcreate:1;

Re: [PATCH][SCSI]: Save some bytes in struct scsi_target

2006-12-11 Thread Matthew Wilcox
On Tue, Dec 12, 2006 at 01:17:18AM -0200, Arnaldo Carvalho de Melo wrote: > }; /* size: 368, cachelines: 12 */ > }; /* size: 364, cachelines: 12 */ Saving space is always good ;-) > - unsigned intcreate:1; /* signal that it needs to be added */ > + charscsi

[PATCH][SCSI]: Save some bytes in struct scsi_target

2006-12-11 Thread Arnaldo Carvalho de Melo
Before: [EMAIL PROTECTED] kpahole-2.6]$ pahole --cacheline 32 /tmp/scsi.o.before scsi_target /* include/scsi/scsi_device.h:86 */ struct scsi_target { struct scsi_device * starget_sdev_user;/* 0 4 */ struct list_head siblings; /* 4 8