Re: [PATCH, resend] scsi: advansys: fix big-endian builds

2015-11-18 Thread Martin K. Petersen
> "Arnd" == Arnd Bergmann writes: Arnd> Building the advansys driver in a big-endian configuration such as Arnd> ARM allmodconfig shows a warning: Applied to 4.4. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in

Re: [PATCH, resend] scsi: advansys: fix big-endian builds

2015-11-16 Thread Hannes Reinecke
On 11/16/2015 05:49 PM, Arnd Bergmann wrote: > Building the advansys driver in a big-endian configuration such as > ARM allmodconfig shows a warning: > > drivers/scsi/advansys.c: In function 'adv_build_req': > include/uapi/linux/byteorder/big_endian.h:32:26: warning: large integer > implicitly

Re: [PATCH, resend] scsi: advansys: fix big-endian builds

2015-11-16 Thread Geert Uytterhoeven
On Mon, Nov 16, 2015 at 7:20 PM, Russell King - ARM Linux wrote: > On Mon, Nov 16, 2015 at 05:49:23PM +0100, Arnd Bergmann wrote: >> It turns out that the commit that introduced this used the cpu_to_le32() >> incorrectly on an 8-bit field, which results in the sense_len to always >> be set to zero

Re: [PATCH, resend] scsi: advansys: fix big-endian builds

2015-11-16 Thread Christoph Hellwig
On Mon, Nov 16, 2015 at 06:20:31PM +, Russell King - ARM Linux wrote: > On Mon, Nov 16, 2015 at 05:49:23PM +0100, Arnd Bergmann wrote: > > It turns out that the commit that introduced this used the cpu_to_le32() > > incorrectly on an 8-bit field, which results in the sense_len to always > > be

Re: [PATCH, resend] scsi: advansys: fix big-endian builds

2015-11-16 Thread Russell King - ARM Linux
On Mon, Nov 16, 2015 at 05:49:23PM +0100, Arnd Bergmann wrote: > It turns out that the commit that introduced this used the cpu_to_le32() > incorrectly on an 8-bit field, which results in the sense_len to always > be set to zero, as the SCSI_SENSE_BUFFERSIZE value gets moved to upper > byte of the

[PATCH, resend] scsi: advansys: fix big-endian builds

2015-11-16 Thread Arnd Bergmann
Building the advansys driver in a big-endian configuration such as ARM allmodconfig shows a warning: drivers/scsi/advansys.c: In function 'adv_build_req': include/uapi/linux/byteorder/big_endian.h:32:26: warning: large integer implicitly truncated to unsigned type [-Woverflow] #define __cpu_t