Re: [Cbe-oss-dev] [PATCH] ps3rom: sector size should be 512 bytes

2008-01-31 Thread Nicholas A. Bellinger
On Thu, 2008-01-31 at 20:14 +0100, Geert Uytterhoeven wrote: > On Thu, 31 Jan 2008, Nicholas A. Bellinger wrote: > > On Thu, 2008-01-31 at 11:53 -0600, James Bottomley wrote: > > > On Thu, 2008-01-31 at 09:28 -0800, Nicholas A. Bellinger wrote: > > > > The problem case is a SCSI Target Mode engine

Re: [Cbe-oss-dev] [PATCH] ps3rom: sector size should be 512 bytes

2008-01-31 Thread James Bottomley
On Thu, 2008-01-31 at 10:44 -0800, Nicholas A. Bellinger wrote: > > In short, and to repeat: almost every internal size counter to block is > > in units of 512 byte sectors ... that includes capacity, maximum etc ... > > > > Ok, after reading your followup with Geert I see that this looks like a

Re: [Cbe-oss-dev] [PATCH] ps3rom: sector size should be 512 bytes

2008-01-31 Thread Geert Uytterhoeven
On Thu, 31 Jan 2008, Nicholas A. Bellinger wrote: > On Thu, 2008-01-31 at 11:53 -0600, James Bottomley wrote: > > On Thu, 2008-01-31 at 09:28 -0800, Nicholas A. Bellinger wrote: > > > The problem case is a SCSI Target Mode engine that receives a 2048 Byte > > > single sector ATAPI READ_10 request f

Re: [Cbe-oss-dev] [PATCH] ps3rom: sector size should be 512 bytes

2008-01-31 Thread Geert Uytterhoeven
On Thu, 31 Jan 2008, James Bottomley wrote: > On Thu, 2008-01-31 at 18:41 +0100, Geert Uytterhoeven wrote: > > James, do you have any comment about the first email in this thread, > > increasing > > scsi_host_template.max_sectors? > > Assuming your BOUNCE_SIZE is in bytes, and represents your lar

Re: [Cbe-oss-dev] [PATCH] ps3rom: sector size should be 512 bytes

2008-01-31 Thread Nicholas A. Bellinger
On Thu, 2008-01-31 at 11:53 -0600, James Bottomley wrote: > On Thu, 2008-01-31 at 09:28 -0800, Nicholas A. Bellinger wrote: > > On Thu, 2008-01-31 at 10:26 -0600, James Bottomley wrote: > > > On Thu, 2008-01-31 at 08:10 -0800, Nicholas A. Bellinger wrote: > > > > On Thu, 2008-01-31 at 09:34 -0600,

Re: [Cbe-oss-dev] [PATCH] ps3rom: sector size should be 512 bytes

2008-01-31 Thread James Bottomley
On Thu, 2008-01-31 at 18:41 +0100, Geert Uytterhoeven wrote: > On Thu, 31 Jan 2008, Nicholas A. Bellinger wrote: > > On Thu, 2008-01-31 at 10:26 -0600, James Bottomley wrote: > > > On Thu, 2008-01-31 at 08:10 -0800, Nicholas A. Bellinger wrote: > > > > On Thu, 2008-01-31 at 09:34 -0600, James Botto

Re: [Cbe-oss-dev] [PATCH] ps3rom: sector size should be 512 bytes

2008-01-31 Thread James Bottomley
On Thu, 2008-01-31 at 09:28 -0800, Nicholas A. Bellinger wrote: > On Thu, 2008-01-31 at 10:26 -0600, James Bottomley wrote: > > On Thu, 2008-01-31 at 08:10 -0800, Nicholas A. Bellinger wrote: > > > On Thu, 2008-01-31 at 09:34 -0600, James Bottomley wrote: > > > > On Thu, 2008-01-31 at 06:10 -0800,

Re: [Cbe-oss-dev] [PATCH] ps3rom: sector size should be 512 bytes

2008-01-31 Thread Geert Uytterhoeven
On Thu, 31 Jan 2008, Nicholas A. Bellinger wrote: > On Thu, 2008-01-31 at 10:26 -0600, James Bottomley wrote: > > On Thu, 2008-01-31 at 08:10 -0800, Nicholas A. Bellinger wrote: > > > On Thu, 2008-01-31 at 09:34 -0600, James Bottomley wrote: > > > > On Thu, 2008-01-31 at 06:10 -0800, Nicholas A. Be

Re: [Cbe-oss-dev] [PATCH] ps3rom: sector size should be 512 bytes

2008-01-31 Thread Nicholas A. Bellinger
On Thu, 2008-01-31 at 10:26 -0600, James Bottomley wrote: > On Thu, 2008-01-31 at 08:10 -0800, Nicholas A. Bellinger wrote: > > On Thu, 2008-01-31 at 09:34 -0600, James Bottomley wrote: > > > On Thu, 2008-01-31 at 06:10 -0800, Nicholas A. Bellinger wrote: > > > > Greetings Geert and Co, > > > > >

Re: [Cbe-oss-dev] [PATCH] ps3rom: sector size should be 512 bytes

2008-01-31 Thread James Bottomley
On Thu, 2008-01-31 at 08:10 -0800, Nicholas A. Bellinger wrote: > On Thu, 2008-01-31 at 09:34 -0600, James Bottomley wrote: > > On Thu, 2008-01-31 at 06:10 -0800, Nicholas A. Bellinger wrote: > > > Greetings Geert and Co, > > > > > > I have a related patch that I have been using with ps3rom.c for

Re: [Cbe-oss-dev] [PATCH] ps3rom: sector size should be 512 bytes

2008-01-31 Thread Nicholas A. Bellinger
On Thu, 2008-01-31 at 09:34 -0600, James Bottomley wrote: > On Thu, 2008-01-31 at 06:10 -0800, Nicholas A. Bellinger wrote: > > Greetings Geert and Co, > > > > I have a related patch that I have been using with ps3rom.c for some > > time that fixes a bug in fs/bio.c that assumes 512 byte sectors f

Re: [Cbe-oss-dev] [PATCH] ps3rom: sector size should be 512 bytes

2008-01-31 Thread James Bottomley
On Thu, 2008-01-31 at 06:10 -0800, Nicholas A. Bellinger wrote: > Greetings Geert and Co, > > I have a related patch that I have been using with ps3rom.c for some > time that fixes a bug in fs/bio.c that assumes 512 byte sectors for > ATAPI operations. This bug actually exists for all non 512 byt

Re: [Cbe-oss-dev] [PATCH] ps3rom: sector size should be 512 bytes

2008-01-31 Thread Nicholas A. Bellinger
Greetings Geert and Co, I have a related patch that I have been using with ps3rom.c for some time that fixes a bug in fs/bio.c that assumes 512 byte sectors for ATAPI operations. This bug actually exists for all non 512 byte sector devices go through this code path (I found it with scsi_execute_a

Re: [Cbe-oss-dev] [PATCH] ps3rom: sector size should be 512 bytes

2008-01-31 Thread Geert Uytterhoeven
On Tue, 29 Jan 2008, Aegis Lin wrote: > Quite minor patch, but from the context it should be desired > that 64KB is available for ATAPI transferrring. > (Historically) in SCSI/block layer sector size is defined as > 512 during sector-byte calculation. Originally in ps3rom.c > CD_FRAMESIZE was used,