On Mon, 2005-04-11 at 22:35 -0700, Greg KH wrote:
> On Mon, Apr 11, 2005 at 08:24:08PM -0700, Alex Aizman wrote:
> > +typedef uint64_t iscsi_snx_t; /* iSCSI Data-Path session
> > handle */
> > +typedef uint64_t iscsi_cnx_t; /* iSCSI Data-Path connection
> > handle */
>
On Tue, Apr 12, 2005 at 12:45:14AM -0700, Greg KH wrote:
> Um, why? We've been down this road before, and for types that cross the
> boundry, we _must_ use the __ version of the kernel types, not the
> uint32_t stuff.
That's total bullshit. C99 types just work in both the kernel and userland,
wh
On Tue, Apr 12, 2005 at 08:27:33AM +0100, Christoph Hellwig wrote:
> On Mon, Apr 11, 2005 at 10:36:51PM -0700, Greg KH wrote:
> > On Mon, Apr 11, 2005 at 08:24:08PM -0700, Alex Aizman wrote:
> > > Common header files:
> > > - iscsi_ifev.h (user/kernel events).
> >
> > T
On Mon, Apr 11, 2005 at 10:36:51PM -0700, Greg KH wrote:
> On Mon, Apr 11, 2005 at 08:24:08PM -0700, Alex Aizman wrote:
> > Common header files:
> > - iscsi_ifev.h (user/kernel events).
>
> These structures cross the user/kernel boundry? If so, they _must_ use
> the __
On Mon, Apr 11, 2005 at 08:24:08PM -0700, Alex Aizman wrote:
> +typedef uint64_t iscsi_snx_t;/* iSCSI Data-Path session
> handle */
> +typedef uint64_t iscsi_cnx_t;/* iSCSI Data-Path connection
> handle */
Do you really have to create a new typedef? Please recons
On Mon, Apr 11, 2005 at 08:24:08PM -0700, Alex Aizman wrote:
> Common header files:
> - iscsi_ifev.h (user/kernel events).
These structures cross the user/kernel boundry? If so, they _must_ use
the __u32 and friends types, not the horrible uint32_t mess...
thanks,
gr
> +struct iscsi_hdr {
> + uint8_t opcode;
> + uint8_t flags; /* Final bit */
> + uint8_t rsvd2[2];
> + uint8_t hlength;/* AHSs total length */
> + uint8_t dlength[3]; /* Data length */
> + uint8_t lun[8];
>
Common header files:
- iscsi_ifev.h (user/kernel events).
- iscsi_if.h (user/kernel #defines);
- iscsi_iftrans.h (iscsi transport interface);
- iscsi_proto.h (RFC3720 #defines and types).
Signed-off-by: Alex Aizman
8 matches
Mail list logo
