Re: [PATCH v4.3-rc7] be2iscsi : Fix bogus WARN_ON length check

2015-11-01 Thread Tim Gardner
On 10/30/2015 02:59 PM, Johannes Thumshirn wrote: > Hi Tim, > tim.gard...@canonical.com writes: > >> From: Tim Gardner >> >> drivers/scsi/be2iscsi/be_main.c: In function 'be_sgl_create_contiguous': >> drivers/scsi/be2iscsi/be_main.c:3187:18: warning:

[PATCH v4.3-rc7] be2iscsi : Fix bogus WARN_ON length check

2015-10-30 Thread tim . gardner
From: Tim Gardner drivers/scsi/be2iscsi/be_main.c: In function 'be_sgl_create_contiguous': drivers/scsi/be2iscsi/be_main.c:3187:18: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses] WARN_ON(!length > 0); gcc version 5.2.1

[PATCH linux/linux-next] aic94xx: asd_read_flash: Fix uninitialized variable warning

2013-02-20 Thread Tim Gardner
If asd_find_flash_de() fails, then 'offs' could be used without having been initialized. Set 'offs' to zero which seems like the most reasonable value. Cc: "James E.J. Bottomley" Cc: linux-scsi@vger.kernel.org Signed-off-by: Tim Gardner --- drivers/scsi/aic94xx/

[PATCH linux/linux-next] mpt2sas: _scsih_sas_broadcast_primitive_event: Quiet unused variable warning

2013-02-20 Thread Tim Gardner
dd __maybe_unused to the definition of event_data. Cc: Nagalakshmi Nandigama Cc: Sreekanth Reddy Cc: supp...@lsi.com Cc: "James E.J. Bottomley" Cc: dl-mptfusionli...@lsi.com Cc: linux-scsi@vger.kernel.org Signed-off-by: Tim Gardner --- drivers/scsi/mpt2sas/mpt2sas_scsih.c |3 ++-

[PATCH linux/linux-next] [SCSI] mvsas: Fix compile warnings by using correct enums

2013-02-20 Thread Tim Gardner
Use enum symbols of the same value, but from the correct enum type definition. Cc: "James E.J. Bottomley" Cc: Dan Williams Cc: Greg Kroah-Hartman Cc: Jack Wang Cc: linux-scsi@vger.kernel.org Signed-off-by: Tim Gardner --- drivers/scsi/mvsas/mv_sas.c |4 ++-- 1 file changed, 2