ainer and
Martin Peschke as the co-maintainer.
Please support the two in providing us a new and more stable
zfcp environment.
Thanks
Swen
---
MAINTAINERS |6 --
1 file changed, 4 insertions(+), 2 deletions(-)
Index: scsi-misc/MAINTA
On Monday 26 November 2007 11:23, Swen Schillig wrote:
> On Sunday 25 November 2007 12:16, James Bottomley wrote:
> >
> > On Wed, 2007-10-31 at 11:33 +0100, Swen Schillig wrote:
> > > From: Swen Schillig <[EMAIL PROTECTED]>
> > >
> > > add som
On Sunday 25 November 2007 12:16, James Bottomley wrote:
>
> On Wed, 2007-10-31 at 11:33 +0100, Swen Schillig wrote:
> > From: Swen Schillig <[EMAIL PROTECTED]>
> >
> > add some statistics provided by the zFCP adapter to the sysfs
> >
> > The new zF
lt;[EMAIL PROTECTED]>
Signed-off-by: Martin Schwidefsky <[EMAIL PROTECTED]>
Signed-off-by: Swen Schillig <[EMAIL PROTECTED]>
---
drivers/s390/scsi/zfcp_def.h | 14 ++
drivers/s390/scsi/zfcp_erp.c |3 ++-
2 files changed, 16 insertions(+), 1 deletion(-)
Index: SHIP_O
James
can you give me the status of the below patch ?
Is there anything missing from my side or is the patch still in review by you ?
Cheers Swen
On Friday 09 November 2007 14:07, Swen Schillig wrote:
> Updated the statistics patch to cover the issues pointed out by Heiko.
>
> James,
Updated the statistics patch to cover the issues pointed out by Heiko.
James, could you please apply.
Thanks
Swen
---
From: Swen Schillig <[EMAIL PROTECTED]>
add some statistics provided by the zFCP adapter to the sysfs
The new zFCP adapter statistics provide a variety of information
qtcb_config->stat_info.input_req,
> > +qtcb_config->stat_info.output_req,
> > +qtcb_config->stat_info.control_req);
> > +
> > + kfree(qtcb_config);
> > + return retval;
> > +}
>
> You're going to call kfree with some random value if the adapter doesn't
> support the measurement data feature.
>
Ok, valid points.
I changed the patch to meet the above described issues.
Before I will post the modified version I want to do some testing (and an
internal review).
The updated version will follow soon (hopefully this week), thanks for
reviewing.
Cheers Swen
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
to simply remove the "qual" tracing: The responses with an
interesting status are also traced as "ferr" or "perr" and all
responses can be traced as "norm" with a higher trace level.
Signed-off-by: Christof Schmitt <[EMAIL PROTECTED]>
Signed-off-by: Swe
ix the deadlock by removing the wait in the slave_destroy
handler, it was not necessary anyway.
Signed-off-by: Christof Schmitt <[EMAIL PROTECTED]>
Signed-off-by: Martin Schwidefsky <[EMAIL PROTECTED]>
Signed-off-by: Swen Schillig <[EMAIL PROTECTED]>
---
drivers/s390/scsi/zfcp_a
From: Christof Schmitt <[EMAIL PROTECTED]>
It is not necessary to use jiffies or milliseconds to specify
waiting times that last a couple of seconds.
Signed-off-by: Christof Schmitt <[EMAIL PROTECTED]>
Signed-off-by: Martin Schwidefsky <[EMAIL PROTECTED]>
Signed-off-by: Swe
From: Christof Schmitt <[EMAIL PROTECTED]>
Signed-off-by: Christof Schmitt <[EMAIL PROTECTED]>
Signed-off-by: Swen Schillig <[EMAIL PROTECTED]>
---
drivers/s390/scsi/zfcp_scsi.c |8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff -urpN linux-2.6/drivers/s39
Signed-off-by: Christof Schmitt <[EMAIL PROTECTED]>
Signed-off-by: Swen Schillig <[EMAIL PROTECTED]>
---
drivers/s390/scsi/zfcp_ccw.c |3 +++
1 file changed, 3 insertions(+)
diff -urpN linux-2.6/drivers/s390/scsi/zfcp_ccw.c
linux-2.6-patched/drivers/s390/scsi/zfcp_ccw.c
--- linu
ristof Schmitt <[EMAIL PROTECTED]>
Signed-off-by: Swen Schillig <[EMAIL PROTECTED]>
---
drivers/s390/scsi/zfcp_scsi.c |5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
Index: scsi-misc/drivers/s390/scsi/zfcp_scsi.c
==
--
patch 1/6: Remove unnecessary eh_bus_reset_handler callsback
The callback function used by zfcp always returns success,
which is an indication for the SCSI midlayer to stop error
handling. Remove the bus_reset callback, since the same
function will be
er ways to achieve the same thing, how about "logger"
!
But since it seems to bother you a lot, I will remove the message.
Cheers Swen
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Swen Schillig <[EMAIL PROTECTED]>
add some statistics provided by the zFCP adapter to the sysfs
The new zFCP adapter statistics provide a variety of information
about the virtual adapter (subchannel). In order to collect this information
the zFCP driver is extended on one side to que
From: Swen Schillig <[EMAIL PROTECTED]>
Cleanup the whitepace from the entire zfcp driver to prevent
to have those changes in future feature or function patches.
Signed-off-by: Swen Schillig <[EMAIL PROTECTED]>
---
drivers/s390/scsi/zfcp_aux.c|4 -
drivers/s390/scs
From: Swen Schillig <[EMAIL PROTECTED]>
add statistics and other zfcp related information to sysfs
The zfcp adapter provides a variety of information which was never
published to the external world. This patch adds a few of those "statistics"
to the sysfs tree structure.
These
be improved.
Sorry, for the inconvenience.
Cheers Swen.
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Swen Schillig <[EMAIL PROTECTED]>
add statistics and other zfcp related information to sysfs
The zfcp adapter provides a variety of information which was never
published to the external world. This patch adds a few of those "statistics"
to the sysfs tree structure.
These
On Monday 03 September 2007 14:40, Matthew Wilcox wrote:
> On Mon, Sep 03, 2007 at 02:16:21PM +0200, Swen Schillig wrote:
> > /sys/bus/ccw/drivers/zfcp/0.0.1707
> > /* information for the virtual adapter */
> > statistic_services/
>
ad_latency
write_latency
cmd_latency
Please comment if this would be an acceptable way to publish
the additional information.
Cheers Swen.
---
drivers/s390/scsi/Makefile|2
drivers/s390/scsi/zfcp_aux.c | 30
drivers/s390/scsi/
From: Christof Schmitt <[EMAIL PROTECTED]>
Already register the debug feature before the zfcp adapter is
set online. This allows to use the debug feature to investigate
the online/offline sequence.
Signed-off-by: Christof Schmitt <[EMAIL PROTECTED]>
Signed-off-by: Swen Schillig <[
From: Christof Schmitt <[EMAIL PROTECTED]>
zfcp manages the valid SCSI units currently on its own. So we don't
want the FC transport class to issue scans for units.
Signed-off-by: Christof Schmitt <[EMAIL PROTECTED]>
Signed-off-by: Swen Schillig <[EMAIL PROTECTED]>
From: Christof Schmitt <[EMAIL PROTECTED]>
Remove braces for only one statement
Signed-off-by: Christof Schmitt <[EMAIL PROTECTED]>
Signed-off-by: Swen Schillig <[EMAIL PROTECTED]>
---
drivers/s390/scsi/zfcp_scsi.c |6 ++
1 file changed, 2 insertions(+), 4 deleti
From: Swen Schillig <[EMAIL PROTECTED]>
cleanup, using ERP request mempool for all ERP versions of
the exchange functions (exchange_config (ECD), exchange_port (EPD) )
providing individual versions of the ECD, EPD functions for ERP
and other purposes (_sync).
Signed-off-by: Swen Sc
From: Christof Schmitt <[EMAIL PROTECTED]>
correct indentation for nested if-else
Signed-off-by: Christof Schmitt <[EMAIL PROTECTED]>
Signed-off-by: Swen Schillig <[EMAIL PROTECTED]>
---
drivers/s390/scsi/zfcp_fsf.c | 22 +++---
1 file changed, 11 insertion
From: Christof Schmitt <[EMAIL PROTECTED]>
This change has already been discussed on linux-scsi:
http://marc.info/?t=11877109643
http://marc.info/?t=11876091315
Signed-off-by: Christof Schmitt <[EMAIL PROTECTED]>
Signed-off-by: Swen Schillig <[EMAIL PROTECTED]>
From: Heiko Carstens <[EMAIL PROTECTED]>
Avoid "if (whatever) ;" constructs since they seem to confuse people,
even if there is a comment.
Signed-off-by: Heiko Carstens <[EMAIL PROTECTED]>
Signed-off-by: Swen Schillig <[EMAIL PROTECTED]>
---
drivers/s390/scsi/zf
From: Christof Schmitt <[EMAIL PROTECTED]>
zfcp_adapter_enqueue initialized adapter->ccw_device twice with
the same value. Remove the second assignment, since it is not
necessary.
Signed-off-by: Christof Schmitt <[EMAIL PROTECTED]>
Signed-off-by: Swen Schillig <[EMAIL PROTECT
From: Heiko Carstens <[EMAIL PROTECTED]>
Allocate gid_pn_data objects from the corresponding cache which ensures
proper alignment.
Signed-off-by: Heiko Carstens <[EMAIL PROTECTED]>
Signed-off-by: Swen Schillig <[EMAIL PROTECTED]>
---
drivers/s390/scsi/zfcp_aux.c |4 ++--
Subject: [PATCH] zfcp: fix memory leak.
From: Heiko Carstens <[EMAIL PROTECTED]>
Signed-off-by: Heiko Carstens <[EMAIL PROTECTED]>
Singed-off-by: Swen Schillig <[EMAIL PROTECTED]>
---
drivers/s390/scsi/zfcp_scsi.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
On Wednesday 08 August 2007 10:47, Swen Schillig wrote:
> From: Christoph Schmitt <[EMAIL PROTECTED]>
>
> Symptom: zfcp receives a response to a "status read" request
>that is no longer valid in zfcp. This leads to a
>kernel pa
From: Heiko Carstens <[EMAIL PROTECTED]>
Fix the data buffer accessor patch.
For request without a data buffer nothing was written into
a SBALE.
Signed-off-by: Heiko Carstens <[EMAIL PROTECTED]>
Signed-off-by: Swen Schillig <[EMAIL PROTECTED]>
---
drivers/s390/scsi/
From: Heiko Carstens <[EMAIL PROTECTED]>
fix memory leak.
Signed-off-by: Heiko Carstens <[EMAIL PROTECTED]>
Signed-off-by: Martin Schwidefsky <[EMAIL PROTECTED]>
Signed-off-by: Swen Schillig <[EMAIL PROTECTED]>
---
drivers/s390/scsi/zfcp_scsi.c |4 +++-
1 file cha
ED]>
Signed-off-by: Swen Schillig <[EMAIL PROTECTED]>
---
drivers/s390/scsi/zfcp_aux.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff -urpN linux-2.6/drivers/s390/scsi/zfcp_aux.c
linux-2.6-patched/drivers/s390/scsi/zfcp_aux.c
--- linux-2.6/drivers/s390/scsi/zfcp_aux
status read" requests anyway.
Signed-off-by: Christoph Schmitt <[EMAIL PROTECTED]>
Signed-off-by: Martin Schwidefsky <[EMAIL PROTECTED]>
Signed-off-by: Swen Schillig <[EMAIL PROTECTED]>
---
drivers/s390/scsi/zfcp_fsf.c | 19 +--
1 file changed, 13 insertio
Replying to the mailing-list as well.
ACK
On Sunday 29 July 2007 09:46, FUJITA Tomonori wrote:
> The patch is only compile tested.
>
> ---
> From: FUJITA Tomonori <[EMAIL PROTECTED]>
> Subject: [PATCH] zfcp: convert to use the data buffer accessors
>
> - remove the unnecessary map_single path.
Subject: [PATCH] zfcp: code cleanup
From: Swen Schillig <[EMAIL PROTECTED]>
improve code for buffer enqueue. easy readability and maintainability.
Signed-off-by: Swen Schillig <[EMAIL PROTECTED]>
---
drivers/s390/scsi/zfcp_def.h |1
drivers/s390/scsi/zfcp_q
Subject: [PATCH] zfcp: NULL vs 0 usage
From: Heiko Carstens <[EMAIL PROTECTED]>
Get rid of two 'warning: Using plain integer as NULL pointer'.
Signed-off-by: Heiko Carstens <[EMAIL PROTECTED]>
Signed-off-by: Swen Schillig <[EMAIL PROTECTED]>
---
drivers
Subject: [PATCH] zfcp: Replace kmalloc/memset with kzalloc
From: Swen Schillig <[EMAIL PROTECTED]>
Memory allocated with kmalloc is always initialzed to 0 with memset.
Replace the two calls with kzalloc, that already does both steps.
Signed-off-by: Swen Schillig <[EMAIL
On Monday 25 June 2007 16:03, Hannes Reinecke wrote:
> Swen Schillig wrote:
> > On Friday 22 June 2007 16:11, James Bottomley wrote:
> >> On Thu, 2007-06-21 at 21:40 -0700, Mike Anderson wrote:
> >>> James Bottomley <[EMAIL PROTECTED]> wrote:
> >>>
omes into the play.
And, because you were asking how we'd like that to be represented, I personally
prefer
a full blown 64bit hex value with leading zeros.
It makes the comparison to internal structures/models easier and gets us a bit
closer
to the documented (SAM4) standard.
...and I thi
]>
Signed-off-by: Swen Schillig <[EMAIL PROTECTED]>
---
drivers/s390/scsi/zfcp_aux.c | 22 --
drivers/scsi/scsi_scan.c |3 ++-
include/scsi/scsi_device.h |1 +
3 files changed, 7 insertions(+), 19 deletions(-)
diff --git a/drivers/s390/scsi/zfcp_aux.c b
On Monday 18 June 2007 10:47, Hannes Reinecke wrote:
> James Bottomley wrote:
> > On Tue, 2007-05-29 at 15:29 +0200, Swen Schillig wrote:
> >> From: Christof Schmitt <[EMAIL PROTECTED]>
> >>
> >> zfcp reported units to the SCSI stack starting
> >&
?
Thanks Swen
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Swen Schillig <[EMAIL PROTECTED]>
Memory allocated with kmalloc is always initialzed to 0 with memset.
Replace the two calls with kzalloc, that already does both steps.
Signed-off-by: Swen Schillig <[EMAIL PROTECTED]>
---
drivers/s390/scsi/zfcp_erp.c |3 +--
1 file
On Tuesday 29 May 2007 17:54, James Bottomley wrote:
> On Tue, 2007-05-29 at 10:51 -0500, James Bottomley wrote:
> > On Tue, 2007-05-29 at 15:55 +0200, Swen Schillig wrote:
> > > I just saw that I posted this patch on 9th already,
> > > but todays git pull from your tre
it twice, if there's any other
reason for this patch to not be included please let me know.
Thanks
Swen
On Tuesday 29 May 2007 15:29, Swen Schillig wrote:
> From: Michael Loehr <[EMAIL PROTECTED]>
>
> Devices corresponding to a deleted unit are never freed.
> This
From: Volker Sameske <[EMAIL PROTECTED]>
zfcp: clear adapter status flags during adapter shutdown
In some cases we did not reset some adapter status flags properly.
This patch clears these flags during FCP adapter shutdown.
Signed-off-by: Volker Sameske <[EMAIL PROTECTED]>
Signed-
es not want the SCSI stack to scan
for devices, since they are configured explicitly via sysfs.
This patch changes the numbering to always start with LUN 1 and therefore
prevent the SCSI stack sending REPORT LUN command.
Signed-off-by: Christof Schmitt <[EMAIL PROTECTED]>
Signed-off-by: S
are not deleted anymore. The host is set to
block on 'offline'. Host online is only removing the blocked status
and everything works as expected again.
Signed-off-by: Michael Loehr <[EMAIL PROTECTED]>
Signed-off-by: Swen Schillig <[EMAIL PROTECTED]>
---
drivers/s390/scsi/z
the erp
routine is not called correctly and the unit is not enabled properly.
Do not delete rport and the sdev. Just set the host to block on
'offline'. Setting host online again will then remove the blocked status
and everything is fine again.
Signed-off-by: Michael Loehr <[EMAIL PR
e <[EMAIL PROTECTED]>
Signed-off-by: Swen Schillig <[EMAIL PROTECTED]>
---
drivers/s390/scsi/zfcp_fsf.c | 40 +---
1 file changed, 13 insertions(+), 27 deletions(-)
--- linux_jb_patched.orig/drivers/s390/scsi/zfcp_fsf.c 2007-05-08
14:
From: Heiko Carstens <[EMAIL PROTECTED]>
The boxed flag for units was never cleared. This doesn't hurt, but on
ACL updates the error recovery could reopen more units than needed.
Signed-off-by: Heiko Carstens <[EMAIL PROTECTED]>
Signed-off-by: Swen Schillig <[EMAIL PROTECTED]
From: Heiko Carstens <[EMAIL PROTECTED]>
Simplify request ID management and make sure that frequently used
functions are inlined. Also fix a memory leak in zfcp_adapter_enqueue()
which only gets hit in error handling.
Signed-off-by: Heiko Carstens <[EMAIL PROTECTED]>
Signed-off-by: S
reopen that is issued
on fsf request timeout has no effect if the local link is down.
Might lead to locked up system if the SCSI stack is waiting for abort
completion.
Signed-off-by: Heiko Carstens <[EMAIL PROTECTED]>
Signed-off-by: Swen Schillig <[EMAIL PROTECTED]>
---
drivers/s390/scsi
hat no scsi_scan_target call is
pending.
3) Replace scsi_flush_work with scsi_target_unblock. This avoids
blocking and has the same result.
Signed-off-by: Christof Schmitt <[EMAIL PROTECTED]>
Signed-off-by: Swen Schillig <[EMAIL PROTECTED]>
---
drivers/s390/scsi/zfcp_aux.c |2 +
drivers/s3
t call
zfcp_fsf_req_sbal_get that acquires the lock, then read and
increment the unique ids.
Signed-off-by: Christof Schmitt <[EMAIL PROTECTED]>
Signed-off-by: Swen Schillig <[EMAIL PROTECTED]>
---
drivers/s390/scsi/zfcp_fsf.c | 17 -
1 file changed, 8 insertions(+), 9 deletions
From: Christof Schmitt <[EMAIL PROTECTED]>
S_ID and D_ID are defined in the FCP spec as 3 byte fields.
Change the output in zfcp print statements accordingly to print
them with only 3 bytes.
Signed-off-by: Christof Schmitt <[EMAIL PROTECTED]>
Signed-off-by: Swen Schillig <[
op the system with a panic.
Signed-off-by: Christof Schmitt <[EMAIL PROTECTED]>
Signed-off-by: Swen Schillig <[EMAIL PROTECTED]>
---
drivers/s390/scsi/zfcp_qdio.c | 32 +---
1 files changed, 5 insertions(+), 27 deletions(-)
diff -urpN linux-2.6
commit 07a105136f07f0cf1b476383e43033b8a65e13ff
Author: Swen Schillig <[EMAIL PROTECTED]>
Date: Fri Feb 9 09:58:09 2007 +0100
removed wrong comment
Signed-off-by: Swen Schillig <[EMAIL PROTECTED]>
---
diff --git a/drivers/s390/scsi/zfcp_erp.c b/drivers/s390/scsi/zfcp_erp.c
i
commit 988d955c3314336d716a9208f3d565b06f262e07
Author: Swen Schillig <[EMAIL PROTECTED]>
Date: Fri Feb 9 09:40:11 2007 +0100
Use of uninitialized variable.
ERP action might not be finished accordingly.
Signed-off-by: Swen Schillig <[EMAIL PROTECTED]>
---
diff --git a/drive
Hi Andreas
No, not those.
We got a possible recursive locking on the adapter->request_queue.queue_lock
Cheers Swen
On Wednesday 07 February 2007 17:06, Andreas Herrmann wrote:
> On Wed, Feb 07, 2007 at 01:17:57PM +0100, Swen Schillig wrote:
> > From: Swen Schillig <[
From: Swen Schillig <[EMAIL PROTECTED]>
Invalid locking order. Kernel hangs after trying to take two locks
which are dependend on each other. Introducing temporary variable
to free requests. Free lock after requests are copied.
Signed-off-by: Swen Schillig <[EMAIL PROTECTED]>
65 matches
Mail list logo
