sizeof(struct MR_PD_CFG_SEQ_NUM_SYNC) + (sizeof(struct MR_PD_CFG_SEQ) *
> (MAX_PHYSICAL_DEVICES - 1))
>
> with:
>
> struct_size(pd_sync, seq, MAX_PHYSICAL_DEVICES - 1)
>
> This code was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva
Acked-
On Wed, May 29, 2019 at 9:30 PM Tomas Henzl wrote:
>
> Use existing macros.
> No functional change.
>
> Signed-off-by: Tomas Henzl
Acked-by: Sumit Saxena
> ---
> drivers/scsi/megaraid/megaraid_sas_base.c | 44 ++-
> 1 file changed, 18 ins
On Wed, May 29, 2019 at 9:30 PM Tomas Henzl wrote:
>
> Checkpatch emits a warning when using symbolic permissions. Use octal
> permissions instead.
> No functional change.
>
> Signed-off-by: Tomas Henzl
Acked-by: Sumit Saxena
> ---
> drivers/scsi/megaraid/
On Wed, May 29, 2019 at 9:30 PM Tomas Henzl wrote:
>
> Support is easier with all driver parameters visible in sysfs.
>
> Signed-off-by: Tomas Henzl
Acked-by: Sumit Saxena
> ---
> drivers/scsi/megaraid/megaraid_sas_base.c | 2 +-
> 1 file changed, 1 insertion(+), 1 delet
On Sat, Jun 1, 2019 at 8:40 AM YueHaibing wrote:
>
> Remove including that don't need it.
>
> Signed-off-by: YueHaibing
Acked-by: Sumit Saxena
> ---
> drivers/scsi/megaraid/megaraid_sas_debugfs.c | 1 -
> 1 file changed, 1 deletion(-)
>
> di
ixes: fb2f3e96d80f ("scsi: megaraid_sas: Fix msleep granularity")
> Signed-off-by: Steve Sistare
Acked-by: Sumit Saxena
> ---
> drivers/scsi/megaraid/megaraid_sas_base.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/me
s_fusion.c:4398:25: warning:
> variable 'fusion' set but not used [-Wunused-but-set-variable]
>
> drivers/scsi/megaraid/megaraid_sas_fusion.c: In function
> 'megasas_reset_target_fusion':
> drivers/scsi/megaraid/megaraid_sas_fusion.c:4484:25: warning:
> var
/0xb0
> [] bus_for_each_dev+0x74/0xc8
> [] driver_attach+0x28/0x34
> [] bus_add_driver+0x16c/0x248
> [] driver_register+0x6c/0x138
> [] __pci_register_driver+0x5c/0x6c
> [] megasas_init+0xc0/0x1a8
> [] do_one_initcall+0xe8/0x1ec
> [] kernel_init_freeable+0x1c8/0x284
> []
ids, 0xff, MEGASAS_MAX_LD_IDS);
>
> From drivers/scsi/megaraid/megaraid_sas_fp.c ,
> /* For non existing VDs, iterate to next VD*/
> if (ld >= (MAX_LOGICAL_DRIVES_EXT - 1))
> continue;
>
> However, there are a few places that failed to skip those non-existing
>
On Mon, Dec 3, 2018 at 2:25 AM Thomas Meyer wrote:
>
> NULL check before some freeing functions is not needed.
>
> Signed-off-by: Thomas Meyer
Acked-by: Sumit Saxena
> ---
>
> diff -u -p a/drivers/scsi/megaraid/megaraid_mbox.c
> b/drivers/scsi/megaraid/megaraid_mbo
quot; annotation and added a dash as a token in order to
> separate the "Fall through" annotation from the rest of the comment
> on the same line, which is what GCC is expecting to find.
>
> Signed-off-by: Gustavo A. R. Silva
Acked-by: Sumit Saxena
> ---
> drive
On Wed, Nov 28, 2018 at 10:02 AM Gustavo A. R. Silva
wrote:
>
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva
Acked-by: Sumit Saxena
> ---
> drivers/scsi/megaraid/me
n->rdpq_virt) {
> dev_err(&instance->pdev->dev,
> "Failed from %s %d\n", __func__, __LINE__);
> @@ -813,7 +813,7 @@ megasas_free_rdpq_fusion(struct megasas_instance
> *instance) {
> dma_pool_destroy(fusion->reply_frames_desc_pool_align);
>
> if (fusion->rdpq_virt)
> - pci_free_consistent(instance->pdev,
> + dma_free_coherent(&instance->pdev->dev,
> sizeof(struct MPI2_IOC_INIT_RDPQ_ARRAY_ENTRY) *
> MAX_MSIX_QUEUES_FUSION,
> fusion->rdpq_virt, fusion->rdpq_phys);
> }
> @@ -2209,7 +2209,7 @@ megasas_set_pd_lba(struct MPI2_RAID_SCSI_IO_REQUEST
> *io_request, u8 cdb_len,
> cdb[0] = MEGASAS_SCSI_VARIABLE_LENGTH_CMD;
> cdb[7] = MEGASAS_SCSI_ADDL_CDB_LEN;
>
> - if (scp->sc_data_direction == PCI_DMA_FROMDEVICE)
> + if (scp->sc_data_direction == DMA_FROM_DEVICE)
> cdb[9] = MEGASAS_SCSI_SERVICE_ACTION_READ32;
> else
> cdb[9] = MEGASAS_SCSI_SERVICE_ACTION_WRITE32;
> @@ -2238,7 +2238,7 @@ megasas_set_pd_lba(struct MPI2_RAID_SCSI_IO_REQUEST
> *io_request, u8 cdb_len,
> cdb[31] = (u8)(num_blocks & 0xff);
>
> /* set SCSI IO EEDPFlags */
> - if (scp->sc_data_direction == PCI_DMA_FROMDEVICE) {
> + if (scp->sc_data_direction == DMA_FROM_DEVICE) {
> io_request->EEDPFlags = cpu_to_le16(
> MPI2_SCSIIO_EEDPFLAGS_INC_PRI_REFTAG |
> MPI2_SCSIIO_EEDPFLAGS_CHECK_REFTAG |
> @@ -2621,7 +2621,7 @@ megasas_build_ldio_fusion(struct megasas_instance
> *instance,
> scsi_buff_len = scsi_bufflen(scp);
> io_request->DataLength = cpu_to_le32(scsi_buff_len);
>
> - if (scp->sc_data_direction == PCI_DMA_FROMDEVICE)
> + if (scp->sc_data_direction == DMA_FROM_DEVICE)
> io_info.isRead = 1;
>
> local_map_ptr = fusion->ld_drv_map[(instance->map_id & 1)];
> @@ -3088,9 +3088,9 @@ megasas_build_io_fusion(struct megasas_instance
> *instance,
>
> io_request->SGLFlags = cpu_to_le16(MPI2_SGE_FLAGS_64_BIT_ADDRESSING);
>
> - if (scp->sc_data_direction == PCI_DMA_TODEVICE)
> + if (scp->sc_data_direction == DMA_TO_DEVICE)
> io_request->Control |= cpu_to_le32(MPI2_SCSIIO_CONTROL_WRITE);
> - else if (scp->sc_data_direction == PCI_DMA_FROMDEVICE)
> + else if (scp->sc_data_direction == DMA_FROM_DEVICE)
> io_request->Control |= cpu_to_le32(MPI2_SCSIIO_CONTROL_READ);
>
> io_request->SGLOffset0 =
Acked-by: Sumit Saxena
> --
> 2.19.1
>
a/drivers/scsi/megaraid/megaraid_sas_base.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_base.c
> @@ -7523,6 +7523,9 @@ static int megasas_mgmt_compat_ioctl_fw(struct file
> *file, unsigned long arg)
> get_user(user_sense_off, &cioc->sense_off))
> return -EFAULT;
>
> + if (local_sense_off != user_sense_off)
> + return -EINVAL;
> +
> if (local_sense_len) {
> void __user **sense_ioc_ptr =
> (void __user **)((u8 *)((unsigned
> long)&ioc->frame.raw) + local_sense_off);
Acked-by: Sumit Saxena
> --
> 2.7.4
>
> -Original Message-
> From: Colin King [mailto:colin.k...@canonical.com]
> Sent: Monday, September 24, 2018 3:56 AM
> To: Kashyap Desai ; Sumit Saxena
> ; Shivasharan S
> ; James E . J . Bottomley
> ; Martin K . Petersen
> ; megaraidlinux@broadcom.com; linux
to_le32(cmd->index);
cmd->frame->io.pad_0 = 0;
if ((instance->adapter_type == MFI_SERIES) &&
reset_devices)
Acked-by: Sumit Saxena
--
1.9.1
-Original Message-
From: Arnd Bergmann [mailto:a...@arndb.de]
Sent: Wednesday, January 17, 2018 8:19 PM
To: Kashyap Desai; Sumit Saxena; Shivasharan S; James E.J. Bottomley;
Martin K. Petersen
Cc: Arnd Bergmann; Tomas Henzl; Hannes Reinecke;
megaraidlinux@broadcom.com; linux-scsi
-Original Message-
From: Kees Cook [mailto:keesc...@chromium.org]
Sent: Wednesday, October 25, 2017 3:37 PM
To: Martin K. Petersen
Cc: Kashyap Desai; Sumit Saxena; Shivasharan S; James E.J. Bottomley;
megaraidlinux@broadcom.com; linux-scsi@vger.kernel.org;
linux-ker...@vger.kernel.org
i_cmds;
/*
Acked-by: Sumit Saxena
--
1.7.12.4
free_pages((ulong)fusion,
instance->ctrl_context_pages);
+ kmemleak_free(fusion);
+ }
}
}
Looks good. Thanks for catching this.
Acked-by: Sumit Saxena
--
2.13.5
>-Original Message-
>From: Hannes Reinecke [mailto:h...@suse.de]
>Sent: Tuesday, August 15, 2017 5:29 PM
>To: Martin K. Petersen
>Cc: Christoph Hellwig; James Bottomley; Sumit Saxena; Kashyap Desai;
>megaraidlinux@broadcom.com; linux-scsi@vger.kernel.org; Hannes
>-Original Message-
>From: Hannes Reinecke [mailto:h...@suse.de]
>Sent: Tuesday, August 15, 2017 5:36 PM
>To: Martin K. Petersen
>Cc: Christoph Hellwig; James Bottomley; Sumit Saxena; Kashyap Desai;
>megaraidlinux@broadcom.com; linux-scsi@vger.kernel.org; Hannes
ce->pd_info)
> dev_err(&instance->pdev->dev, "Failed to alloc mem
>for pd_info\n");
>
>+ instance->tgt_prop = pci_alloc_consistent(pdev,
>+ sizeof(struct MR_TARGET_PROPERTIES), &instance-
>>tgt_prop_h);
>+
> if (!instance->tgt_prop)
> dev_err(&instance->pdev->dev, "Failed to alloc mem
>for tgt_prop\n");
Acked-by: Sumit Saxena
>
>--
>2.9.4
>-Original Message-
>From: Martin K. Petersen [mailto:martin.peter...@oracle.com]
>Sent: Monday, August 07, 2017 11:07 PM
>To: Tomas Henzl
>Cc: linux-scsi@vger.kernel.org; sumit.sax...@broadcom.com;
>kashyap.de...@broadcom.com
>Subject: Re: [PATCH] megaraid_sas: move command counter to corr
mgmt_info.count--;
>- megasas_mgmt_info.instance[megasas_mgmt_info.max_index] =
>NULL;
> megasas_mgmt_info.max_index--;
>+ megasas_mgmt_info.instance[megasas_mgmt_info.max_index] =
>NULL;
>
> instance->instancet->disable_intr(instance);
> megasas_destroy_irqs(instance);
Acked-by: Sumit Saxena
>--
>2.9.4
omplete_r1_command(instance,
>cmd_fusion);
>+ atomic_dec(&instance->fw_outstanding);
> break;
> case MEGASAS_MPI2_FUNCTION_PASSTHRU_IO_REQUEST:
>/*MFI command */
> cmd_mfi = instance->cmd_list[cmd_fusion-
>>sync_cmd_idx];
Acked-by: Sumit Saxena
>--
>2.9.4
or (j = 0; j < i; j++)
>+ kfree(fusion->cmd_list[j]);
>+ kfree(fusion->cmd_list);
> dev_err(&instance->pdev->dev,
> "Failed from %s %d\n", __func__,
__LINE__);
> return -ENOMEM;
> }
> }
>+
> return 0;
> }
> int
Acked-by: Sumit Saxena
>--
>2.5.0
>-Original Message-
>From: Hannes Reinecke [mailto:h...@suse.de]
>Sent: Friday, June 30, 2017 11:46 PM
>To: Christoph Hellwig
>Cc: Martin K. Petersen; James Bottomley; Kashyap Desai; Sumit Saxena;
>linux-
>s...@vger.kernel.org; Hannes Reinecke
>Subject: Re: [PATCH 1
>-Original Message-
>From: Hannes Reinecke [mailto:h...@suse.de]
>Sent: Thursday, June 29, 2017 11:23 AM
>To: Kashyap Desai; Sumit Saxena; Christoph Hellwig
>Cc: Martin K. Petersen; James Bottomley; linux-scsi@vger.kernel.org; Hannes
>Reinecke
>Subject: Re: [PATCH 13/
>-Original Message-
>From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-
>ow...@vger.kernel.org] On Behalf Of Hannes Reinecke
>Sent: Wednesday, June 28, 2017 2:03 PM
>To: Christoph Hellwig
>Cc: Martin K. Petersen; James Bottomley; linux-scsi@vger.kernel.org;
Hannes
>Reinecke; Hannes
Gentle ping.
I have opened kernel BZ for this. Here is the BZ link-
https://bugzilla.kernel.org/show_bug.cgi?id=196057
Thanks,
Sumit
>-Original Message-
>From: Sumit Saxena [mailto:sumit.sax...@broadcom.com]
>Sent: Tuesday, June 06, 2017 9:05 PM
>To: 'Jens Axbo
Gentle ping..
>-Original Message-
>From: Sumit Saxena [mailto:sumit.sax...@broadcom.com]
>Sent: Monday, June 05, 2017 12:59 PM
>To: 'Jens Axboe'
>Cc: 'linux-bl...@vger.kernel.org'; 'linux-scsi@vger.kernel.org'
>Subject: Application stops d
Jens,
We am observing application stops while running ext4 filesystem IOs along
with target reset in parallel.
Our suspect is this behavior can be attributed to linux block layer. See
below for details-
Problem statement - " Application stops due to IO error from file system
buffered IO. (Note -
spin_unlock_irqrestore(&pool->lock, flags);
This is very old driver and reached EOL. Did you face any issue because of
this bug or discover this through code review?
Anyways patch looks good to me.
Acked-by: Sumit Saxena
>
>--
>1.7.9.5
>
es_desc[0] =
>- pci_pool_alloc(fusion->reply_frames_desc_pool,
>+ dma_pool_alloc(fusion->reply_frames_desc_pool,
> GFP_KERNEL, &fusion->reply_frames_desc_phys[0]);
> if (!fusion->reply_frames_desc[0]) {
> dev_err(&instance->pdev->dev,
>@@ -558,8 +552,10 @@ megasas_alloc_rdpq_fusion(struct megasas_instance
>*instance)
> memset(fusion->rdpq_virt, 0,
> sizeof(struct MPI2_IOC_INIT_RDPQ_ARRAY_ENTRY) *
>MAX_MSIX_QUEUES_FUSION);
> count = instance->msix_vectors > 0 ? instance->msix_vectors : 1;
>- fusion->reply_frames_desc_pool = pci_pool_create("mr_rdpq",
>- instance->pdev,
fusion-
>>reply_alloc_sz, 16, 0);
>+ fusion->reply_frames_desc_pool = dma_pool_create("mr_rdpq",
>+
&instance->pdev->dev,
>+
fusion->reply_alloc_sz,
>+ 16, 0);
>
> if (!fusion->reply_frames_desc_pool) {
> dev_err(&instance->pdev->dev,
>@@ -569,7 +565,7 @@ megasas_alloc_rdpq_fusion(struct megasas_instance
>*instance)
>
> for (i = 0; i < count; i++) {
> fusion->reply_frames_desc[i] =
>- pci_pool_alloc(fusion-
>>reply_frames_desc_pool,
>+ dma_pool_alloc(fusion-
>>reply_frames_desc_pool,
> GFP_KERNEL, &fusion-
>>reply_frames_desc_phys[i]);
> if (!fusion->reply_frames_desc[i]) {
> dev_err(&instance->pdev->dev,
>@@ -597,13 +593,12 @@ megasas_free_rdpq_fusion(struct megasas_instance
>*instance) {
>
> for (i = 0; i < MAX_MSIX_QUEUES_FUSION; i++) {
> if (fusion->reply_frames_desc[i])
>- pci_pool_free(fusion->reply_frames_desc_pool,
>+ dma_pool_free(fusion->reply_frames_desc_pool,
> fusion->reply_frames_desc[i],
> fusion->reply_frames_desc_phys[i]);
> }
>
>- if (fusion->reply_frames_desc_pool)
>- pci_pool_destroy(fusion->reply_frames_desc_pool);
>+ dma_pool_destroy(fusion->reply_frames_desc_pool);
>
> if (fusion->rdpq_virt)
> pci_free_consistent(instance->pdev,
>@@ -619,12 +614,11 @@ megasas_free_reply_fusion(struct megasas_instance
>*instance) {
> fusion = instance->ctrl_context;
>
> if (fusion->reply_frames_desc[0])
>- pci_pool_free(fusion->reply_frames_desc_pool,
>+ dma_pool_free(fusion->reply_frames_desc_pool,
> fusion->reply_frames_desc[0],
> fusion->reply_frames_desc_phys[0]);
>
>- if (fusion->reply_frames_desc_pool)
>- pci_pool_destroy(fusion->reply_frames_desc_pool);
>+ dma_pool_destroy(fusion->reply_frames_desc_pool);
>
> }
Acked-by: Sumit Saxena
>
>--
>2.9.3
>-Original Message-
>From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
>Sent: Tuesday, February 14, 2017 10:09 PM
>To: Kashyap Desai; Shivasharan S
>Cc: Sumit Saxena; James E.J. Bottomley; Martin K. Petersen;
>megaraidlinux@broadcom.com; linux-scsi@vger.kernel.o
>-Original Message-
>From: Arnd Bergmann [mailto:a...@arndb.de]
>Sent: Wednesday, February 15, 2017 2:52 AM
>To: James E.J. Bottomley; Martin K. Petersen
>Cc: Arnd Bergmann; Kashyap Desai; Sumit Saxena; Shivasharan S; Tomas
Henzl;
>Hannes Reinecke; Sasikumar Chandrasekar
>-Original Message-
>From: Arnd Bergmann [mailto:a...@arndb.de]
>Sent: Wednesday, February 15, 2017 2:52 AM
>To: James E.J. Bottomley; Martin K. Petersen
>Cc: Arnd Bergmann; Kashyap Desai; Sumit Saxena; Shivasharan S; Tomas
Henzl;
>Hannes Reinecke; Sasikumar Chandrasekar
>-Original Message-
>From: Arnd Bergmann [mailto:a...@arndb.de]
>Sent: Wednesday, February 15, 2017 2:52 AM
>To: James E.J. Bottomley; Martin K. Petersen
>Cc: Arnd Bergmann; Kashyap Desai; Sumit Saxena; Shivasharan S; Tomas
Henzl;
>Hannes Reinecke; Sasikumar Chandrasekar
>-Original Message-
>From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
>Sent: Tuesday, February 14, 2017 10:09 PM
>To: Kashyap Desai; Shivasharan S
>Cc: Sumit Saxena; James E.J. Bottomley; Martin K. Petersen;
>megaraidlinux@broadcom.com; linux-scsi@vger.kernel.o
>-Original Message-
>From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
>Sent: Tuesday, February 14, 2017 9:54 PM
>To: sumit.sax...@avagotech.com
>Cc: megaraidlinux@broadcom.com; linux-scsi@vger.kernel.org
>Subject: [bug report] megaraid_sas: Make PI enabled VD 8 byte DMA aligned
>
>
Adding direct email addresses of few people to avoid any filters.
Hannes/Martin/James/Tomas/Christoph,
Can you please comment on this?
Thanks,
Sumit
>-Original Message-
>From: Sumit Saxena [mailto:sumit.sax...@broadcom.com]
>Sent: Tuesday, December 13, 2016 6:50 PM
>To:
tried.
DID_REQUEUE seems safer to use instead of DID_RESET for all outstanding
commands before doing chip reset as it serves purpose of getting all
commands
to be retried by SCSI layer.
Signed-off-by: Sumit Saxena
Signed-off-by: Kashyap Desai
---
drivers/scsi/megaraid/megaraid_sas_base.c | 4 ++
Bugs/Comments/Suggestions should be mailed to:
>- linuxr...@lsi.com
>-
>- For more information, goto:
>- http://www.lsi.com
[]
>+ aradf...@gmail.com
>
> History
>---
>diff --git a/drivers/scsi/3w-sas.h b/drivers/scsi/3w-sas.h index
>fec6449..05e7
ev, 1,
>+ instance->msix_vectors ?
>+ instance->msix_vectors : 1,
irq_flags);
>+ if (rval < 0)
> goto fail_reenable_msix;
>
> if (instance->ctrl_context) {
>@@ -6330,7 +6
s: request irqs later
>
>>>>>> "Tomas" == Tomas Henzl writes:
>
>Tomas> It is not good when an irq arrives before driver structures are
>Tomas> allocated.
>
>Sumit, Kashyap: Please review!
Looks good.. I think I have acked this patch earlier also.
Acke
>-Original Message-
>From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-
>ow...@vger.kernel.org] On Behalf Of Hannes Reinecke
>Sent: Friday, November 11, 2016 3:15 PM
>To: Martin K. Petersen
>Cc: Christoph Hellwig; James Bottomley; Sumit Saxena; linux-
>s...@vg
>-Original Message-
>From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-
>ow...@vger.kernel.org] On Behalf Of Hannes Reinecke
>Sent: Friday, November 11, 2016 3:15 PM
>To: Martin K. Petersen
>Cc: Christoph Hellwig; James Bottomley; Sumit Saxena; linux-
>s...@vg
>-Original Message-
>From: Hannes Reinecke [mailto:h...@suse.de]
>Sent: Friday, November 11, 2016 3:15 PM
>To: Martin K. Petersen
>Cc: Christoph Hellwig; James Bottomley; Sumit Saxena; linux-
>s...@vger.kernel.org; Hannes Reinecke; Hannes Reinecke
>Subject: [PATCH 1/5]
>-Original Message-
>From: Hannes Reinecke [mailto:h...@suse.de]
>Sent: Friday, November 11, 2016 3:15 PM
>To: Martin K. Petersen
>Cc: Christoph Hellwig; James Bottomley; Sumit Saxena; linux-
>s...@vger.kernel.org; Hannes Reinecke; Hannes Reinecke
>Subject: [PATCH 5
>-Original Message-
>From: Hannes Reinecke [mailto:h...@suse.de]
>Sent: Friday, November 11, 2016 3:15 PM
>To: Martin K. Petersen
>Cc: Christoph Hellwig; James Bottomley; Sumit Saxena; linux-
>s...@vger.kernel.org; Hannes Reinecke; Hannes Reinecke
>Subject: [PATCH 2/5
(all SCSI
commands to channels-1,2,3 was
returned as SUCCESS-DID_OK by driver).
Fixes: 1e793f6fc0db920400574211c48f9157a37e3945
Reported-by: Jens Axboe
CC: sta...@vger.kernel.org
Signed-off-by: Kashyap Desai
Signed-off-by: Sumit Saxena
Tested-by: Sumit Saxena
---
drivers/scsi/megaraid
troy_irqs(instance);
>-fail_setup_irqs:
>+fail_init_adapter:
> if (instance->msix_vectors)
> pci_disable_msix(instance->pdev);
> instance->msix_vectors = 0;
Looks good to me. Acked-by: Sumit Saxena
>--
>2.7.4
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Driver does not send SYNCH_CACHE command to the
FW.
Driver return SUCCESS for that command.
ENDIF
ENDIF
ENDIF
CC: sta...@vger.kernel.org
Signed-off-by: Kashyap Desai
Signed-off-by: Sumit Saxena
---
drivers/scsi/me
Signed-off-by: Sumit Saxena
---
drivers/scsi/megaraid/megaraid_sas.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas.h
b/drivers/scsi/megaraid/megaraid_sas.h
index 43fd14f..1d4de90 100644
--- a/drivers/scsi/megaraid/megaraid_sas.h
+++ b
disable WCE on drive to get similar impact.
4. Always Send SYNCHRONIZE_CACHE for JBOD (non Raid) Device to Firmware.
5. Add log message printing the state of FW sync cache support
6. Moved version update patch to end of series
Sumit Saxena (7):
megaraid_sas: For SRIOV enabled firmware, ensure VF
) driver is directly writing on to the register
instead of waiting for 30 seconds. Setting convert flag to 1 will cause
VF driver will wait for 30 secs before going for reset.
CC: sta...@vger.kernel.org
Signed-off-by: Kiran Kumar Kasturi
Signed-off-by: Sumit Saxena
Reviewed-by: Hannes Reinecke
Reviewed
This patch fixes the issue of wrong PhysArm was sent to firmware for R1
VD downgrade.
Signed-off-by: Kiran Kumar Kasturi
Signed-off-by: Sumit Saxena
Reviewed-by: Hannes Reinecke
Reviewed-by: Tomas Henzl
---
drivers/scsi/megaraid/megaraid_sas_fp.c | 6 --
1 file changed, 4 insertions
, driver will
skip firing DCMDs.
Signed-off-by: Sumit Saxena
Signed-off-by: Shivasharan Srikanteshwara
---
drivers/scsi/megaraid/megaraid_sas_base.c | 39 +
drivers/scsi/megaraid/megaraid_sas_fusion.c | 9 ---
2 files changed, 45 insertions(+), 3 deletions(-)
diff
Update MEGARAID drivers maintainers list.
Signed-off-by: Sumit Saxena
Reviewed-by: Hannes Reinecke
---
MAINTAINERS | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 4c1f3f9..05c0624 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
CC: sta...@vger.kernel.org
Signed-off-by: Sumit Saxena
Reviewed-by: Hannes Reinecke
Reviewed-by: Tomas Henzl
---
drivers/scsi/megaraid/megaraid_sas_fusion.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c
b/drivers/scsi
>-Original Message-
>From: James Bottomley [mailto:j...@linux.vnet.ibm.com]
>Sent: Monday, October 17, 2016 11:22 PM
>To: Kashyap Desai; Ric Wheeler; Hannes Reinecke; Sumit Saxena; linux-
>s...@vger.kernel.org
>Cc: martin.peter...@oracle.com; the...@redhat.com; Christop
>-Original Message-
>From: Ric Wheeler [mailto:ricwhee...@gmail.com]
>Sent: Tuesday, October 18, 2016 6:38 PM
>To: Tomas Henzl; Sumit Saxena; linux-scsi@vger.kernel.org
>Cc: martin.peter...@oracle.com; j...@linux.vnet.ibm.com; Kashyap Desai
>Subject: Re: [PATCH 4/7]
>-Original Message-
>From: Tomas Henzl [mailto:the...@redhat.com]
>Sent: Monday, October 17, 2016 7:27 PM
>To: Sumit Saxena; linux-scsi@vger.kernel.org
>Cc: martin.peter...@oracle.com; j...@linux.vnet.ibm.com; Kashyap Desai
>Subject: Re: [PATCH 4/7] megaraid_sas: Send
>-Original Message-
>From: Ric Wheeler [mailto:rwhee...@redhat.com]
>Sent: Monday, October 17, 2016 6:31 PM
>To: Hannes Reinecke; Sumit Saxena; linux-scsi@vger.kernel.org
>Cc: martin.peter...@oracle.com; the...@redhat.com;
j...@linux.vnet.ibm.com;
>kashyap.de...@broad
>-Original Message-
>From: Tomas Henzl [mailto:the...@redhat.com]
>Sent: Monday, October 17, 2016 6:44 PM
>To: Sumit Saxena; linux-scsi@vger.kernel.org
>Cc: martin.peter...@oracle.com; j...@linux.vnet.ibm.com;
>kashyap.de...@broadcom.com
>Subject: Re: [PATCH 4/
>-Original Message-
>From: Hannes Reinecke [mailto:h...@suse.de]
>Sent: Monday, October 17, 2016 5:05 PM
>To: Sumit Saxena; linux-scsi@vger.kernel.org
>Cc: martin.peter...@oracle.com; the...@redhat.com;
j...@linux.vnet.ibm.com;
>kashyap.de...@broadcom.com
>Su
>-Original Message-
>From: Hannes Reinecke [mailto:h...@suse.de]
>Sent: Monday, October 17, 2016 5:01 PM
>To: Sumit Saxena; linux-scsi@vger.kernel.org
>Cc: martin.peter...@oracle.com; the...@redhat.com;
j...@linux.vnet.ibm.com;
>kashyap.de...@broadcom.com
>Su
>-Original Message-
>From: Hannes Reinecke [mailto:h...@suse.de]
>Sent: Monday, October 17, 2016 5:04 PM
>To: Sumit Saxena; linux-scsi@vger.kernel.org
>Cc: martin.peter...@oracle.com; the...@redhat.com;
j...@linux.vnet.ibm.com;
>kashyap.de...@broadcom.com
>Su
Upgrade driver version.
Signed-off-by: Sumit Saxena
---
drivers/scsi/megaraid/megaraid_sas.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas.h
b/drivers/scsi/megaraid/megaraid_sas.h
index 43fd14f..1d4de90 100644
--- a/drivers/scsi
Do not set MPI2_TYPE_CUDA for JBOD fastpath IOs for firmware which does
not support JBOD sequence map.
CC: sta...@vger.kernel.org
Signed-off-by: Sumit Saxena
Signed-off-by: Kashyap Desai
---
drivers/scsi/megaraid/megaraid_sas_fusion.c | 8
1 file changed, 4 insertions(+), 4 deletions
d user can fallback
to old behavior of returning SYNCHRONIZE_CACHE by driver only without
sending it to firmware.
Signed-off-by: Sumit Saxena
Signed-off-by: Kashyap Desai
---
drivers/scsi/megaraid/megaraid_sas.h| 3 +++
drivers/scsi/megaraid/megaraid_sas_base.c | 14 ++
dr
Update MEGARAID drivers maintainers list.
Signed-off-by: Sumit Saxena
---
MAINTAINERS | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index f0ee7a6..8b9117f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -7612,12 +7612,12 @@ S
This patch fixes the issue of wrong PhysArm was sent to firmware for R1
VD downgrade.
Signed-off-by: Kiran Kumar Kasturi
Signed-off-by: Sumit Saxena
---
drivers/scsi/megaraid/megaraid_sas_fp.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/megaraid
) driver is directly writing on to the register
instead of waiting for 30 seconds. Setting convert flag to 1 will cause
VF driver will wait for 30 secs before going for reset.
CC: sta...@vger.kernel.org
Signed-off-by: Kiran Kumar Kasturi
Signed-off-by: Sumit Saxena
---
drivers/scsi/megaraid
, driver will
skip firing DCMDs.
Signed-off-by: Sumit Saxena
---
drivers/scsi/megaraid/megaraid_sas_base.c | 46 +
drivers/scsi/megaraid/megaraid_sas_fusion.c | 9 --
2 files changed, 52 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/megaraid
Sumit Saxena (7):
megaraid_sas: For SRIOV enabled firmware, ensure VF driver waits for
30secs before reset
megaraid_sas: Send correct PhysArm to FW for R1 VD downgrade
megaraid_sas: Do not fire DCMDs during PCI shutdown/detach
megaraid_sas: Send SYNCHRONIZE_CACHE command to firmware
nce *instance,
> struct megasas_cmd *cmd)
> {
>@@ -2748,8 +2748,9 @@ megasas_check_reset_fusion(struct megasas_instance
>*instance, }
>
> /* This function waits for outstanding commands on fusion to complete */
-int
>megasas_wait_for_outstanding_fusion
egasas_instance *instance);
>+u8 megasas_get_map_info(struct megasas_instance *instance); int
>+megasas_sync_map_info(struct megasas_instance *instance); void
>+megasas_release_fusion(struct megasas_instance *instance); void
>+megasas_reset_reply_desc(struct megasas_instance *instance
>-Original Message-
>From: Colin King [mailto:colin.k...@canonical.com]
>Sent: Monday, September 12, 2016 6:12 PM
>To: Kashyap Desai; Sumit Saxena; Uday Lingala; James E . J . Bottomley;
>Martin K
>. Petersen; megaraidlinux@avagotech.com; linux-scsi@vger.kernel.
instance->bar = find_first_bit(&bar_list, BITS_PER_LONG);
> if (pci_request_selected_regions(instance->pdev, 1<bar,
>"megasas: LSI")) {
> dev_printk(KERN_DEBUG, &instance->pdev->dev, "IO memory
&
>-Original Message-
>From: SF Markus Elfring [mailto:elfr...@users.sourceforge.net]
>Sent: Sunday, August 21, 2016 2:19 PM
>To: linux-scsi@vger.kernel.org; megaraidlinux@avagotech.com; James E.
>J.
>Bottomley; Kashyap Desai; Martin K. Petersen; Sumit Saxena; Uday
which do not
support it and send DCMD SUCCESS status to AEN function so that it can go ahead
with other event
processing.
Reported-by: Lucz Geza
Cc:
Signed-off-by: Sumit Saxena
---
drivers/scsi/megaraid/megaraid_sas_base.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/scsi
Please ignore this patch. I missed to add megaraid_sas in subject line. I
realized after sending. Will be resending with proper subject. Sorry for
spamming.
> -Original Message-
> From: Sumit Saxena [mailto:sumit.sax...@broadcom.com]
> Sent: Friday, July 08, 2016 3:5
support it and send DCMD SUCCESS status to AEN function so that it can go ahead
with other event
processing.
Reported-by: Lucz Geza
Cc:
Signed-off-by: Sumit Saxena
---
drivers/scsi/megaraid/megaraid_sas_base.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/scsi/megaraid
> -Original Message-
> From: Finn Thain [mailto:fth...@telegraphics.com.au]
> Sent: Friday, May 13, 2016 1:14 PM
> To: Sumit Saxena
> Cc: Dan Carpenter; Petros Koutoupis; kashyap.de...@avagotech.com;
> sumit.sax...@avagotech.com; uday.ling...@avagotech.co
> -Original Message-
> From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
> Sent: Thursday, May 12, 2016 12:05 PM
> To: Petros Koutoupis
> Cc: Sumit Saxena; Finn Thain; kashyap.de...@avagotech.com;
> sumit.sax...@avagotech.com; uday.ling...@avagotech.co
> -Original Message-
> From: Petros Koutoupis [mailto:pet...@petroskoutoupis.com]
> Sent: Tuesday, May 10, 2016 2:59 AM
> To: Sumit Saxena; Dan Carpenter; Finn Thain
> Cc: kashyap.de...@avagotech.com; sumit.sax...@avagotech.com;
> uday.ling...@avagotech.com; megaraidlinux
> -Original Message-
> From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
> Sent: Monday, May 09, 2016 1:36 PM
> To: Finn Thain
> Cc: Petros Koutoupis; kashyap.de...@avagotech.com;
> sumit.sax...@avagotech.com; uday.ling...@avagotech.com;
> megaraidlinux@avagotech.com; linux-scsi@vge
> -Original Message-
> From: Andy Lutomirski [mailto:l...@kernel.org]
> Sent: Tuesday, May 03, 2016 10:55 PM
> To: Kashyap Desai; Sumit Saxena; Uday Lingala
> Cc: megaraidlinux@avagotech.com; linux-scsi@vger.kernel.org; Andy
> Lutomirski
> Subject: [PATCH v2] me
Signed-off-by: Sumit Saxena
---
drivers/scsi/megaraid/megaraid_sas.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas.h
b/drivers/scsi/megaraid/megaraid_sas.h
index 1784b09..ca86c88 100644
--- a/drivers/scsi/megaraid/megaraid_sas.h
+++ b
made. e.g. fusion adapters support task abort and
target reset
so task abort and target reset should be issued to fusion adapters only and
for MFI adapters,
print a message saying feature not supported.
Signed-off-by: Sumit Saxena
---
drivers/scsi/megaraid/megaraid_sas_base.c | 67
not get completion and
the same command will be in
outstanding/pendingcommands list of driver and refires same command from IO
timeout thread after chip reset
which will again FAULT firmware and evntually causes kill adapter.
Signed-off-by: Sumit Saxena
---
drivers/scsi/megaraid
2. Do not allocate memory for system info buffer and PD info buffer.
3. Disable performance oriented features e.g. Disable RDPQ mode, disable dual
queue depth,
restrict to single MSI-x vector.
Signed-off-by: Sumit Saxena
---
drivers/scsi/megaraid/megaraid_sas.h| 2 ++
drivers/scsi/meg
This patchset has few small fixes/optimizations. Please consider this
for next release.
Sumit Saxena (4):
megaraid_sas: reduce memory footprints in kdump mode
megaraid_sas: call ISR function to clean up pending replies in OCR
path
megaraid_sas: task management code optimizations
> -Original Message-
> From: Colin King [mailto:colin.k...@canonical.com]
> Sent: Sunday, March 20, 2016 10:34 PM
> To: Kashyap Desai; Sumit Saxena; James Bottomley; Martin K . Petersen;
> megaraidlinux@avagotech.com; linux-scsi@vger.kernel.org
> Cc: linux-ker.
> -Original Message-
> From: Arnd Bergmann [mailto:a...@arndb.de]
> Sent: Monday, March 14, 2016 8:00 PM
> To: martin.peter...@oracle.com; james.bottom...@hansenpartnership.com;
> Kashyap Desai; Sumit Saxena; Uday Lingala; James E.J. Bottomley
> Cc: linux-scsi@vger.ker
as: MFI IO timeout handling
Killing adapter in case of this DCMD failure should be limited to Fusion
adapters only. Per controller's instance variable allow_fw_scan is removed
as pd_list_not_supported better reflect the purpose.
Signed-off-by: Sumit Saxena
---
drivers/scsi/megaraid/megaraid_
> -Original Message-
> From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
> Sent: Monday, February 08, 2016 11:52 PM
> To: sumit.sax...@avagotech.com
> Cc: megaraidlinux@avagotech.com; linux-scsi@vger.kernel.org
> Subject: re: megaraid_sas: Task management suppo
> -Original Message-
> From: Martin K. Petersen [mailto:martin.peter...@oracle.com]
> Sent: Thursday, February 04, 2016 8:07 AM
> To: Sumit Saxena
> Cc: Martin K. Petersen; Maurizio Lombardi; sumit.sax...@broadcom.com;
> kashyap.de...@broadcom.com; uday.ling...@broadc
1 - 100 of 235 matches
Mail list logo
