Hi Chris and Mita,
We will review and test the below patches early next week.
Thanks,
Maya
> On Tue, Nov 18, 2014 at 11:02:44PM +0900, Akinobu Mita wrote:
>> This patch series includes two fixes for UFS driver.
>>
>> The first patch already got reviewed and it was a part of Dolev's
>> various
>>
Reviewed-by: Maya Erez
> Contains a couple of bug fixes reported by Akinobu Mita, In adition to
> "static checker" warnings reported by Dan Carpenter.
>
> Akinobu Mita (1):
> scsi: ufs: fix reference counting of W-LUs
>
> Dolev Raviv (4):
> scsi: ufs: fix static checker errors in ufshcd_syste
Tested with error injection.
Tested-by: Maya Erez
> Error handling in UFS driver is broken and resets the host controller
> for fatal errors without re-initialization. Correct the fatal error
> handling sequence according to UFS Host Controller Interface (HCI)
> v1.1 specification.
>
> o Upon de
Tested with error injection.
Tested-by: Maya Erez
> As of now SCSI initiated error handling is broken because,
> the reset APIs don't try to bring back the device initialized and
> ready for further transfers.
>
> In case of timeouts, the scsi error handler takes care of handling aborts
> and re
Tested-by: Maya Erez
> Currently, sending Task Management (TM) command to the card might
> be broken in some scenarios as listed below:
>
> Problem: If there are more than 8 TM commands the implementation
> returns error to the caller.
> Fix: Wait for one of the slots to be emptied a
Tested-by: Maya Erez
> There is a possible race condition in the hardware when the abort
> command is issued to terminate the ongoing SCSI command as described
> below:
>
> - A bit in the door-bell register is set in the controller for a
> new SCSI command.
> - In some rare situations, before c
Tested-by: Maya Erez
> Add runtime PM helpers to suspend/resume UFS controller at runtime.
> Enable runtime PM by default for pci and platform drivers as the
> initialized hardware can suspend if it is not used after bootup.
>
> Signed-off-by: Sujit Reddy Thumma
> ---
> drivers/scsi/ufs/ufshcd-
Tested-by: Maya Erez
> Background operations in the UFS device can be disabled by
> the host to reduce the response latency of transfer requests.
> Add support for enabling/disabling the background operations
> during runtime suspend/resume of the device.
>
> If the device is in critical need of
Tested-by: Maya Erez
> As part of device initialization sequence, sending NOP OUT UPIU and
> waiting for NOP IN UPIU response is mandatory. This confirms that the
> device UFS Transport (UTP) layer is functional and the host can configure
> the device with further commands. Add support for sendin
Tested-by: Maya Erez
> From: Dolev Raviv
>
> Allow UFS device to complete its initialization and accept
> SCSI commands by setting fDeviceInit flag. The device may take
> time for this operation and hence the host should poll until
> fDeviceInit flag is toggled to zero. This step is mandated by
Hi,
I tested the new set of patches (v4 1-6) and it works.
Thanks,
Maya
> Simplify operations with hiding mmio_base.
>
> Signed-off-by: Seungwon Jeon
> Tested-by: Maya Erez
> ---
> drivers/scsi/ufs/ufshcd.c | 105
> +++--
> drivers/scsi/ufs/ufshcd.h |
Tested-by: Maya Erez
> From: Dolev Raviv
>
> Allow UFS device to complete its initialization and accept SCSI
> commands by setting fDeviceInit flag. The device may take time
> for this operation and hence the host should poll until fDeviceInit
> flag is toggled to zero. This step is mandated by
> On Monday, May 06, 2013, Sujit Reddy Thumma wrote:
>> On 5/6/2013 11:07 AM, Seungwon Jeon wrote:
>> > Link start-up requires long time with multiphase handshakes
>> > between UFS host and device. This affects driver's probe time.
>> > This patch let link start-up run asynchronously. Link start-u
Tested-by: Maya Erez
> There is no need to check the version to clear
> the interrupt status. And the order is changed
> prior to actual handling.
>
> Signed-off-by: Seungwon Jeon
> ---
> drivers/scsi/ufs/ufshcd.c |5 +
> 1 files changed, 1 insertions(+), 4 deletions(-)
>
> diff --git a
Tested-by: Maya Erez
> As part of device initialization sequence, sending NOP OUT UPIU and
> waiting for NOP IN UPIU response is mandatory. This confirms that the
> device UFS Transport (UTP) layer is functional and the host can configure
> the device with further commands. Add support for sendin
Tested-by: Maya Erez
>>> diff --git a/drivers/scsi/ufs/Kconfig b/drivers/scsi/ufs/Kconfig
>>> index 35faf24..82417d6 100644
>>> --- a/drivers/scsi/ufs/Kconfig
>>> +++ b/drivers/scsi/ufs/Kconfig
>>> @@ -35,6 +35,7 @@
>>> config SCSI_UFSHCD
>>> tristate "Universal Flash Storage Controller Dr
Tested-by: Maya Erez
> Implements to support the following operations.
> Currently, this patch doesn't introduce DME_ENABLE and DME_RESET
> because host controller's HCE enable contains these roles.
>
> DME_POWERON{OFF}, DME_HIBERNATE_ENTER{EXIT}, DME_ENDPOINTRESET.
>
> Signed-off-by: Seungwon Je
Tested-by: Maya Erez
> Implements to support Get and Set operation of the DME.
> And along with these operations, IDs of Attribute are added.
> It is used to configure the behavior of the UNIPRO.
>
> Signed-off-by: Seungwon Jeon
> ---
> drivers/scsi/ufs/ufshcd.c | 84 +
Hi James,
Can you please merge this patch?
Thanks,
Maya
> It makes interrupt setting more flexible especially
> for disabling. And wrong bit mask is fixed for ver 1.0.
> [17:16] is added for mask.
>
> Signed-off-by: Seungwon Jeon
> Tested-by: Maya Erez
> ---
> drivers/scsi/ufs/ufshcd.c | 84
Hi James,
Can you please merge this patch?
Thanks,
Maya
> It makes interrupt setting more flexible especially
> for disabling. And wrong bit mask is fixed for ver 1.0.
> [17:16] is added for mask.
>
> Signed-off-by: Seungwon Jeon
> Tested-by: Maya Erez
> ---
> drivers/scsi/ufs/ufshcd.c | 84
Hi James,
Can you please merge this patch on top of the query requests patch?
Thanks,
Maya
> Simplify operations with hiding mmio_base.
>
> Signed-off-by: Seungwon Jeon
> Tested-by: Maya Erez
> ---
> drivers/scsi/ufs/ufshcd.c | 105
> +++--
> drivers/sc
Hi,
The proposed fix fixes the timeout crash.
In normal operation the patch works, so after applying the fix you can add
my Tested-By.
One additional minor fix that is required:
In ufshcd_link_startup the following print-out is printed in success as well:
dev_err(hba->dev, "link startup failed %d
Hi,
ufshcd_pci_shutdown (in ufshcd_pci.c) is using ufshcd_hba_stop so it
cannot be moved to ufshcd.c.
Sorry for missing it last time I tested, I returned ufshcd_hba_stop to
ufshcd.h by mistake when I resolved conflicts of the next patch so I
didn't hit the compilation errors.
Thanks,
Maya
> Move
Hi,
Can you please rebase the next version on top of the following patches
which are the next candidates for merge?
Vinayak Holikatti (2):
ufs: Add Platform glue driver for ufshcd
ufs: Correct the expected data transfersize
Dolev Raviv (1):
scsi: ufs: add support for query requests
Thanks,
Tested-by: Maya Erez
> Add uic command operations including DME_XXX series.
>
> Signed-off-by: Seungwon Jeon
> ---
> drivers/scsi/ufs/ufs-attrs.h | 129
> drivers/scsi/ufs/ufshcd.c| 220
> +-
> drivers/scsi/ufs/ufshcd.h|
Tested-by: Maya Erez
> Patch looks good but one minor comment below.
>
> On 4/24/2013 9:36 PM, Seungwon Jeon wrote:
>> It makes interrupt setting more flexible especially
>> for disabling. And wrong bit mask is fixed for ver 1.0.
>> [17:16] is added for mask.
>>
>> Signed-off-by: Seungwon Jeon
>
Tested-by: Maya Erez
I also tend to agree with Sujit on the order of the wrappers parameters.
Thanks,
Maya
> On 4/26/2013 10:36 AM, Seungwon Jeon wrote:
>> Hi,
>>
>> On Thursday, April 25, 2013, Sujit Reddy Thumma wrote:
>>> On 4/24/2013 9:36 PM, Seungwon Jeon wrote:
Simplify operations wi
Tested-by: Maya Erez
>
> Looks good. Reviewed-by: Subhash Jadavani
>
> On 4/24/2013 9:36 PM, Seungwon Jeon wrote:
>> Move the ufshcd_hba_stop from header file.
>>
>> Signed-off-by: Seungwon Jeon
>> ---
>> drivers/scsi/ufs/ufshcd.c |9 +
>> drivers/scsi/ufs/ufshcd.h |9 -
Hi James,
Can this patch be poushed to 3.9+ merge window?
Thnaks,
Maya
> This patch corrects the expected data transfer size of the
> command UPIU. The current implementation of cmd->transfersize
> is wrong as it probably equal to sector size. With this
> implementation the transfer size is updat
Hi James,
Can this patch be poushed to 3.9+ merge window?
Thnaks,
Maya
> This patch adds Platform glue driver for ufshcd.
>
> Reviewed-by: Arnd Bergmann
> Reviewed-by: Namjae Jeon
> Reviewed-by: Subhash Jadavani
> Reviewed-by: Sujit Reddy Thumma
> Tested-by: Maya Erez
> Signed-off-by: Vinaya
Tested-by: Maya Erez
> Hi James,
>
> look like these patches are fine. Can you please integrate these
> patches in your tree.
>
>
> On Tue, Feb 5, 2013 at 10:17 PM, wrote:
>> From: Vinayak Holikatti
>>
>> This patch set adds following features
>> - Seggregate PCI specific code in ufshcd.c and
31 matches
Mail list logo
