Re: [PATCH v4 02/10] ufs: sysfs: device descriptor

2018-02-04 Thread gre...@linuxfoundation.org
On Sun, Feb 04, 2018 at 09:03:25AM +, Stanislav Nijnikov wrote: > > -Original Message- > > From: Bart Van Assche > > Sent: Friday, February 2, 2018 6:32 PM > > To: gre...@linuxfoundation.org > > Cc: linux-scsi@vger.kernel.org; linux-ker...@vger.kernel.org

Re: [PATCH v4 02/10] ufs: sysfs: device descriptor

2018-02-01 Thread gre...@linuxfoundation.org
On Fri, Feb 02, 2018 at 12:25:46AM +, Bart Van Assche wrote: > On Thu, 2018-02-01 at 18:15 +0200, Stanislav Nijnikov wrote: > > +enum ufs_desc_param_size { > > + UFS_PARAM_BYTE_SIZE = 1, > > + UFS_PARAM_WORD_SIZE = 2, > > + UFS_PARAM_DWORD_SIZE= 4, > > + UFS_PARAM_QWORD_SIZE

Re: [PATCH 1/2 v3] scsi: ufs: introduce static sysfs entries

2017-12-21 Thread gre...@linuxfoundation.org
On Wed, Dec 20, 2017 at 09:37:39PM -0500, Martin K. Petersen wrote: > > >> For future patch series submissions, please include a cover letter > >> that explains the purpose of the patch series and please also > >> document the changes between the different versions of the patch > >> series in the

Re: [PATCH 2/2 v2] scsi: ufs: use sysfs entry for health info

2017-12-20 Thread gre...@linuxfoundation.org
On Tue, Dec 19, 2017 at 02:46:44PM -0800, Jaegeuk Kim wrote: > >From 3368207da5988b8fed4e41e6c0f49a60ac014222 Mon Sep 17 00:00:00 2001 > From: Jaegeuk Kim > Date: Tue, 26 Sep 2017 20:53:48 -0700 > Subject: [PATCH 2/2] scsi: ufs: introduce sysfs entries exposing UFS health > info > > This patch a

Re: UFS utilities

2017-12-05 Thread gre...@linuxfoundation.org
On Tue, Dec 05, 2017 at 03:44:19PM +, Bean Huo (beanhuo) wrote: > Hi, greg k-h > > > > >So what UFS commands are you missing that you need to see implemented? > > > >And again, have you checked the different forks of the driver? > > > > Seems there is something misunderstood, I want to use UP

Re: [EXT] Re: UFS utilities

2017-12-04 Thread gre...@linuxfoundation.org
On Mon, Dec 04, 2017 at 03:20:34PM +, Bean Huo (beanhuo) wrote: > Hi, Bart > Sorry for later! > > > >Hello Bean, > > > >Please be more specific. What is inconvenient about sg3_utils on embedded > >ARM systems? > > > Exactly, I don't know how to compile sg3_utils with static library, instead >

Re: [PATCH] scsi: fix race condition when removing target

2017-11-30 Thread gre...@linuxfoundation.org
On Thu, Nov 30, 2017 at 04:08:38PM +, Bart Van Assche wrote: > On Thu, 2017-11-30 at 09:18 +0800, Jason Yan wrote: > > Hi Bart, I chose the approach in my patch because it has been used in > > scsi_device_get() for years and been proved safe. I think using > > kobject_get_unless_zero() is safe

Re: [PATCH] scsi: fix race condition when removing target

2017-11-29 Thread gre...@linuxfoundation.org
On Wed, Nov 29, 2017 at 05:20:50PM +0100, h...@lst.de wrote: > On Wed, Nov 29, 2017 at 04:18:30PM +, Bart Van Assche wrote: > > As the above patch description shows it can happen that the SCSI core calls > > get_device() after the device reference count has reached zero and before > > the memor

Re: [PATCH] scsi: fix race condition when removing target

2017-11-29 Thread gre...@linuxfoundation.org
On Wed, Nov 29, 2017 at 04:18:30PM +, Bart Van Assche wrote: > On Wed, 2017-11-29 at 11:05 +0800, Jason Yan wrote: > > In commit fbce4d97fd43 ("scsi: fixup kernel warning during rmmod()"), we > > removed scsi_device_get() and directly called get_device() to increase > > the refcount of the devi

Re: [PATCH 1/1] scsi: ufs: changing maintainer

2017-07-18 Thread Greg Kroah-Hartman (gre...@linuxfoundation.org)
On Tue, Jul 18, 2017 at 09:15:58AM +, Prabu Thangamuthu wrote: > As per internal decision, Joao Pinto will be maintainer for DWC UFS driver. That's "odd", does Joao want this? Do you want this? thanks, greg k-h

Re: [PATCH 08/29] drivers, md: convert mddev.active from atomic_t to refcount_t

2017-03-08 Thread gre...@linuxfoundation.org
On Wed, Mar 08, 2017 at 09:42:09AM +, Reshetova, Elena wrote: > > On Mon, Mar 06, 2017 at 04:20:55PM +0200, Elena Reshetova wrote: > > > refcount_t type and corresponding API should be > > > used instead of atomic_t when the variable is used as > > > a reference counter. This allows to avoid ac

Re: [PATCH v2] st: convert DRIVER_ATTR macros to DRIVER_ATTR_RO

2015-06-24 Thread Greg KH (gre...@linuxfoundation.org)
On Wed, Jun 24, 2015 at 06:54:35AM +, Seymour, Shane M wrote: > > Convert DRIVER_ATTR macros to DRIVER_ATTR_RO requested by > Greg KH. Also switched to using scnprintf instead of snprintf > per Documentation/filesystems/sysfs.txt. > > Suggested-by: Greg Kroah-Hartman > Signed-off-by: Shane S

Re: [PATCH] st: convert DRIVER_ATTR macros to DRIVER_ATTR_RO

2015-06-24 Thread Greg KH (gre...@linuxfoundation.org)
On Wed, Jun 24, 2015 at 03:25:57PM +0900, Sergey Senozhatsky wrote: > On (06/24/15 06:10), Seymour, Shane M wrote: > [..] > > > > /* The sysfs driver interface. Read-only at the moment */ > > -static ssize_t st_try_direct_io_show(struct device_driver *ddp, char *buf) > > +static ssize_t try_dire

Re: [PATCH] st: convert DRIVER_ATTR macros to DRIVER_ATTR_RO

2015-06-24 Thread Greg KH (gre...@linuxfoundation.org)
On Wed, Jun 24, 2015 at 03:25:57PM +0900, Sergey Senozhatsky wrote: > On (06/24/15 06:10), Seymour, Shane M wrote: > [..] > > > > /* The sysfs driver interface. Read-only at the moment */ > > -static ssize_t st_try_direct_io_show(struct device_driver *ddp, char *buf) > > +static ssize_t try_dire

Re: [PATCH v3] uas: replace WARN_ON_ONCE() with lockdep_assert_held()

2014-08-19 Thread gre...@linuxfoundation.org
On Tue, Aug 19, 2014 at 06:33:04AM +, Sharma, Sanjeev wrote: > Hi Greg, > > Any feedback on this patch ? The merge window ended 2 days ago, _and_ I'm at the kernel summit this week, _and_ my queue is currently sitting at: $ mdfrm -c ~/mail/todo/ 1317 messages in /home/gregkh/m