Re: [PATCH] dc395x: Fix support for highmem

2005-03-31 Thread gl
On Wed, 30 Mar 2005, James Bottomley wrote: > On Wed, 2005-03-30 at 23:22 +0200, Guennadi Liakhovetski wrote: > > What is going to happen to this stuff? The current Linus' tree contains a > > broken (by me:-() dc395x, other drivers (including tmscsim) would benefit > > from a generic API. I unders

Re: [PATCH] dc395x: Fix support for highmem

2005-03-21 Thread gl
On Mon, 21 Mar 2005, Jens Axboe wrote: > On Mon, Mar 21 2005, [EMAIL PROTECTED] wrote: > > On Mon, 21 Mar 2005, Jens Axboe wrote: > > > > > easily doable. I made a suggestion earlier in the thread, you need to do > > > something ala > > > > > > sg_map_each_entry(sglist, entries, sg, ouput_

Re: [PATCH] dc395x: Fix support for highmem

2005-03-21 Thread gl
On Mon, 21 Mar 2005, Jens Axboe wrote: > On Sun, Mar 20 2005, Guennadi Liakhovetski wrote: > > > > char *kmap_atomic_sg(struct scatterlist *sg, unsigned int offset, int > > *mapped); > > void kunmap_atomic_sg(struct scatterlist *sg, int mapped); > > > > The latter would just call the kunmap_atomi

Re: [PATCH] dc395x: Fix support for highmem

2005-03-17 Thread gl
On Thu, 17 Mar 2005, Jens Axboe wrote: > See the kmap implementation, mm/highmem.c:map_new_virtual() to be > precise. If you run out of entries while processing your sglist, you > will end up waiting on a free kmap entry for an sg entry that will not > become available before your previous kmaps a

Re: [PATCH] dc395x: Fix support for highmem

2005-03-17 Thread gl
Hi On Thu, 17 Mar 2005, Jens Axboe wrote: > On Wed, Mar 16 2005, Guennadi Liakhovetski wrote: > > > > On Wed, 16 Mar 2005, Jens Axboe wrote: > > > The kmap() isn't just inefficient, it's a problem to iterate over the sg > > > list and kmap all the pages. That is illegal. > > > > Hm, what do you m