On 2019-10-21 23:28, Hannes Reinecke wrote:
> On 10/21/19 6:41 PM, Bart Van Assche wrote:
>> On 10/21/19 2:53 AM, Hannes Reinecke wrote:
>>> We should return the actual error code in st_scsi_execute(),
>>> avoiding the need to use DRIVER_ERROR.
>>>
q, disk, rq, 0);
Since sg_scsi_ioctl() is used to implement SCSI_IOCTL_SEND_COMMAND, does
this patch change the ABI between user space and kernel in a
backwards-incompatible way?
Thanks,
Bart.
. Is it perhaps because the
caller compares the st_scsi_execute() return value with zero and doesn't
use the return value in any other way that it is fine to return an
integer error code instead of a SCSI status?
Thanks,
Bart.
Same comment here: did you really want to delete the code that sets
DRIVER_SENSE?
Thanks,
Bart.
ent about DRIVER_SENSE also apply to this patch?
Thanks,
Bart.
+ err = -EIO;
> + goto out;
> + }
> +
> switch (sshdr->sense_key) {
> case UNIT_ATTENTION:
> SDev->changed = 1;
Shouldn't this be a separate patch?
Thanks,
Bart.
ntribute the test case to the blktests project. Anyway:
Reviewed-by: Bart Van Assche
callers but not for all callers of scsi_execute(). How about
changing the comment into something like the following: "Zero-initialize
sshdr for those callers that check the *sshdr contents even if no sense
data is available"?
Thanks,
Bart.
On 10/10/19 8:07 PM, zhengbin (A) wrote:
Besides, scsi_sense_hdr is just 8 bytes, memset it to 0 will not affect
performance
That's true ...
Bart.
__scsi_execute() is the best approach. I'm wondering
whether the sr driver should be fixed instead of modifying __scsi_execute().
Thanks,
Bart.
Cc:
Fixes: 085e56766f74 ("scsi: ch: add refcounting")
Signed-off-by: Bart Van Assche
---
drivers/scsi/ch.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/ch.c b/drivers/scsi/ch.c
index 5f8153c37f77..76751d6c7f0d 100644
--- a/drivers/scsi/ch.c
+++ b/drivers/scsi/ch.c
@@
ly and don't need to
evaluate the RTPG data (which we won't have anyway).
Reviewed-by: Bart Van Assche
On 10/9/19 2:32 AM, Ming Lei wrote:
Cc: Bart Van Assche
As one can see in the .mailmap file in the kernel tree I use my @acm.org
email address for kernel contributions. The above email address is no
longer valid since I left WDC more than a year ago.
Otherwise this patch looks fine to me
up())? Have you
considered to enable/disable busy tracking per LUN depending on whether
or not sdev->queue_depth < shost->can_queue?
The megaraid and mpt3sas drivers read sdev->device_busy directly. Is the
current version of this patch compatible with these drivers?
Thanks,
Bart.
unsigned long flags;
>
> rcu_read_lock();
> - atomic_dec(&shost->host_busy);
> + clear_bit(SCMD_STATE_INFLIGHT, &cmd->state);
If a new state variable would be introduced for SCSI commands, would it
be possible to use non-atomic operations to set and clear
SCMD_STATE_INFLIGHT? In other words, are any of the functions that
modify this bit ever called concurrently?
Thanks,
Bart.
nown problems are fixed in your tree.
>
> v2: check loop condition only once (Bart van Assche)
>
> Commit message follows:
>
> Fix two issues with the previously submitted patch
> "qla2xxx: Optimize NPIV tear down process": a missing negation
> in a wait_eve
> 0" check useful? I don't think that sysfs ever passes
count == 0 to store callback functions.
Thanks,
Bart.
in scsi_eh_prep_cmnd() after saving the original
command value in struct scsi_eh_save.
Reviewed-by: Bart Van Assche
On 10/2/19 8:25 AM, Martin Wilck wrote:
> On Wed, 2019-10-02 at 08:17 -0700, Bart Van Assche wrote:
>>
>> Both loops check the loop termination condition twice. Has it been
>> considered to write these loops such that the loop termination
>> condition
>> is
> - for (i = 0; i < 10; i++)
> + for (i = 0; !test_fcport_count(vha) && i < 10; i++)
> wait_event_timeout(vha->fcport_waitQ, test_fcport_count(vha),
> HZ);
Hi Martin,
Both loops check the loop termination condition twice. Has it been
considered to write these loops such that the loop termination condition
is only tested once, e.g. using the following pattern?
for (i = 0; i < 10; i++)
if (wait_event_timeout(...) > 0)
break;
Thanks,
Bart.
c, vha, 0xf087,
Hi Himanshu,
Is qla2x00_async_iocb_timeout() called if no response is received for a
LOGO request? If so, has it been considered to modify that function
instead of qlt_free_session_done()?
Thanks,
Bart.
s @ %p\n", dif_size, dif_storep);
+ pr_err("dif_storep %u bytes @ %pK\n", dif_size, dif_storep);
if (dif_storep == NULL) {
pr_err("out of mem. (DIX)\n");
Is it useful to print the kernel pointer 'dif_storep'?
Thanks,
Bart.
On 2019-09-26 09:22, Ryan Attard wrote:
> Add sysfs attributes for the ATA information page and
> Supported VPD Pages page.
Reviewed-by: Bart Van Assche
d related
variables? Otherwise this patch looks fine to me.
Thanks,
Bart.
sable depth for disk events */
The "_on" part in the variable name "rpm_autosuspend_on" is probably
redundant and the comment could have been more elaborate. Anyway:
Reviewed-by: Bart Van Assche
ufs_mtk_set_caps() function. Introducing single line
functions like is done in this patch doesn't improve readability.
Thanks,
Bart.
ly occurs in struct scsi_device then LLD authors are forced to
introduce a slave_configure function. Introducing such a function can be
avoided if the default autosuspend delay can be specified in the host
template.
Bart.
t a perceived session freeze on the initiators.
Hi Roman,
Has this patch series been prepared against Linus' master branch,
against Martin's 5.3/scsi-fixes or against Martin's 5.4/scsi-queue
branch? I'm asking this because some patches in this series look similar
to patches that are already present in the 5.4/scsi-queue branch.
Thanks,
Bart.
the reported issue?
Thanks,
Bart.
the
reference leak present in the current code. Have you considered to
modify tcm_loop_port_link() such that it saves the pointer returned by
scsi_add_device() and to use that pointer in tcm_loop_port_unlink()?
Bart.
)
qla24xx_process_response_queue+0x7d8/0xbd0 [qla2xxx]
qla25xx_free_rsp_que+0x1a0/0x220 [qla2xxx]
process_one_work+0x25c/0x520
worker_thread+0x8c/0x5e0
kthread+0x154/0x1a0
ret_from_kernel_thread+0x5c/0x7c
Cc: Himanshu Madhani
Cc: Abdul Haleem
Reported-and-tested-by: Abdul Haleem
Signed-off-by: Bart
fset 17 lines).
Hunk #2 FAILED at 618.
1 out of 2 hunks FAILED -- saving rejects to file
drivers/scsi/scsi_lib.c.rej
(Stripping trailing CRs from patch; use --binary to disable.)
patching file drivers/scsi/scsi_sysfs.c
Hunk #1 succeeded at 1392 (offset -18 lines).
Bart.
On 8/14/19 6:50 PM, zhengbin (A) wrote:
ping
Sending a "ping" after 46 hours is way too soon and only causes
irritation. What would help though is more information about how this
patch has been tested. Does it e.g. survive the srp tests in blktests?
Thanks,
Bart.
; /* offset 20/14h */
u8 vendor_pn[SFF_PART_NAME_LEN];/* part number */
So I think that using SFF_PART_NAME_LEN+1 as length limit is wrong.
Himanshu, do you perhaps know whether or not the vendor_name and
vendor_pn arrays should be '\0'-terminated in struct sff_8247_a0?
Thanks,
Bart.
On 8/12/19 1:52 PM, Roman Bolshakov wrote:
On Thu, Aug 08, 2019 at 08:02:07PM -0700, Bart Van Assche wrote:
Avoid that this function crashes if mcmd == NULL.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_target.c | 2 +-
1 file changed, 1 insertion(+), 1
bool ret' variable really necessary?
Additionally, have you taken a look at the
cancel_work_sync(&sdev->requeue_work) call in __scsi_remove_device()?
Shouldn't the queue refcount be dropped if that cancel call cancels
queued work?
Thanks,
Bart.
!list_empty(&sdev->host->starved_list))
> kblockd_schedule_work(&sdev->requeue_work);
> - else
> + else {
> blk_mq_run_hw_queues(q, true);
> + percpu_ref_put(&q->q_usage_counter);
> + }
>
> - percpu_ref_put(&q->q_usage_counter);
> return false;
> }
Can kblockd_schedule_work() return 0? If so, should percpu_ref_put() be
called in that case?
Bart.
() function because it is never called.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_def.h | 17 -
drivers/scsi/qla2xxx/qla_gbl.h | 6 +-
drivers/scsi/qla2xxx/qla_gs.c | 15 ++--
drivers/scsi/qla2xxx/qla_init.c | 131
This patch reduces code duplication.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_def.h | 2 +-
drivers/scsi/qla2xxx/qla_gbl.h | 2 ++
drivers/scsi/qla2xxx/qla_gs.c | 12 +-
drivers/scsi/qla2xxx/qla_iocb.c | 40
E N2N handling into state
machine") # v4.19.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_iocb.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_iocb.c b/drivers/scsi/qla2xxx/qla_iocb.c
index 7021fbeb6d23..e9
mailbox interface") # v4.16.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_gs.c | 25 +++--
1 file changed, 11 insertions(+), 14 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_gs.c b/drivers/scsi/qla2xxx/qla_gs.c
index
Make the code easier to read by converting 'goto' statements into
'return' statements.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_init.c | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/drivers/scsi/
It is easy to mix up the QLA_* and the MBS_* status codes. Complain loudly
if that happens.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_def.h | 5 +
drivers/scsi/qla2xxx/qla_init.c | 9 +
2 files changed, 14 insertions(+)
diff --git a/drivers
Make it clear to humans and also to the compiler that the string passed
as fourth argument is not modified.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_gbl.h | 4 ++--
drivers/scsi/qla2xxx/qla_init.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions
Split srb_cmd.ctx into two pointers such that the compiler can check
the type of that pointer.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_def.h | 4 ++--
drivers/scsi/qla2xxx/qla_iocb.c | 20 +---
drivers/scsi/qla2xxx/qla_nx.c | 2
This patch reduces code duplication.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_gbl.h | 1 +
drivers/scsi/qla2xxx/qla_iocb.c | 128 +---
drivers/scsi/qla2xxx/qla_mr.c | 13 +---
drivers/scsi/qla2xxx/qla_nvme.c | 14
This patch fixes several gcc complaints about string truncation.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_mr.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_mr.c b/drivers/scsi
This patch does not change any functionality.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_gs.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_gs.c b/drivers/scsi/qla2xxx/qla_gs.c
index 5ec3c2b96f3f
This change makes it easier to detect qla24xx_read_flash_data() failures
and also to handle such failures. This change does not modify the behavior
of the driver since all callers ignore the qla24xx_read_flash_data()
return value.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers
Since struct sg_table is used in nvme-fc-driver.h, include
from that header file.
Since no definitions or declarations from are used in
the qla_nvme.h header file, do not include from that
header file.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_nvme.h
This patch does not change any functionality but makes the next patch
easier to read.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_inline.h | 28 +++-
1 file changed, 15 insertions(+), 13 deletions(-)
diff --git a/drivers/scsi
This was detected by Coverity.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_os.c | 17 -
1 file changed, 17 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
index 37e24987c852..2ba06a84c501 100644
--- a
but improves source code readability and also allows the
compiler to verify the endianness of Fibre Channel IDs.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_def.h | 71 ++--
drivers/scsi/qla2xxx/qla_gs.c | 62 --
drivers/scsi
This patch fixes several Coverity complaints about not always checking
the qla2x00_wait_for_hba_online() return value.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_attr.c | 3 ++-
drivers/scsi/qla2xxx/qla_target.c | 7 +--
2 files changed, 7 insertions
Pass the output buffer size to the code that generates a PCI info string
and check the output buffer size while generating a PCI info string.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_attr.c | 3 +-
drivers/scsi/qla2xxx/qla_def.h | 2 +-
drivers/scsi
Read the FC port state once instead of twice. This patch fixes the
following Coverity complaint:
Unchecked return value (CHECKED_RETURN)
check_return: Calling atomic_read without checking return value (as is
done elsewhere 80 out of 92 times).
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
be equal to 0.
dead_error_condition: The condition req_data_len != rsp_data_len cannot be
true.
Cc: Himanshu Madhani
Fixes: a9b6f722f62d ("[SCSI] qla2xxx: Implementation of bidirectional.") # v3.7.
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_bsg.c | 11 +--
1 fi
Not calling sp->done() from the command completion path is a severe bug.
Hence complain loudly if that happens.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_init.c | 4
drivers/scsi/qla2xxx/qla_isr.c | 4
drivers/scsi/qla2xxx/qla_mr.c
expects an expression of type
uint64_t (64 bits, unsigned).
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_nx2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_nx2.c b/drivers/scsi/qla2xxx/qla_nx2.c
index
n issue between qla2xxx
and TCM") # v4.5.
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_target.c | 13 -
drivers/scsi/qla2xxx/tcm_qla2xxx.c | 4
2 files changed, 12 insertions(+), 5 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_target.c
b/drivers/scsi/qla2xx
This patch fixes several Coverity complaints about reading data that
has not been initialized.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_init.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_init.c b
The C language supports implicit casting of void pointers to non-void
pointers. Remove explicit sts_entry_* casts that are not necessary.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_isr.c | 15 +--
1 file changed, 5 insertions(+), 10 deletions
According to the firmware documentation the firmware expects all ELS
pass-through IOCB parameters in little endian format. Make this explicit.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_fw.h | 8
drivers/scsi/qla2xxx/qla_iocb.c | 7 ---
2
scsi_remove_host() is called before queue pairs are deleted
and scsi_remove_host() waits for all outstanding SCSI commands to finish.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_def.h | 1 -
drivers/scsi/qla2xxx/qla_os.c | 45
Make sure that locking assumptions are verified at runtime if kernel
debugging is enabled.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_target.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/scsi/qla2xxx/qla_target.c
b/drivers/scsi
Failure of a soft reset is a severe failure. Hence report such failures.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_tmpl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_tmpl.c b/drivers/scsi/qla2xxx/qla_tmpl.c
It is helpful when debugging this driver to have the firmware status
code available if a mailbox command fails. Hence report that firmware
status code.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_mbx.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion
Avoid that this function crashes if mcmd == NULL.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_target.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_target.c
b/drivers/scsi/qla2xxx/qla_target.c
index
This patch makes it clear to humans and also to the compiler that
ql_dump_buffer() does not modify the memory the @buf argument points at.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_dbg.c | 3 ++-
drivers/scsi/qla2xxx/qla_gbl.h | 2 +-
2 files changed, 3
According to the firmware documentation responder mode must be set for
ELS pass-through IOCBs if a response is expected.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_iocb.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi
The value returned by this function is not used. Hence change the
return type of this function into 'void' and remove the return
statement.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_gs.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
Pass the correct session ID to find_sess_by_s_id() instead of passing
an uninitialized variable.
Cc: Himanshu Madhani
Fixes: 2d70c103fd2a ("[SCSI] qla2xxx: Add LLD target-mode infrastructure for >=
24xx series") # v3.5.
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla
Since sess == NULL before 'goto out_term2' is executed, the code under
'if (sess)' cannot be reached. Hence remove that code. This was detected
by Coverity.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_target.c | 3 ---
1 file changed,
Instead of explicitly checking whether a timeout has occurred, ignore
the del_timer() return value.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_init.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/scsi/qla2xxx
Since qlt_make_local_sess() is defined before it is called, remove the
forward declaration of that function.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_target.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_target.c
b
.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_bsg.c| 8 ++-
drivers/scsi/qla2xxx/qla_def.h| 14 +--
drivers/scsi/qla2xxx/qla_gbl.h| 14 +--
drivers/scsi/qla2xxx/qla_gs.c | 21 ++--
drivers/scsi/qla2xxx
This patch fixes a Coverity complaint about not checking the sscanf()
return value.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_tmpl.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_tmpl.c b/drivers/scsi
Checking a pointer after it has been dereferenced is not useful. This was
detected by Coverity.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_nvme.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_nvme.c b/drivers
This patch fixes the following Coverity complaint:
Unchecked return value (CHECKED_RETURN)
check_return: Calling wait_for_completion_timeout without checking return
value (as is done elsewhere 14 out of 17 times).
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx
Use the same approach for encoding the destination ID as the approach
used by qlt_update_vp_map().
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_target.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/qla2xxx
ailed.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_init.c | 3 ++-
drivers/scsi/qla2xxx/qla_nx.c | 4 +++-
drivers/scsi/qla2xxx/qla_os.c | 7 +--
3 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/sc
This patch makes the string manipulation code easier to verify.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_init.c | 18 ++
drivers/scsi/qla2xxx/qla_mr.c | 6 --
2 files changed, 14 insertions(+), 10 deletions(-)
diff --git a/drivers
Simplify the implementation of this function by using the %phC format
specifier instead of using explicit for-loops.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_target.c | 18 +++---
1 file changed, 3 insertions(+), 15 deletions(-)
diff --git a
Delete the PLOGIN ACK data structure from the vha->plogi_ack_list before
freeing that data structure to avoid that that list gets corrupted.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_os.c | 8 ++--
drivers/scsi/qla2xxx/qla_target.c | 4 +++-
Make it clear that the CDB is not modified after processing of a SCSI
command has started.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_target.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_target.h
b/drivers
This patch makes the code that parses the GID list easier to read
without changing the behavior of the code.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_dfs.c| 9 +++--
drivers/scsi/qla2xxx/qla_init.c | 18 --
drivers/scsi/qla2xxx
This patch does not change any functionality but fixes a Coverity
complaint about using a scalar as an array.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_def.h| 4 ++--
drivers/scsi/qla2xxx/qla_iocb.c | 4 ++--
drivers/scsi/qla2xxx/qla_target.c | 4
ull pointer &vha->vha_tgt.qla_tgt->tgt_list_entry
to list_del, which dereferences it.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_target.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_target.c
b
This patch makes it clear that the tag, hwq and qpair variables are
only used in the mq path.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_os.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers
SCSI
command completion.
- Since qla2xxx_eh_abort() increments the sp reference count by calling
sp_get(), decrement the sp reference count before returning.
Cc: Himanshu Madhani
Fixes: 219d27d7147e ("scsi: qla2xxx: Fix race conditions in the code for
aborting SCSI commands")
Signed-o
Insert a space where required, surround complex expressions in macros
with parentheses, use the UL suffix instead of the (unsigned long) cast,
do not use line continuations when not necessary and do not explicitly
initialize static variables to zero.
Cc: Himanshu Madhani
Signed-off-by: Bart Van
Since qla2x00_abort_srb() starts with increasing the reference count of
@sp, decrease that same reference count before returning.
Cc: Himanshu Madhani
Fixes: 219d27d7147e ("scsi: qla2xxx: Fix race conditions in the code for
aborting SCSI commands") # v5.2.
Signed-off-by: Bart
.
Thanks,
Bart.
Changes compared to v1:
- Included a regression fix for qla2xxx_eh_abort() in the second patch of this
series (the fix Himanshu mentioned in his e-mail).
- Moved a WARN_ON_ONCE() statement from a later patch to the second patch in
this series.
- Dropped one patch that renames a
This patch only modifies whitespace.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_gs.c | 78 +--
1 file changed, 39 insertions(+), 39 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_gs.c b/drivers/scsi/qla2xxx/qla_gs.c
Since the put_unaligned_*() macros are used in this header file, include
the header file that defines these macros.
Cc: Himanshu Madhani
Fixes: 15b7a68c1d03 ("scsi: qla2xxx: Introduce the dsd32 and dsd64 data
structures") # v5.2-rc1.
Signed-off-by: Bart Van Assche
---
drivers/sc
There is no bsg code in the qla_mr.c source file. Hence do not include
the header file from qla_mr.c.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_mr.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_mr.c b/drivers/scsi/qla2xxx
uld have preferred if such a new feature had used its own
new copy scsi_mq_ops_batching instead of changing the use case and
semantics of the existing scsi_mq_ops, because this would likely
cause less regressions for all the other users not using the new feature.
For both patches:
Reviewed-by: B
If scsi_target_block() fails that can break the code that calls this
function. Hence complain loudly if scsi_target_block() fails.
Cc: Christoph Hellwig
Cc: Hannes Reinecke
Cc: Johannes Thumshirn
Cc: Ming Lei
Signed-off-by: Bart Van Assche
---
drivers/scsi/scsi_lib.c | 7 ++-
1 file
Hi Martin,
The patches in this series address SCSI device blocking and unblocking and fix
a boot failure. Please consider these patches for kernel version v5.4.
Thanks,
Bart.
Changes compared to v1:
- As requested by James, dropped the patch that changes the return type of
scsi_target_block
("scsi: Implement per-cpu logging buffer") # v4.0.
Reported-by: Jan Palus
Cc: Christoph Hellwig
Cc: Hannes Reinecke
Cc: Johannes Thumshirn
Cc: Ming Lei
Cc: Jan Palus
Signed-off-by: Bart Van Assche
---
drivers/scsi/scsi_logging.c | 48 +++--
in
1 - 100 of 3377 matches
Mail list logo