Re: ufshcd_queuecommand() triggering after ufshcd_suspend()?

in ufshcd_queuecommand be checking the > clk_gating.is_suspended flag before proceeding? > > Other ideas? The logic all seems to be in the generic code, but I'm > not sure if maybe the ufs-hisi.c code is mis-managing something? > > thanks > -john -- Thanks, Zang Leigang

Re: [PATCH] scsi: ufs: add ufs a command complete time stamp

Hi, Subhash I send a new patch, forget tag a "PATCH V2", pls check. On Tue, Sep 26, 2017 at 02:39:06PM -0700, Subhash Jadavani wrote: > On 2017-09-20 03:30, Zang Leigang wrote: > >Signed-off-by: Zang Leigang > > > >diff --git a/drivers/scsi/ufs/ufshcd.c b/dri

[PATCH] scsi: ufs: add ufs a command complete time stamp

Signed-off-by: Zang Leigang diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index 794a460..7e8d583 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -385,6 +385,8 @@ void ufshcd_print_trs(struct ufs_hba *hba, unsigned long bitmap, bool pr_prdt

[PATCH] scsi: ufs: add ufs a command complete time stamp

Signed-off-by: Zang Leigang diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index 794a4600e952..2984f33095be 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -385,6 +385,8 @@ void ufshcd_print_trs(struct ufs_hba *hba, unsigned long bitmap, bool

[PATCH] scsi: ufs: fix a pclint warning

Signed-off-by: Zang Leigang diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index 794a4600e952..deb77535b8c9 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -3586,7 +3586,7 @@ static int ufshcd_uic_pwr_ctrl(struct ufs_hba *hba, struct uic_command

[PATCH] scsi: ufs: reqs and tasks were put in the wrong order

Signed-off-by: Zang Leigang diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index 5bc9dc14e075..794a4600e952 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -438,7 +438,7 @@ static void ufshcd_print_host_state(struct ufs_hba *hba) { dev_err

Re: [PATCH] scsi: ufs: check link active or not after switch to HS mode

On Wed, Jun 28, 2017 at 04:48:21PM -0700, Subhash Jadavani wrote: > On 2017-06-24 04:44, Zang Leigang wrote: > >Some device can successfully link and switch to HS mode. But failed > >to do more. ufshcd_verify_dev_init can help to find this earlier. > > > >Signed-off-by

Re: [PATCH] scsi: ufs: set host_byte to DID_REQUEUE when ocs = OCS_ABORTED

On Wed, Jun 28, 2017 at 04:42:36PM -0700, Subhash Jadavani wrote: > On 2017-06-24 03:27, Zang Leigang wrote: > >Host set ocs to OCS_ABORTED when clear a doorbell in err handler. > > OCS field is valid after host controller has cleared the > corresponding doorbell (UTRLDBR) bit

[PATCH] scsi: ufs: check link active or not after switch to HS mode

Some device can successfully link and switch to HS mode. But failed to do more. ufshcd_verify_dev_init can help to find this earlier. Signed-off-by: Zang Leigang diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index ffe8d8608818..eb03388fc4bd 100644 --- a/drivers/scsi/ufs

[PATCH] scsi: ufs: flush eh_work when eh_work scheduled.

Forget a condition: eh_work scheduled but do not start to work. Signed-off-by: Zang Leigang diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index e050dcea1bea..a2dff12713fc 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -5807,7 +5807,8 @@ static int

[PATCH] scsi: ufs: set host_byte to DID_REQUEUE when ocs = OCS_ABORTED

Host set ocs to OCS_ABORTED when clear a doorbell in err handler. Then scsi_decide_disposition return SUCCESS. This may cause some filesystem panic because a FAILED REQUESET. Requeue and complete is better. Signed-off-by: Zang Leigang diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs

[PATCH] scsi: ufs: introduce a new ufshcd_statea UFSHCD_STATE_EH_SCHEDULED

Add a new ufshcd_state, indicats that an err handler may get to run immediately. Use UFSHCD_STATE_ERROR here looks not literaly correct. Signed-off-by: Zang Leigang diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index 05c7456..59d4130 100644 --- a/drivers/scsi/ufs/ufshcd.c

Re: [PATCH] scsi: ufs: remove unnecessary UFSHCD_STATE_ERROR set

Ok, got it. I will resend a new patch. On Tue, Nov 15, 2016 at 11:00:12AM -0800, Subhash Jadavani wrote: > On 2016-11-15 04:25, Zang Leigang wrote: > >We set ufshcd_state to UFSHCD_STATE_ERROR when an err handler > >fails. So I think UFSHCD_STATE_ERROR means host not works any

[PATCH] scsi: ufs: remove unnecessary UFSHCD_STATE_ERROR set

We set ufshcd_state to UFSHCD_STATE_ERROR when an err handler fails. So I think UFSHCD_STATE_ERROR means host not works any more. Set it before schedule eh_work is not correct. Signed-off-by: Zang Leigang diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index 05c7456..a7724ad

[PATCH v2] UFS: Date Segment only need for WRITE DESCRIPTOR

Some device may cause a compatibility issue while receiving a Query UPIU with Data Segment which does not expected. Signed-off-by: Zang Leigang --- drivers/scsi/ufs/ufshcd.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs

[PATCH] UFS: Date Segment only need for WRITE DESCRIPTOR

Some device may cause a compatibility issue while receiving a Query UPIU with Data Segment which does not expected. Signed-off-by: Zang Leigang --- drivers/scsi/ufs/ufshcd.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs