Remove including that don't need it.
Signed-off-by: YueHaibing
---
drivers/scsi/megaraid/megaraid_sas_debugfs.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas_debugfs.c
b/drivers/scsi/megaraid/megaraid_sas_debugfs.c
index e52837bb6807..c697607
nitialized. Fix this by initializing
variable 'sshdr' to 0.
Fixes: 77266186397c ("scsi: myrs: Add Mylex RAID controller (SCSI interface)")
Signed-off-by: YueHaibing
---
drivers/scsi/myrs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/myrs.c b/driver
Friendly ping, could someone review this patch ?
On 2019/4/20 12:05, Yue Haibing wrote:
> From: YueHaibing
>
> KASAN report this:
>
> BUG: KASAN: global-out-of-bounds in qedi_dbg_err+0xda/0x330 [qedi]
> Read of size 31 at addr c12b0ae0 by task syz-executor.0/24
I send a similar fix earlier, but it seems not be picked.
https://patchwork.kernel.org/patch/10874565/
On 2019/4/12 17:05, Colin King wrote:
> From: Colin Ian King
>
> Currently the qedf_dbg_* family of functions can overrun the end
> of the source string if it is less than the destination bu
and can be removed.
Signed-off-by: YueHaibing
---
drivers/scsi/qedf/qedf_fip.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/scsi/qedf/qedf_fip.c b/drivers/scsi/qedf/qedf_fip.c
index 766da74fa546..49d0724535e3 100644
--- a/drivers/scsi/qedf/qedf_fip.c
+++ b/drivers/scsi/qed
n function 'pm8001_bytes_dmaed':
drivers/scsi/pm8001/pm8001_hwi.c:3247:24: warning:
variable 'sas_ha' set but not used [-Wunused-but-set-variable]
They're never used since introduction, so can be removed.
Signed-off-by: YueHaibing
---
drivers/scsi/pm8001/pm8001_hwi.c
Remove .owner field if calls are used which set it automatically
Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
Signed-off-by: YueHaibing
---
drivers/scsi/ufs/ufs-mediatek.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs
ping.
On 2019/2/22 11:39, Yue Haibing wrote:
> From: YueHaibing
>
> KASAN report this:
>
> BUG: KASAN: global-out-of-bounds in qedi_dbg_err+0xda/0x330 [qedi]
> Read of size 31 at addr c12b0ae0 by task syz-executor.0/2429
>
> CPU: 0 PID: 2429 Comm: syz-executor
Friendly ping:
Who can review or take this, please?
Thanks
On 2019/1/30 18:11, YueHaibing wrote:
> There is a potential NULL pointer dereference in case
> fc_rport_create() fails and returns NULL.
>
> Fixes: 2580064b5ec6 ("scsi: libfc: Replace ->rport_create callback w
pi.c:261:9: warning:
variable 'req_idx' set but not used [-Wunused-but-set-variable]
They're never used and can be removed.
Signed-off-by: YueHaibing
---
drivers/message/fusion/mptspi.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/message/fusion/mptspi.c b/drive
move some functions to hisi_sas_main.c,
which can eliminate redundant code.
Signed-off-by: YueHaibing
---
drivers/scsi/hisi_sas/hisi_sas.h | 6 ++
drivers/scsi/hisi_sas/hisi_sas_main.c | 37 +
drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 38
Fix following sparse warning:
drivers/scsi/mvumi.c:1797:48: warning: Using plain integer as NULL pointer
drivers/scsi/mvumi.c:2143:50: warning: Using plain integer as NULL pointer
drivers/scsi/mvumi.c:755:58: warning: Using plain integer as NULL pointer
Signed-off-by: YueHaibing
---
drivers
7;qedi_tmf_work':
drivers/scsi/qedi/qedi_fw.c:1370:28: warning:
variable 'cls_sess' set but not used [-Wunused-but-set-variable]
It's never used since introduction.
Signed-off-by: YueHaibing
---
drivers/scsi/qedi/qedi_fw.c | 4
1 file changed, 4 deletions(-)
diff
in commit 6a828b0f6192 ("scsi: lpfc: Support
non-uniform allocation of MSIX vectors to hardware queues")
Signed-off-by: YueHaibing
---
drivers/scsi/lpfc/lpfc_init.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc
There is a potential NULL pointer dereference in case
fc_rport_create() fails and returns NULL.
Fixes: 2580064b5ec6 ("scsi: libfc: Replace ->rport_create callback with
function call")
Signed-off-by: YueHaibing
---
drivers/scsi/libfc/fc_lport.c | 4
1 file changed, 4 insert
c_rq_alloc_bufs':
drivers/scsi/fnic/vnic_rq.c:30:19: warning:
variable 'vdev' set but not used [-Wunused-but-set-variable]
It never used since introduction
Signed-off-by: YueHaibing
---
drivers/scsi/fnic/vnic_rq.c | 3 ---
drivers/scsi/fnic/vnic_wq.c | 3 ---
2 files chang
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/scsi/csiostor/csio_attr.c: In function 'csio_fcoe_free_vnp':
drivers/scsi/csiostor/csio_attr.c:500:21: warning:
variable 'pln' set but not used [-Wunused-but-set-variable]
It never used since introducti
^
Signed-off-by: YueHaibing
---
drivers/scsi/bfa/bfa_fcs_rport.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/scsi/bfa/bfa_fcs_rport.c b/drivers/scsi/bfa/bfa_fcs_rport.c
index 1e400f2..d6de10a 100644
--- a/drivers/scsi/bfa/bfa_fcs_rport.c
+++ b/drivers/scsi/b
ql4_nx.c:2816:47: warning:
variable 'mask' set but not used [-Wunused-but-set-variable]
Signed-off-by: YueHaibing
---
drivers/scsi/qla4xxx/ql4_nx.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/scsi/qla4xxx/ql4_nx.c b/drivers/scsi/qla4xxx/ql4_nx.c
i
The return code should be check while qla4xxx_copy_from_fwddb_param
fails.
Signed-off-by: YueHaibing
---
drivers/scsi/qla4xxx/ql4_os.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c
index 949e186..1bc4db6 100644
--- a/drivers
ce_notification':
drivers/scsi/fcoe/fcoe.c:1861:20: warning:
variable 'port' set but not used [-Wunused-but-set-variable]
Signed-off-by: YueHaibing
---
drivers/scsi/fcoe/fcoe.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.
:
variable 'cdev' set but not used [-Wunused-but-set-variable]
It never used since intruction.
Signed-off-by: YueHaibing
---
drivers/scsi/qedi/qedi_iscsi.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/scsi/qedi/qedi_iscsi.c b/drivers/scsi/qedi/qedi_iscsi.c
index 4d
limit to 32 in below for loop,
so this can be removed safely.
Signed-off-by: YueHaibing
---
drivers/scsi/lpfc/lpfc_debugfs.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_debugfs.c b/drivers/scsi/lpfc/lpfc_debugfs.c
index a58f0b3..fe446ac
^
Signed-off-by: YueHaibing
---
drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
index bcd30e2..fa6a09a 100644
--- a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
+++ b/drivers/scsi/bnx2fc/
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/scsi/dpt_i2o.c: In function 'adpt_slave_configure':
drivers/scsi/dpt_i2o.c:414:12: warning:
variable 'pHba' set but not used [-Wunused-but-set-variable]
It never used since git history start.
Signed-off-by
On 2018/11/22 11:15, Martin K. Petersen wrote:
>
> YueHaibing,
>
>> From: Yue Haibing
>>
>> Fixes gcc '-Wunused-but-set-variable' warning:
>>
>> drivers/scsi/libfc/fc_rport.c: In function 'fc_rport_recv_flogi_req':
>> drivers/s
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/scsi/dpt_i2o.c: In function 'adpt_slave_configure':
drivers/scsi/dpt_i2o.c:414:12: warning:
variable 'pHba' set but not used [-Wunused-but-set-variable]
It never used since git history start.
Signed-off-by:
"[SCSI] initio:
Convert into a real Linux driver and update to modern style")
Signed-off-by: YueHaibing
---
drivers/scsi/initio.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/initio.c b/drivers/scsi/initio.c
index 0a8d786c..acef1f2 100644
--- a/
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
Signed-off-by: YueHaibing
---
drivers/scsi/ufs/ufs-hisi.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/scsi/ufs/ufs-hisi.c b/drivers/scsi/ufs/ufs-hisi.c
index 452e19f..6fdf059 100644
--- a/drivers/scsi
27;access' not used any more since commit
edb88cef0570 ("scsi: pmcraid: use normal copy_from_user")
Signed-off-by: YueHaibing
---
drivers/scsi/pmcraid.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid
Remove .owner field if calls are used which set it automatically
Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
Signed-off-by: YueHaibing
---
drivers/scsi/ufs/cdns-pltfrm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/ufs/cdns-pltfrm.c b/drivers/scsi/ufs
4e6363859d ("[SCSI] bnx2i: Add bnx2i iSCSI driver.")
Signed-off-by: YueHaibing
---
drivers/scsi/bnx2i/bnx2i_hwi.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/scsi/bnx2i/bnx2i_hwi.c b/drivers/scsi/bnx2i/bnx2i_hwi.c
index 6bad268..91f5316 100644
--- a/drivers/scsi/bn
ace7f46ba5fd ("scsi: qedi: Add QLogic FastLinQ offload iSCSI driver framework.")
Signed-off-by: YueHaibing
---
drivers/scsi/qedi/qedi_main.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c
index 105b0e4..a2eb611 100644
-
isi_sas/hisi_sas_v3_hw.c:889:20: warning:
variable 'dq_list' set but not used [-Wunused-but-set-variable]
It never used since introduction in commit
fa222db0b036 ("scsi: hisi_sas: Don't lock DQ for complete task sending")
Signed-off-by: YueHaibing
---
drivers/scsi/hisi_sas
res_flag_ex = 0;
It not used anymore after commit
92b19ff50e8f ("cleanup IORESOURCE_CACHEABLE vs ioremap()")
Signed-off-by: YueHaibing
---
drivers/scsi/mvsas/mv_init.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/scsi/mvsas/mv_init.c b/drivers/scsi/mvsas
("[SCSI] a100u2w: Convert into Linux style")
Signed-off-by: YueHaibing
---
drivers/scsi/a100u2w.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/scsi/a100u2w.c b/drivers/scsi/a100u2w.c
index 00072ed..012aa25 100644
--- a/drivers/scsi/a100u2w.c
+++ b/drivers/scsi/a1
0 ("isci: preallocate requests")
Signed-off-by: YueHaibing
---
drivers/scsi/isci/host.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/scsi/isci/host.c b/drivers/scsi/isci/host.c
index 7b5deae..7ebfa3c 100644
--- a/drivers/scsi/isci/host.c
+++ b/drivers/scsi/isci/host
fe ("[SCSI] mvsas: add support for 94xx; layout change; bug fixes")
Signed-off-by: YueHaibing
---
drivers/scsi/mvsas/mv_sas.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/scsi/mvsas/mv_sas.c b/drivers/scsi/mvsas/mv_sas.c
index 3df1428..ab50798 100644
--- a/drivers/scsi
d since introduction in
commit 61d8658b4a43 ("scsi: qedf: Add QLogic FastLinQ offload FCoE driver
framework.")
Signed-off-by: YueHaibing
---
drivers/scsi/qedf/qedf_main.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c
ind
d lookup")
Signed-off-by: YueHaibing
---
drivers/scsi/advansys.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index 44c9619..223ef6f 100644
--- a/drivers/scsi/advansys.c
+++ b/drivers/scsi/advansys.c
@@ -5949,7 +5949,6 @@ static void
On 2018/10/17 9:34, Martin K. Petersen wrote:
>
> Hi Yue Haibing,
>
>> srb_tag = le32_to_cpu(scsiqp->srb_tag);
>> -scp = scsi_host_find_tag(boardp->shost, scsiqp->srb_tag);
>> +scp = scsi_host_find_tag(boardp->shost, srb_tag);
>
> Maybe I'm missing something, but I don't see where
1320:6: warning:
variable 'id' set but not used [-Wunused-but-set-variable]
It never used since introduction in commit ae52e7f09ff5
Signed-off-by: YueHaibing
---
drivers/scsi/arcmsr/arcmsr_hba.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c
02fd ("scsi: lpfc: NVME Target: Add debugfs
support")
Signed-off-by: YueHaibing
---
drivers/scsi/lpfc/lpfc_debugfs.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_debugfs.c b/drivers/scsi/lpfc/lpfc_debugfs.c
index aec5b10..0c8005b 100644
--- a/drivers/scs
'maxch' should be used rather than 'phba->cfg_nvme_io_channel'
Fixes:66a210ffb877 ("scsi: lpfc: Add per io channel NVME IO statistics")
Signed-off-by: YueHaibing
---
drivers/scsi/lpfc/lpfc_debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-
NVME Initiator: Base modifications")
'psli' is not used any more.
Signed-off-by: YueHaibing
---
drivers/scsi/lpfc/lpfc_hbadisc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hbadisc.c
index f9a038ec..f4deb86 1
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/scsi/ufs/ufs-qcom.c: In function 'ufs_qcom_pwr_change_notify':
drivers/scsi/ufs/ufs-qcom.c:919:6: warning:
variable 'val' set but not used [-Wunused-but-set-variable]
Signed-off-by: YueHaibing
---
drivers/
'srb_tag' should be used in the scsi_host_find_tag,
rather than 'scsiqp->srb_tag'.
Fixes: 9c17c62aedb0 ("advansys: use shared host tag map for command lookup")
Signed-off-by: YueHaibing
---
drivers/scsi/advansys.c | 2 +-
1 file changed, 1 insertion(+), 1 delet
In function
'megaraid_mbox_fire_sync_cmd':
drivers/scsi/megaraid/megaraid_mbox.c:3302:12: warning:
variable 'mbox64' set but not used [-Wunused-but-set-variable]
drivers/scsi/megaraid/megaraid_mbox.c: In function 'gather_hbainfo':
drivers/scsi/megaraid/megaraid_mbo
tion 'lpfc_cq_create':
drivers/scsi/lpfc/lpfc_sli.c:14852:11: warning:
variable 'hw_page_size' set but not used [-Wunused-but-set-variable]
Signed-off-by: YueHaibing
---
drivers/scsi/lpfc/lpfc_sli.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/scsi/lp
Use kmemdup rather than duplicating its implementation
Signed-off-by: YueHaibing
---
drivers/scsi/aic7xxx/aic7xxx_core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/aic7xxx/aic7xxx_core.c
b/drivers/scsi/aic7xxx/aic7xxx_core.c
index f3362f4..8549f1e
Use kmemdup rather than duplicating its implementation
Signed-off-by: YueHaibing
---
drivers/scsi/aic7xxx/aic79xx_core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/aic7xxx/aic79xx_core.c
b/drivers/scsi/aic7xxx/aic79xx_core.c
index 9ee75c9..0970bb5
Use kmemdup rather than duplicating its implementation
Signed-off-by: YueHaibing
---
drivers/message/fusion/mptbase.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/message/fusion/mptbase.c b/drivers/message/fusion/mptbase.c
index dc1e43a..a32d3d0 100644
--- a
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/scsi/pm8001/pm80xx_hwi.c: In function 'pm8001_set_phy_profile':
drivers/scsi/pm8001/pm80xx_hwi.c:4679:6: warning:
variable 'page_code' set but not used [-Wunused-but-set-variable]
Signed-off-by: YueHai
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/scsi/qla2xxx/qla_iocb.c: In function 'qla24xx_els_dcmd2_iocb':
drivers/scsi/qla2xxx/qla_iocb.c:2644:13: warning:
variable 'ptr_dma' set but not used [-Wunused-but-set-variable]
Signed-off-by: YueHaibing
---
d
^
Signed-off-by: YueHaibing
---
drivers/scsi/lpfc/lpfc_nvme.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_nvme.c b/drivers/scsi/lpfc/lpfc_nvme.c
index 5438732..d86eb51 100644
--- a/drivers/scsi/lpfc/lpfc_nvme.c
+++ b/drivers/scs
8001/pm8001_sas.c: In function 'pm8001_abort_task':
drivers/scsi/pm8001/pm8001_sas.c:1191:6: warning:
variable 'device_id' set but not used [-Wunused-but-set-variable]
Signed-off-by: YueHaibing
---
drivers/scsi/pm8001/pm8001_sas.c | 4
1 file changed, 4 deletions(-)
diff --git
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
Signed-off-by: YueHaibing
---
drivers/scsi/qla2xxx/tcm_qla2xxx.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/scsi/qla2xxx/tcm_qla2xxx.c
b/drivers/scsi/qla2xxx/tcm_qla2xxx.c
index 731a094..70356d2
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/scsi/bnx2fc/bnx2fc_fcoe.c: In function 'bnx2fc_rcv':
drivers/scsi/bnx2fc/bnx2fc_fcoe.c:435:17: warning:
variable 'oxid' set but not used [-Wunused-but-set-variable]
Signed-off-by: YueHaibing
---
drivers
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/scsi/aic7xxx/aic79xx_pci.c: In function 'ahd_pci_config':
drivers/scsi/aic7xxx/aic79xx_pci.c:291:19: warning:
variable 'shared_scb_data' set but not used [-Wunused-but-set-variable]
Signed-off-by: YueHaib
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/scsi/libfc/fc_fcp.c: In function 'fc_queuecommand':
drivers/scsi/libfc/fc_fcp.c:1875:30: warning:
variable 'rpriv' set but not used [-Wunused-but-set-variable]
Signed-off-by: YueHaibing
---
drivers/scsi/
Remove boilerplate code by using macro module_pci_driver.
Signed-off-by: YueHaibing
---
drivers/scsi/a100u2w.c | 13 +
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a/drivers/scsi/a100u2w.c b/drivers/scsi/a100u2w.c
index 8086bd0..b2942ec 100644
--- a/drivers/scsi
Remove boilerplate code by using macro module_pci_driver.
Signed-off-by: YueHaibing
---
drivers/scsi/am53c974.c | 13 +
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a/drivers/scsi/am53c974.c b/drivers/scsi/am53c974.c
index beea30e..d81ca66 100644
--- a/drivers/scsi
Remove boilerplate code by using macro module_pci_driver.
Signed-off-by: YueHaibing
---
drivers/scsi/wd719x.c | 13 +
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a/drivers/scsi/wd719x.c b/drivers/scsi/wd719x.c
index 2ba2b7b..974bfb3 100644
--- a/drivers/scsi/wd719x.c
Remove boilerplate code by using macro module_pci_driver.
Signed-off-by: YueHaibing
---
drivers/scsi/mvumi.c | 20 +---
1 file changed, 1 insertion(+), 19 deletions(-)
diff --git a/drivers/scsi/mvumi.c b/drivers/scsi/mvumi.c
index fe97401..2e6fd86 100644
--- a/drivers/scsi
64 matches
Mail list logo