Re: Qlogic driver fix in backports induces target code regression.

2017-06-23 Thread Willy Tarreau
Hi, On Fri, Jun 23, 2017 at 12:45:17PM -0500, Dr. Greg Wettstein wrote: > Hi, I hope the week is ending well for everyone. > > We just tracked this issue down and I wanted to bring it to the > attention of Willy and Ben in particular, since it is has a high > probability of negatively affecting s

Re: [PATCH 3.10 141/319] scsi: mpt3sas: Fix secure erase premature termination

2017-02-07 Thread Willy Tarreau
On Tue, Feb 07, 2017 at 06:12:34PM +0100, Willy Tarreau wrote: > On Tue, Feb 07, 2017 at 09:02:51AM -0800, James Bottomley wrote: > > On Tue, 2017-02-07 at 07:59 +0100, Willy Tarreau wrote: > > > Hi James, > > > > > > On Mon, Feb 06, 2017 at 10:38:48PM -0800, J

Re: [PATCH 3.10 141/319] scsi: mpt3sas: Fix secure erase premature termination

2017-02-07 Thread Willy Tarreau
On Tue, Feb 07, 2017 at 09:02:51AM -0800, James Bottomley wrote: > On Tue, 2017-02-07 at 07:59 +0100, Willy Tarreau wrote: > > Hi James, > > > > On Mon, Feb 06, 2017 at 10:38:48PM -0800, James Bottomley wrote: > > > On Mon, 2017-02-06 at 23:26 +0100, Willy Tarre

Re: [PATCH 3.10 141/319] scsi: mpt3sas: Fix secure erase premature termination

2017-02-06 Thread Willy Tarreau
Hi James, On Mon, Feb 06, 2017 at 10:38:48PM -0800, James Bottomley wrote: > On Mon, 2017-02-06 at 23:26 +0100, Willy Tarreau wrote: (...) > > We don't have the referenced commit above in 3.10 so we should be > > safe. Additionally I checked that neither 4.4 nor 3.12 have

Re: [PATCH 3.10 141/319] scsi: mpt3sas: Fix secure erase premature termination

2017-02-06 Thread Willy Tarreau
Hi Sathya, On Mon, Feb 06, 2017 at 09:21:44AM -0700, Sathya Prakash Veerichetty wrote: > Willy, > I think this patch had a problem and later modified to a different > blocking mechanism. Could you please pull in the latest change for this? Much appreciated, thanks. I've checked and found the pat

[PATCH 3.10 141/319] scsi: mpt3sas: Fix secure erase premature termination

2017-02-05 Thread Willy Tarreau
/scsi-fixes, tweaked patch description] Signed-off-by: Andrey Grodzovsky Acked-by: Sreekanth Reddy Cc: Cc: Sathya Prakash Cc: Chaitra P B Cc: Suganath Prabu Subramani Cc: Sreekanth Reddy Cc: Hannes Reinecke Signed-off-by: Martin K. Petersen Signed-off-by: Willy Tarreau --- drivers/scsi

Re: [patch] ses: tighten range checks in ses_intf_add()

2015-10-19 Thread Willy Tarreau
Hi Dan, On Mon, Oct 19, 2015 at 04:48:20PM +0300, Dan Carpenter wrote: > We test that "type_ptr" is within the buffer but then we read from > "type_ptr[3]" so we could be reading beyond the end of the buffer. > > Reported-by: "Berry Cheng ??(??)" > Signed-off-by: Dan Carpenter > --- > T

Re: [PATCH 01/14] parport: return value of attach and parport_register_driver

2015-04-08 Thread Willy Tarreau
On Wed, Apr 08, 2015 at 03:27:37PM +0300, Dan Carpenter wrote: > On Wed, Apr 08, 2015 at 05:20:10PM +0530, Sudip Mukherjee wrote: > > On Wed, Apr 08, 2015 at 02:38:32PM +0300, Dan Carpenter wrote: > > > 1) We can't apply this patch on its own so this way of breaking up the > > > patches doesn't wor

[ 078/184] scsi: Silence unnecessary warnings about ioctl to

2013-06-04 Thread Willy Tarreau
g Acked-by: Paolo Bonzini Signed-off-by: Jan Kara Signed-off-by: Jens Axboe [bwh: Backported to 3.2: use ENOTTY, not ENOIOCTLCMD] Signed-off-by: Ben Hutchings (cherry picked from commit f45c9a6eec20cd712421c442785e7a4e9215a230) Cc: Thomas Bork Signed-off-by: Willy Tarreau --- block/scsi_ioctl.c |

Re: [Bug 3680] sym53c8xx_2 SMP deadlock on driver load

2007-10-17 Thread Willy Tarreau
On Wed, Oct 17, 2007 at 10:27:47AM -0600, Matthew Wilcox wrote: > On Wed, Oct 17, 2007 at 10:53:06AM -0400, Tony Battersby wrote: > > After looking at it carefully, this is true of pci_map_mem, but not > > pci_unmap_mem. pci_unmap_mem can be called from both ->detect and > > ->release. io_request

Re: [Bug 3680] sym53c8xx_2 SMP deadlock on driver load

2007-10-17 Thread Willy Tarreau
On Wed, Oct 17, 2007 at 11:44:08AM -0400, Tony Battersby wrote: > In 2.4, include/linux/init.h has the following: > > #ifndef MODULE > #define __init __attribute__ ((__section__ (".text.init"))) > #else > #define __init > #endif > > So __init has an effect only if it is built-in. Ah yes

Re: [Bug 3680] sym53c8xx_2 SMP deadlock on driver load

2007-10-17 Thread Willy Tarreau
On Wed, Oct 17, 2007 at 10:53:06AM -0400, Tony Battersby wrote: > > So we should unconditionally drop the lock (and re-enable > > interrupts) and re-acquire it. > > After looking at it carefully, this is true of pci_map_mem, but not > pci_unmap_mem. pci_unmap_mem can be called from both ->detect