Re: [Open-FCoE] [PATCH] MAINTAINERS: Change FCoE maintainer

t a/MAINTAINERS b/MAINTAINERS > index e1b090f..70af8c0 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -4661,7 +4661,7 @@ S: Maintained >  F: drivers/staging/fbtft/ >   >  FCOE SUBSYSTEM (libfc, libfcoe, fcoe) > -M: Vasu Dev > +M: Johannes Thumshirn >  L

Re: [PATCHv2] libfc: Update rport reference counting

@@ -1494,6 +1494,7 @@ static void fc_rport_recv_els_req(struct > fc_lport *lport, struct fc_frame *fp) >   break; >   default: >   mutex_unlock(&rdata->rp_mutex); > + kref_put(&rdata->kref, lport->tt.rport_destroy); >  

Re: [PATCH] SCSI-libfc: Delete an unnecessary check before the function call "kmem_cache_destroy"

em_cache_destroy(scsi_pkt_cachep); > } > > /** Looks good. Acked-by: Vasu Dev -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH -resend 1/1] fcoe: use continue instead of goto+label

continue; > } > > spin_unlock_bh(&p->fcoe_rx_list.lock); Acked-by: Vasu Dev -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [Open-FCoE] [PATCH] scsi: fcoe: Convert use of __constant_htons to htons

type.type = htons(ETH_P_FCOE); > fcoe->fcoe_packet_type.dev = netdev; > dev_add_pack(&fcoe->fcoe_packet_type); > Acked-by: Vasu Dev -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [Open-FCoE] [PATCH] libfc: correct function name in comment

- Create a new NPIV vport instance > * @vport: fc_vport structure from scsi_transport_fc > * @privsize: driver private data size to allocate along with the Scsi_Host > */ > > struct fc_lport *libfc_vport_create(struct fc_vport *vport, int privsize) > _ Looks good. Ac

Re: [PATCH 0/3] libfc patches for kernel v4.2

On Fri, 2015-06-05 at 14:20 -0700, Vasu Dev wrote: > These libfc fixes are for kernel 4.2 and with two patches CCed for stable > kernel also, those two could be picked for current 4.1 cycle now but in case > too late for current 4.1 then anyway should get picked up by 4.1 stable >

Re: [PATCH] SCSI-libfc: Delete an unnecessary check before the function call "fc_fcp_ddp_done"

if (fsp) > - fc_fcp_ddp_done(fsp); > + fc_fcp_ddp_done(fsp); > rc = fc_exch_done_locked(ep); > spin_unlock_bh(&ep->ex_lock); > if (!rc) Looks good. Acked-by: Vasu Dev -- To unsubscribe from this list: send the line "unsubscribe linux-scs

Re: [Open-FCoE] [PATCH] [trivial] scsi:fcoe: Fix typo "a ethernet" in fcoe_transport.c

gt; +MODULE_PARM_DESC(enable, " Enables fcoe on an ethernet interface."); > > module_param_call(disable, fcoe_transport_disable, NULL, NULL, S_IWUSR); > __MODULE_PARM_TYPE(disable, "string"); > -MODULE_PARM_DESC(disable, " Disables fcoe on a ethernet interface.&q

Re: [Open-FCoE] [PATCH 0/3] libfc patches for kernel v4.2

On Fri, 2015-06-05 at 14:20 -0700, Vasu Dev wrote: > These libfc fixes are for kernel 4.2 and with two patches CCed for stable > kernel also, those two could be picked for current 4.1 cycle now but in case > too late for current 4.1 then anyway should get picked up by 4.1 stable >

[PATCH 3/3] libfc: Fix fc_fcp_cleanup_each_cmd()

.org/pipermail/fcoe-devel/2015-May/012471.html ] Signed-off-by: Vasu Dev --- drivers/scsi/libfc/fc_fcp.c | 19 +-- 1 files changed, 17 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/libfc/fc_fcp.c b/drivers/scsi/libfc/fc_fcp.c index 4cd49d4..5121272 100644 --- a/driv

[PATCH 0/3] libfc patches for kernel v4.2

These libfc fixes are for kernel 4.2 and with two patches CCed for stable kernel also, those two could be picked for current 4.1 cycle now but in case too late for current 4.1 then anyway should get picked up by 4.1 stable kernel later. These patches were posted by Bart Van Assche at open-fcoe.org

[PATCH 2/3] libfc: Fix fc_exch_recv_req() error path

atch fixes the following crash: general protection fault: [#3] PREEMPT SMP RIP: fc_lport_recv_req+0x72/0x280 [libfc] Call Trace: fc_exch_recv+0x642/0xde0 [libfc] fcoe_percpu_receive_thread+0x46a/0x5ed [fcoe] kthread+0x10a/0x120 ret_from_fork+0x42/0x70 Signed-off-by: Bart Van Assche Cc: Va

[PATCH 1/3] libfc: Fix a typo in a source code comment

From: Bart Van Assche Signed-off-by: Bart Van Assche Signed-off-by: Vasu Dev --- drivers/scsi/libfc/fc_fcp.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/libfc/fc_fcp.c b/drivers/scsi/libfc/fc_fcp.c index c679594..4cd49d4 100644 --- a/drivers/scsi

Re: [PATCH] scsi: match wait_for_completion_timeout return type

-1292,7 +1293,7 @@ static int fc_lun_reset(struct fc_lport *lport, struct > fc_fcp_pkt *fsp, > fsp->wait_for_comp = 0; > spin_unlock_bh(&fsp->scsi_pkt_lock); > > - if (!rc) { > + if (!ticks_left) { > FC_SCSI_DBG(lport, "lun reset

[PATCH] libfc: abort an exchange in case of underrun error

Currently exchange is not aborted in case underrun, so this patch fixes this by issuing exchange abort along FC_DATA_UNDRUN error since such error-ed exchange must be aborted first before same can be re-used. Tested-By: Jack Morgan Signed-off-by: Vasu Dev --- drivers/scsi/libfc/fc_fcp.c |4

[PATCH] MAINTAINERS: updated open-fcoe maintainer-ship

Robert Love sent this patch before along his open-fcoe transition announcement in May, 2014. However that was never applied, so sending again. Link to original send: http://marc.info/?l=linux-scsi&m=140131194613697 CC: Robert Love Signed-off-by: Vasu Dev --- MAINTAINERS |2 +- 1

Re: [PATCH] libfs: Replace rcu_assign_pointer() with RCU_INIT_POINTER()

pe], NULL); > + RCU_INIT_POINTER(fc_passive_prov[type], NULL); > else > - rcu_assign_pointer(fc_active_prov[type], NULL); > + RCU_INIT_POINTER(fc_active_prov[type], NULL); > mutex_unlock(&fc_prov_mutex); > synchronize_rcu(); > } Lo

[PATCH] fcoe: extend ethtool to FC port speed mapping

From: Chris Leech add support for 20 Gbit and 40 Gbit links Signed-off-by: Chris Leech Signed-off-by: Vasu Dev --- drivers/scsi/fcoe/fcoe_transport.c | 39 ++-- 1 files changed, 33 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/fcoe

Re: [PATCH] fcoe: Reduce max_sectors to 1024

On Wed, 2014-07-09 at 08:40 +0200, Hannes Reinecke wrote: > On 07/09/2014 08:18 AM, Christoph Hellwig wrote: > > On Wed, Jul 09, 2014 at 08:16:21AM +0200, Hannes Reinecke wrote: > >> The DDP offload on ixgbe is only capable of handling requests up > >> to 1024 sectors. So we should be exposing this

Re: [Open-FCoE] [PATCH] fc: ensure scan_work isn't active when freeing fc_rport

On Fri, 2014-06-06 at 16:54 -0400, Neil Horman wrote: > On Mon, Jun 02, 2014 at 04:22:50PM -0700, Vasu Dev wrote: > > On Fri, 2014-05-30 at 10:59 -0400, Neil Horman wrote: > > > debugfs caught this: > > > WARNING: at lib/debugobjects.c:260 debug_print_object+0x83/0xa0(

Re: [PATCH 2/2] tcm_fc: Generate TASK_SET_FULL status for response failures

On Fri, 2014-06-06 at 14:11 -0700, Nicholas A. Bellinger wrote: > , changing this to pr_info_ratelimited and doing the same in > ft_queue_data_in() well. Since doing more places and therefore can be done in separate patch. //Vasu -- To unsubscribe from this list: send the line "unsubscribe linu

Re: [PATCH 1/2] tcm_fc: Generate TASK_SET_FULL status for DataIN failures

On Fri, 2014-06-06 at 14:02 -0700, Nicholas A. Bellinger wrote: > The break aborts the DataIN send loop and invokes ft_queue_status() > below in an attempt to send TASK_SET_FULL status. > > If the ft_queue_status() -> lport->tt.seq_send() also fails, then > -ENOMEM will be returned to the target a

Re: [PATCH 0/2] tcm_fc: Generate TASK_SET_FULL for DataIN + response failures

On Fri, 2014-06-06 at 14:09 -0700, Nicholas A. Bellinger wrote: > > So if you don't mind I'll go ahead and queue these up for now in > target-pending/for-next, given they are pretty straight-forward fixes. > > If they end up being problematic, they can be dropped before the v3.16 > PULL request g

Re: [PATCH 2/2] tcm_fc: Generate TASK_SET_FULL status for response failures

onse. > > It also does the same for a fc_frame_alloc() failures, in order to > signal the initiator that it should try to reduce it's current > queue_depth, to lower the number of outstanding I/Os on the wire. > > Reported-by: Vasu Dev > Cc: Vasu Dev >

Re: [PATCH 1/2] tcm_fc: Generate TASK_SET_FULL status for DataIN failures

gt; Also, add a check to skip sending DataIN if TASK_SET_FULL status > has already been set due to a response lport->tt.seq_send() > failure, that has asked target-core to requeue a response. > > Reported-by: Vasu Dev > Cc: Vasu Dev > Cc: Jun Wu > Signed-off

Re: [PATCH 0/2] tcm_fc: Generate TASK_SET_FULL for DataIN + response failures

On Thu, 2014-06-05 at 23:30 +, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > Hi Vasu, > > This series generates SAM_STAT_TASK_SET_FULL status for lport->tt.seq_send() > failures in DataIN + response status codepaths, which is done in order to get > the initiator to reduce it's

Re: [Open-FCoE] [PATCH] fc: ensure scan_work isn't active when freeing fc_rport

[] kthread+0xed/0x100 > [] ? insert_kthread_work+0x80/0x80 > [] ret_from_fork+0x7c/0xb0 > [] ? insert_kthread_work+0x80/0x80 > > Seems to be because the scan_work work_struct might be active when the housing > fc_rport struct gets freed. Ensure that we cancel it prior to freeing the &g

[PATCH] Fixed build failure when using -j option of make.

This patch removed make dependency on any other .o files which were causing build failure when make -j 10 used. So moved other .o related code under openfc dir as these .o files were used only by openfc module. Signed-off-by: Vasu Dev <[EMAIL PROTECTED]> --- drivers/scsi/ofc/Ma

[PATCH 2/5] Removed outer port use from fcs

will be used for frame alloc and removing inner port later. Also moved outer port event list to fcs_state. Signed-off-by: Vasu Dev <[EMAIL PROTECTED]> --- drivers/scsi/ofc/include/fc_local_port.h|2 + drivers/scsi/ofc/include/fcs_state.h|4 ++ drivers/scsi/ofc

[PATCH 4/5] Fixed style error reported by checkpatch

Fixed checkpatch ERROR here: do not use assignment in if condition (+ } else if ((fp = fc_frame_alloc(lp->dev, sizeof(*pl))) == NULL) Signed-off-by: Vasu Dev <[EMAIL PROTECTED]> --- drivers/scsi/ofc/libfc/fc_sess.c | 57 +- 1 files changed, 31 i

[PATCH 0/5] Series short description

cdev will simplify openFC implementation which will help in converting OpenFC into generic libfc library as suggested by linux-scsi reviewers. -- Signature : Vasu Dev <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a me

[PATCH 3/5] Removed outer port use in fc_exch

Used fcdev for frame_alloc instead outer port. The frame_alloc() is modified in next patch with its all other references. Signed-off-by: Vasu Dev <[EMAIL PROTECTED]> --- drivers/scsi/ofc/include/fc_exch.h |5 +++-- drivers/scsi/ofc/include/fc_frame.h|2 ++ drivers/scsi/ofc

[PATCH 1/5] Removed outer port allocation

Instead used fcs_recv() port ingress function directly. The port egress and frame-alloc functions will be used from fcdev directly. Signed-off-by: Vasu Dev <[EMAIL PROTECTED]> --- drivers/scsi/ofc/openfc/openfc_if.c | 19 +-- 1 files changed, 1 insertions(+), 18 del

[PATCH 5/5] Removed fc_port from fc_frame_alloc()

Instead used fcdev. Signed-off-by: Vasu Dev <[EMAIL PROTECTED]> --- drivers/scsi/ofc/include/fc_frame.h| 17 + drivers/scsi/ofc/libfc/fc_disc_targ.c |4 ++-- drivers/scsi/ofc/libfc/fc_frame.c |4 ++-- drivers/scsi/ofc/libfc/fc_local_port.c

[PATCH] Removed sa_timer functions as part of libsa cleanup

Instead used standard Linux timer functions directly Signed-off-by: Vasu Dev <[EMAIL PROTECTED]> --- drivers/scsi/ofc/include/sa_timer.h | 96 --- drivers/scsi/ofc/libfc/fc_disc_targ.c | 20 +++--- drivers/scsi/ofc/libfc/fc_exch.c

[PATCH] Allow FCoE to run on top of VLAN driver even though it has no pause.

If the net_device has no ethtool ops and it is a VLAN, find the underlying physical device using the VLAN driver's macro, and use it's ethtool ops. Signed-off-by: Vasu Dev <[EMAIL PROTECTED]> --- drivers/scsi/ofc/fcoe/fcoe_def.h |1 + drivers/scsi/ofc/fcoe/fcoe_if.c |

[PATCH 2/2] Removed unused sa_log functions

Signed-off-by: Vasu Dev <[EMAIL PROTECTED]> --- drivers/scsi/ofc/libsa/Makefile|1 drivers/scsi/ofc/libsa/sa_cons_linux.c | 37 -- drivers/scsi/ofc/libsa/sa_log.c| 117 3 files changed, 0 insertions(+), 155 deletions(-)

[PATCH 0/2] Series short description

The following series implements... Cleaned up FCoE logging by use of simpler logging macro OFC_DBG. -- Signature - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.htm