From: Tyrel Datwyler
Wire up the host_reset function in our driver_template to allow a user
requested adpater reset via the host_reset sysfs attribute.
Example:
echo "adapter" > /sys/class/scsi_host/host0/host_reset
Signed-off-by: Tyrel Datwyler
---
Changes in v2:
remo
From: Tyrel Datwyler
The current implemenation relies on two flags in the drivers private host
structure to signal the need for a host reset or to reenable the CRQ after a
LPAR migration. This patch does away with those flags and introduces a single
action flag and defined enums for the
From: Tyrel Datwyler
After a successful SRP login response we call scsi_unblock_requests() to
kick any pending IO's. The callback to process this SRP response happens in
a tasklet and therefore is in softirq context. The result of such is
that when blk-mq is enabled it is no longer safe to
On 05/02/2019 02:50 PM, Brian King wrote:
> On 5/1/19 7:47 PM, Tyrel Datwyler wrote:
>> From: Tyrel Datwyler
>>
>> Wire up the host_reset function in our driver_template to allow a user
>> requested adpater reset via the host_reset sysfs attribute.
>>
>> Exa
On 05/02/2019 02:43 PM, Brian King wrote:
> On 5/1/19 7:47 PM, Tyrel Datwyler wrote:
>> From: Tyrel Datwyler
>>
>> The current implemenation relies on two flags in the drivers private host
>> structure to signal the need for a host reset or to reenable the CRQ afte
From: Tyrel Datwyler
Wire up the host_reset function in our driver_template to allow a user
requested adpater reset via the host_reset sysfs attribute.
Example:
echo "adapter" > /sys/class/scsi_host/host0/host_reset
Signed-off-by: Tyrel Datwyler
---
drivers/scsi/ibmvscsi/ib
From: Tyrel Datwyler
After a successful SRP login response we call scsi_unblock_requests() to
kick any pending IO's. The callback to process this SRP response happens in
a tasklet and therefore is in softirq context. The result of such is
that when blk-mq is enabled it is no longer safe to
From: Tyrel Datwyler
The current implemenation relies on two flags in the drivers private host
structure to signal the need for a host reset or to reenable the CRQ after a
LPAR migration. This patch does away with those flags and introduces a single
action flag and defined enums for the
On 01/10/2019 07:07 AM, Christoph Hellwig wrote:
> On Wed, Jan 09, 2019 at 06:58:56PM -0800, Tyrel Datwyler wrote:
>> While mapping DMA for scatter list when a scsi command is queued the
>> existing call to dma_alloc_coherent() in our map_sg_data() function
>> passes z
On 01/10/2019 07:07 AM, Christoph Hellwig wrote:
> On Wed, Jan 09, 2019 at 06:58:56PM -0800, Tyrel Datwyler wrote:
>> While mapping DMA for scatter list when a scsi command is queued the
>> existing call to dma_alloc_coherent() in our map_sg_data() function
>> passes z
have a spinlock holding the scsi host lock.
Fix this by passing GFP_ATOMIC to dma_alloc_coherent() to prevent any
sort of sleeping in atomic context deadlock.
Fixes: 4dddbc26c389 ("[SCSI] ibmvscsi: handle large scatter/gather lists")
Cc: sta...@vger.kernel.org
Signed-off-by: Tyre
-by: Tyrel Datwyler
---
drivers/scsi/ibmvscsi/ibmvscsi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c
index cb8535e..10d5e77 100644
--- a/drivers/scsi/ibmvscsi/ibmvscsi.c
+++ b/drivers/scsi/ibmvscsi/ibmvscsi.c
inlined from ‘ibmvscsi_probe’ at
> drivers/scsi/ibmvscsi/ibmvscsi.c:2221:7:
> drivers/scsi/ibmvscsi/ibmvscsi.c:265:3: warning: ‘strncpy’ specified
> bound 97 equals destination size [-Wstringop-truncation]
>
> CC: Bart Van Assche
> CC: Tyrel Datwyler
> Signed-off-by:
followup patch.
Cc: sta...@vger.kernel.org
Reported-by: Hannes Reinecke
Signed-off-by: Tyrel Datwyler
---
drivers/scsi/ibmvscsi/ibmvfc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/ibmvscsi/ibmvfc.h b/drivers/scsi/ibmvscsi/ibmvfc.h
index 9a0696f..b81a53c 100644
On 01/17/2018 05:38 PM, Christopher Díaz Riveros wrote:
> Trivial fix removes unneeded semicolons after switch blocks.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Christopher Díaz Riveros
> ---
Resending from the correct email address. :
On 01/17/2018 05:38 PM, Christopher Díaz Riveros wrote:
> Trivial fix removes unneeded semicolons after switch blocks.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Christopher Díaz Riveros
> ---
Acked-by: Tyrel Datwyler
On 10/25/2017 03:06 AM, Kees Cook wrote:
> In preparation for unconditionally passing the struct timer_list pointer to
> all timer callbacks, switch to using the new timer_setup() and from_timer()
> to pass the timer pointer explicitly.
>
> Cc: "Martin K. Petersen"
&
On 09/21/2017 08:13 AM, Brian King wrote:
> On 09/21/2017 05:02 AM, Hannes Reinecke wrote:
>> Hi Brian,
>>
>> I was looking at the ibmvfc code (trying to hook up libfc), and have
>> found this definition:
>>
>> struct ibmvfc_fcp_rsp_info {
>> __be16 reserved;
>> u8 rsp_code;
>> u8 re
On 09/07/2017 11:54 PM, Ouyangzhaowei (Charles) wrote:
> shost->async_scan should be protected by mutex_lock, otherwise the check
> of "called twice" won't work.
>
> Signed-off-by: Ouyang Zhaowei
> ---
> drivers/scsi/scsi_scan.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff -
On 08/31/2017 04:29 PM, Kees Cook wrote:
> This standardizes the callback and data prototypes in several places that
> perform casting, in an effort to remove more open-coded .data and
> .function uses in favor of setup_timer().
>
> Cc: Samuel Ortiz
> Cc: Tyrel Datwyl
On 08/31/2017 04:29 PM, Kees Cook wrote:
> This standardizes the callback and data prototypes in several places that
> perform casting, in an effort to remove more open-coded .data and
> .function uses in favor of setup_timer().
>
> Cc: Samuel Ortiz
> Cc: Tyrel Datwyl
On 07/03/2017 12:21 PM, Colin King wrote:
> From: Colin Ian King
>
> Trivial fix to spelling mistake in QEDF_INFO message and
> remove duplicated "since" (thanks to Tyrel Datwyler for spotting
> the latter issue).
>
> Signed-off-by: Colin Ian King
Reviewed-by: Tyrel Datwyler
On 07/03/2017 02:44 AM, Colin King wrote:
> From: Colin Ian King
>
> Trivial fix to spelling mistake in QEDF_INFO message
>
> Signed-off-by: Colin Ian King
> ---
> drivers/scsi/qedf/qedf_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/qedf/qedf_mai
>
> Signed-off-by: Arvind Yadav
Acked-by: Tyrel Datwyler
>
> Signed-off-by: Arvind Yadav
Acked-by: Tyrel Datwyler
Signed-off-by: Tyrel Datwyler
---
drivers/scsi/scsi_transport_fc.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/scsi/scsi_transport_fc.c b/drivers/scsi/scsi_transport_fc.c
index d4cf32d..6dd0922 100644
--- a/drivers/scsi/scsi_transport_fc.c
+++ b
On 05/09/2017 02:46 PM, Gustavo A. R. Silva wrote:
> Local variable _ret_ is assigned to a constant value and it is never
> updated again. Remove this variable and the dead code it guards.
>
> Addresses-Coverity-ID: 140761
> Signed-off-by: Gustavo A. R. Silva
> ---
Reviewed-by: Tyrel Datwyler
erityScan, CID#146149 ("Logically Dead Code")
>
> Signed-off-by: Colin Ian King
Reviewed-by: Tyrel Datwyler
le convoluted in my opinion, and
a bit hard
to follow. Otherwise,
Reviewed-by: Tyrel Datwyler
>
> SCSI spec says that the initiator that sends the abort task
> TM NEVER gets a response to the aborted op and with the current
> code it will send a response. Thus this fix will remove th
On 04/09/2017 07:15 PM, NeilBrown wrote:
>
> mempool_alloc() cannot fail when passed GFP_NOIO or any
> other gfp setting that is permitted to sleep.
> So remove this pointless code.
>
> Signed-off-by: NeilBrown
Acked-by: Tyrel Datwyler
> ---
> drivers/scsi/ibmvscsi/
On 04/14/2017 06:58 AM, Colin King wrote:
> From: Colin Ian King
>
> The check for an unsigned long being less than zero is always false
> so it is a redundant check and can be removed.
>
> Detected by static analysis with by PVS-Studio
>
> Signed-off-by: Colin Ian K
plate method overrides the host template one, so some
> drivers have to re-override the transport template one.
>
> Signed-off-by: Christoph Hellwig
Reviewed-by: Tyrel Datwyler
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to
On 12/09/2016 01:20 PM, Benjamin Herrenschmidt wrote:
> On Wed, 2016-12-07 at 17:31 -0600, Tyrel Datwyler wrote:
>> The first byte of each CRQ entry is used to indicate whether an entry is
>> a valid response or free for the VIOS to use. After processing a
>> response the
On 12/08/2016 01:06 AM, Johannes Thumshirn wrote:
> On Wed, Dec 07, 2016 at 05:31:26PM -0600, Tyrel Datwyler wrote:
>> The first byte of each CRQ entry is used to indicate whether an entry is
>> a valid response or free for the VIOS to use. After processing a
>> response the
On 12/08/2016 03:29 PM, Paolo Bonzini wrote:
>
>
> On 08/12/2016 00:31, Tyrel Datwyler wrote:
>> The first byte of each CRQ entry is used to indicate whether an entry is
>> a valid response or free for the VIOS to use. After processing a
>> response the driver set
are reordered when updating the valid byte.
Signed-off-by: Tyrel Datwyler
---
drivers/scsi/ibmvscsi/ibmvscsi.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c
index d9534ee..2f5b07e 100644
--- a/drivers/scsi/ibmvscsi
An unrecogonized or unsupported SRP response has its opcode currently
logged in decimal format. Log it in hex format instead so it can easily
be validated against the SRP specs values which are in hex.
Signed-off-by: Tyrel Datwyler
---
drivers/scsi/ibmvscsi/ibmvscsi.c | 2 +-
1 file changed, 1
Add each vscsi host adatper to a new global list_head named
ibmvscsi_head. There is no functional change. This is meant primarily
as a convience for locating adatpers from within the debugger or crash
utility.
Signed-off-by: Tyrel Datwyler
---
drivers/scsi/ibmvscsi/ibmvscsi.c | 3 +++
drivers
+
> 10 files changed, 398 insertions(+), 275 deletions(-)
For ibmvfc portion...
Acked-by: Tyrel Datwyler
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 10/13/2016 08:00 AM, Johannes Thumshirn wrote:
> fc_bsg_jobdone() and bsg_job_done() are 1:1 copies now so use the bsg-lib one
> instead of the FC private implementation.
>
> Signed-off-by: Johannes Thumshirn
> Reviewed-by: Hannes Reinecke
For ibmvfc parts,
Acked-by: Tyrel D
y: Hannes Reinecke
For ibmvfc parts,
Acked-by: Tyrel Datwyler
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
wed-by: Hannes Reinecke
For ibmvfc parts,
Acked-by: Tyrel Datwyler
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
: Hannes Reinecke
For ibmvfc parts,
Acked-by: Tyrel Datwyler
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
iewed-by: Hannes Reinecke
For ibmvfc parts,
Acked-by: Tyrel Datwyler
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
t; we can remove the function pointer from struct fc_bsg_job as well.
>
> Signed-off-by: Johannes Thumshirn
> Reviewed-by: Hannes Reinecke
For ibmvfc parts,
Acked-by: Tyrel Datwyler http://vger.kernel.org/majordomo-info.html
On 10/14/2016 03:25 PM, Steven Royer wrote:
> On 2016-10-13 11:02, Michael Cyr wrote:
>> Various fixes and cleanups for the ibmvscsis driver.
>> The first is a sort of prequel to the second, which is the primary
>> change (and the biggest). The rest are fairly small fixes.
>>
>> Michael Cyr (6):
>
On 09/19/2016 06:59 AM, Brian King wrote:
> If a VFC port gets unmapped in the VIOS, it may not respond with a CRQ init
> complete following H_REG_CRQ. If this occurs, we can end up having called
> scsi_block_requests and not a resulting unblock until the init complete
> happens, which may never oc
ch may never occur, and we end up hanging I/O requests.
> This patch ensures the host action stay set to IBMVFC_HOST_ACTION_TGT_DEL so
> we move all rports into devloss state and unblock unless we receive an
> init complete.
>
> Signed-off-by: Brian King
Acked-by: Tyrel Datwyler
On 09/16/2016 07:25 AM, Bryant G. Ly wrote:
> Signed-off-by: Bryant G. Ly
Reviewed-by: Tyrel Datwyler
> ---
> drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
> b/driv
On 09/09/2016 01:16 AM, Michael Opdenacker wrote:
> Hi James,
>
> Thank you very much for your help...
>
> On 02/07/2016 16:49, James Bottomley wrote:
>> On Sat, 2016-07-02 at 08:56 +0200, Michael Opdenacker wrote:
>>> The t10.org website containing SCSI-2 draft specifications now
>>> requires to
On 09/08/2016 08:04 AM, Wei Yongjun wrote:
> From: Wei Yongjun
>
> Fix typo in parameter description.
>
> Signed-off-by: Wei Yongjun
Reviewed-by: Tyrel Datwyler
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to
On 07/22/2016 07:03 AM, Wei Yongjun wrote:
> Using list_move_tail() instead of list_del() + list_add_tail().
>
> Signed-off-by: Wei Yongjun
Reviewed-by: Tyrel Datwyler
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of
Commit 655ee63cf371 added a "Completed" sense string with key 0xF to
snstext[], but failed to updated the upper bounds check of the sense key in
scsi_sense_key_string().
Fixes: 655ee63cf371 ("[SCSI] scsi constants: command, sense key + additional
sense strings")
Signed-of
On 08/09/2016 01:08 PM, Bart Van Assche wrote:
> On 08/04/2016 02:32 PM, Tyrel Datwyler wrote:
>> Commit 655ee63cf371 added a "Completed" sense string with key 0xF to
>> snstext[], but failed to updated the upper bounds check of the sense key in
>> scsi_
On 08/03/2016 02:36 PM, Tyrel Datwyler wrote:
> This patchset introduces optional FC-TAPE/FC Class 3 Error Recovery to the
> ibmvfc client driver.
>
> Tyrel Datwyler (2):
> ibmvfc: Set READ FCP_XFER_READY DISABLED bit in PRLI
> ibmvfc: add FC Class 3 Error Recovery support
Commit 655ee63cf371 added a "Completed" sense string with key 0xF to
snstext[], but failed to updated the upper bounds check of the sense key in
scsi_sense_key_string().
Fixes: 655ee63cf371 ("[SCSI] scsi constants: command, sense key + additional
sense strings")
Signed-of
pport
at boot time. When enabled the RETRY service parameter bit is set
during PRLI, and ibmvfc_cmd->flags includes the IBMVFC_CLASS_3_ERR
bit.
Signed-off-by: Tyrel Datwyler
---
drivers/scsi/ibmvscsi/ibmvfc.c | 10 ++
drivers/scsi/ibmvscsi/ibmvfc.h | 1 +
2 files changed, 11 in
The READ FCP_XFER_READY DISABLED bit is required to always be set to
one since FCP-3. Set it in the service parameter page frame during
process login.
Signed-off-by: Tyrel Datwyler
---
drivers/scsi/ibmvscsi/ibmvfc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/ibmvscsi
This patchset introduces optional FC-TAPE/FC Class 3 Error Recovery to the
ibmvfc client driver.
Tyrel Datwyler (2):
ibmvfc: Set READ FCP_XFER_READY DISABLED bit in PRLI
ibmvfc: add FC Class 3 Error Recovery support
drivers/scsi/ibmvscsi/ibmvfc.c | 11 +++
drivers/scsi/ibmvscsi
On 07/29/2016 06:30 AM, Johannes Thumshirn wrote:
> Check for the existence of piocb->vport before accessing it.
>
> Signed-off-by: Johannes Thumshirn
Reviewed-by: Tyrel Datwyler
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body
On 06/15/2016 06:00 AM, Johannes Thumshirn wrote:
> Check for the existance of pciob->vport before accessing it.
piocb mispelled.
>
> Signed-off-by: Johannes Thumshirn
> ---
> drivers/scsi/lpfc/lpfc_sli.c | 13 -
> 1 file changed, 4 insertions(+), 9 deletions(-)
>
> diff --git a/d
I'm seeing a non-deterministic I/O hang with the ibmvfc driver when we
migrate a guest/partition to a different machine. So, on the occasions
when this hits the systems becomes unresponsive blocked on I/O. I
started by inspecting Scsi_Host of the driver which shows shost->state =
SHOST_RECOVERY exp
On 02/12/2016 08:43 AM, James Bottomley wrote:
> On Wed, 2016-02-10 at 19:32 -0600, Tyrel Datwyler wrote:
>> Add defines for mad version and mad os_type, and replace the magic
>> numbers in set_adapter_info() accordingly.
>>
>> Signed-off-by: Tyrel Datwyler
>>
When logging async events the scsi_id, wwpn, and node_name values
are used directly from the CRQ struct which are of type __be64. This
can be confusing to someone looking through the log on a LE system.
Instead byteswap these values to host endian prior to logging.
Signed-off-by: Tyrel Datwyler
support of PING messages between the VIOS and
client adapter relies on VIOSRP_INLINE_FORMAT crq messages.
Corrected these enum values to match PAPR definitions.
Signed-off-by: Tyrel Datwyler
Reviewed-by: Johannes Thumshirn
---
drivers/scsi/ibmvscsi/viosrp.h | 4 ++--
1 file changed, 2 insertions(+), 2
Add defines for mad version and mad os_type, and replace the magic
numbers in set_adapter_info() accordingly.
Signed-off-by: Tyrel Datwyler
---
drivers/scsi/ibmvscsi/ibmvscsi.c | 8
drivers/scsi/ibmvscsi/viosrp.h | 3 +++
2 files changed, 7 insertions(+), 4 deletions(-)
diff --git a
orted by any AIX based VIOS.
Treating as bit rot and removing the associated host config code.
The config attribute and its show function are left as not to break
userspace. The behavior remains the same returning nothing.
Signed-off-by: Tyrel Datwyler
---
drivers/scsi/ibmvscsi/ibmvscsi.c
initialize (0x01) and initialize complete
(0x02). Define these values as enums and use them in the code in
place of their magic number equivalents.
Signed-off-by: Tyrel Datwyler
---
drivers/scsi/ibmvscsi/ibmvscsi.c | 18 +-
drivers/scsi/ibmvscsi/viosrp.h | 12
2 files
The root node of the OF device tree is exported as of_root. No need
to look up the root by path name. Instead just get a reference
directly via of_root.
Signed-off-by: Tyrel Datwyler
Reviewed-by: Johannes Thumshirn
---
drivers/scsi/ibmvscsi/ibmvscsi.c | 14 ++
1 file changed, 6
: Tyrel Datwyler
Reviewed-by: Johannes Thumshirn
---
drivers/scsi/ibmvscsi/ibmvscsi.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c
index e8d4af5..6025481 100644
--- a/drivers/scsi/ibmvscsi/ibmvscsi.c
In a couple places the magic value of 2 is used to check the return
code of hypercalls. This translates to H_CLOSED.
Signed-off-by: Tyrel Datwyler
---
drivers/scsi/ibmvscsi/ibmvscsi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b
lid != VIOSRP_CRQ_FREE before handling in place
of hacky bitwise & to check for first bit being set.
-Added define for AIX os_type
-Left sysfs config attribute to prevent breaking userspace
Tyrel Datwyler (7):
ibmvscsi: Correct values for several viosrp_crq_format enums
ibmvscsi: Add and use enums for va
On 02/09/2016 09:41 AM, Manoj Kumar wrote:
>> Yeah, I can see how that is confusing. Since, all three possible valid
>> crq message types have the first bit set I think this was originally a
>> cute hack to grab anything that was likely valid. Then in
>> ibmvscsi_handle_crq() we explicitly match th
On 02/04/2016 11:55 AM, Manoj Kumar wrote:
> On 2/3/2016 5:28 PM, Tyrel Datwyler wrote:
>> The PAPR defines four valid header values for the first byte of a
>> CRQ message. Namely, an unused/empty message (0x00), a valid
>> command/response entry (0x80), a valid initialization
On 02/04/2016 12:03 AM, Johannes Thumshirn wrote:
> On Wed, Feb 03, 2016 at 05:28:33PM -0600, Tyrel Datwyler wrote:
>> A VIOSRP_HOST_CONFIG_TYPE management datagram (MAD) has existed in
>> the code for some time. From what information I've gathered from
>> Brian King this
support of PING messages between the VIOS and
client adapter relies on VIOSRP_INLINE_FORMAT crq messages.
Corrected these enum values to match PAPR definitions.
Signed-off-by: Tyrel Datwyler
---
drivers/scsi/ibmvscsi/viosrp.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a
Add defines for mad version and mad os_type, and replace the magic
numbers in set_adapter_info() accordingly.
Signed-off-by: Tyrel Datwyler
---
drivers/scsi/ibmvscsi/ibmvscsi.c | 4 ++--
drivers/scsi/ibmvscsi/viosrp.h | 2 ++
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a
magic number equivalents.
Signed-off-by: Tyrel Datwyler
---
drivers/scsi/ibmvscsi/ibmvscsi.c | 14 +++---
drivers/scsi/ibmvscsi/viosrp.h | 7 +++
2 files changed, 14 insertions(+), 7 deletions(-)
diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c
index
orted by any AIX based VIOS.
Treating as bit rot and removing the sysfs interface and associated
host config code accordingly.
Signed-off-by: Tyrel Datwyler
---
drivers/scsi/ibmvscsi/ibmvscsi.c | 78
drivers/scsi/ibmvscsi/viosrp.h | 7
2 files ch
: Tyrel Datwyler
---
drivers/scsi/ibmvscsi/ibmvscsi.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c
index a2b8db1..3621ac5 100644
--- a/drivers/scsi/ibmvscsi/ibmvscsi.c
+++ b/drivers/scsi/ibmvscsi
The root node of the OF device tree is exported as of_root. No need
to look up the root by path name. Instead just get a reference
directly via of_root.
Signed-off-by: Tyrel Datwyler
---
drivers/scsi/ibmvscsi/ibmvscsi.c | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
diff
Fixed up a couple spots that were out of line with the PAPR in regards
to its defined VSCSI protocol. Did away with some magic numbers directly
in the code. Fixed a minor endian issue.
Tyrel Datwyler (6):
ibmvscsi: Correct values for several viosrp_crq_format enums
ibmvscsi: Add and use enums
On 09/10/2015 02:23 AM, Laurent Vivier wrote:
> As devices with values greater than that are silently ignored,
> this gives some hints to the sys admin to know why he doesn't see
> his devices...
>
> Signed-off-by: Laurent Vivier
Acked-by: Tyrel Datwyler
> ---
&
On 09/10/2015 02:23 AM, Laurent Vivier wrote:
> QEMU allows until 32 LUNs.
>
> Signed-off-by: Laurent Vivier
Acked-by: Tyrel Datwyler
> ---
> drivers/scsi/ibmvscsi/ibmvscsi.c | 5 -
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/
On 09/10/2015 02:23 AM, Laurent Vivier wrote:
> The value of the parameter is never re-read by the driver,
> so a new value is ignored. Let know the user he
> can't modify it by removing writable attribute.
>
> Signed-off-by: Laurent Vivier
Acked-by: Tyrel Datwyler
> --
o this exact
> reasoning.
>
> Signed-off-by: Nicholas Krause
Again, just a nit on the patch description wording. Something like the
following would suffice.
"Remove mention of -ENXIO from comment on return values for
ibmvfc_slave_alloc() as the function currently always returns 0.&quo
vfc_handle_crq
Change type of rc variable in ibmvfc_handle_crq() to match return type
of ibmvfc_send_crq_init_complete()."
Otherwise,
Acked-by: Tyrel Datwyler
> ---
> drivers/scsi/ibmvscsi/ibmvfc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/driver
e comments about return values from ibmvfc_init_host() and
ibmvfc_reinit_host() as they are both declared to have return type void."
Otherwise,
Acked-by: Tyrel Datwyler
> ---
> drivers/scsi/ibmvscsi/ibmvfc.c | 4
> 1 file changed, 4 deletions(-)
>
> diff --git a/dr
y: Nicholas Krause
Acked-by: Tyrel Datwyler
> ---
> drivers/scsi/ibmvscsi/ibmvscsi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c
> b/drivers/scsi/ibmvscsi/ibmvscsi.c
> index 6a41c36..70ea976 100644
> --- a/drivers/scsi/ibmvscs
On 01/27/2015 11:57 PM, Bart Van Assche wrote:
[snip]
>
> Hello Tyrel,
>
> Since the ibmvscsi driver does not set QUEUE_FLAG_BIDI neither the code
> under "case DMA_BIDIRECTIONAL" nor the code under "if
> (scsi_bidi_cmnd(cmd))" is ever executed. The only reason why I proposed
> this change is t
On 01/23/2015 04:10 AM, Bart Van Assche wrote:
> Signed-off-by: Bart Van Assche
> Cc: Brian King
> Cc: Nathan Fontenot
> ---
> drivers/scsi/ibmvscsi/ibmvscsi.c | 10 ++
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c
> b/drivers/scsi
Change maintainer of ibmvscsi driver to Tyrel Datwyler.
Signed-off-by: Tyrel Datwyler
Cc: Nathan Fontenot
Cc: Brian King
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 79b2e4b..a646b94 100644
--- a/MAINTAINERS
+++ b
Change maintainer of ibmvfc driver to Tyrel Datwyler.
Signed-off-by: Tyrel Datwyler
Cc: Nathan Fontenot
Cc: Brian King
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index a646b94..f0d7593 100644
--- a/MAINTAINERS
+++ b
Added big endian annotations to relevant data structure fields, and necessary
byte swappings to support little endian builds.
Signed-off-by: Brian King
Signed-off-by: Tyrel Datwyler
---
drivers/scsi/ibmvscsi/ibmvfc.c | 473 +
drivers/scsi/ibmvscsi
94 matches
Mail list logo
